Merge Hd/bugfix #4883

sebastienlagarde · 2021-06-10T19:29:34Z

Purpose of this PR

Removing the word Radii from exposure settings (Removing the word Radii from exposure settings #4854)
Fixed the transparent cutoff not working properly in semi-transparent and color shadows (case 1340234). (Fixed the transparent cutoff not working properly in semi-transparent and color shadows (case 1340234). #4756)
Use non jittered projection in outline pass (Use non jittered projection in outline pass #4836)
[HDRP][Path Tracing] Sky settings now properly taken into account when using recorder ([HDRP][Path Tracing] Sky settings now properly taken into account when using recorder #4856)
Fix Resolution Issues for Physically Based Depth of Field (Fix Resolution Issues for Physically Based Depth of Field #4848)
Fixed bug introduced by sky-for-recorder support. ([HDRP][Path Tracing] Fixes bug introduced by previous sky-while-recording change #4906)
[Fogbugz 1341576] Memory leaks when the player is paused, and the user changes pipeline… ([Fogbugz 1341576] Memory leaks when the player is paused, and the user changes pipeline… #4845)

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

* Fix AxF debug output in certain configurations. * Update comment

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…4599)" This reverts commit 2325e3f.

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…positor (#4599)"" This reverts commit 30fffd5.

… the Graphi

…ing only the RTSSS Data (case 1332904). (#4626) * Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). * Add test scene Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix planar reflection * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* - Updated the recursive rendering documentation (case 1338639). * review fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…eflection probe are updated same frame (#4812) * Don't mark as rendered for reflection probes as we want the cached version to be from main view * Do the thing just for directional * Doc update * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Rename in UX * Update docs

* Shadow matte support. * Updated changelog. * Only take occluders into account, closer match to raster mode. * Added test scene. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

This reverts commit 85ebbc2.

… and color shadows (case 1340234). (#4756) * Fixed the transparent cutoff not working properly in semi-transparent and color shadows (case 1340234). * Update test ref image Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…n using recorder (#4856) * Make sure sky settings are correctly set when recording. * Updated changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Add the necesarry texture coordinate clamping for RTHandle for color pyramid sampling * Add some resolution independence, fitted for 1920x1080 * Changelog * Switch back to point sampling from trilinear, with commentary * Update test reference images * Small correction to the point sampling, always sample mip 0. * Re-update the test images, for mip 0 color sampling * Use a simpler UV scaling/clamping since we are now point sampling. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…r changes pipeline… (#4845) * Memory leaks when the player is paused, and the user changes pipeline settings * changelog

* Merge Hd/bugfix #4883 * Only apply wind deformation to ST8 when a nonzero wind vector is set #4905 * [HDRP] Merge Hd/bugfix #4943 * Revert: Fix Resolution Issues for Physically Based Depth of Field #4848 * Update CHANGELOG.md Co-authored-by: Tianliang Ning <paula.s.ning@gmail.com>

pmavridis and others added 30 commits May 26, 2021 19:23

[HDRP] Fix AxF debug output in certain configurations (#4641)

5945333

* Fix AxF debug output in certain configurations. * Update comment

Fix SSR accumulation white flash (#4648)

64a6c13

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Display Info Box when MSAA + ray tracing is onr (#4627)

f49b710

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix distortion when resizing the window in player builds with the Gra…

05cc16a

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Add support for the camera bridge in the graphics compositor (#4599)

2325e3f

Merge branch 'master' into hd/bugfix

c09379f

Fix Jittered Project Matrix Infinite Far Clip Plane (#4638)

b5962c9

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed a memory leak related to not disposing of the RTAS at the end H…

77b6b7f

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix custom pass utils Blur + Copy overdraw. (#4623)

bf941a9

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix draw procedural invalid pass idx 1 on first template load (#4632)

806dfbe

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Changed light reset to preserve type (#4624)

88779ea

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Add support for the camera bridge in the graphics compositor (#…

30fffd5

…4599)" This reverts commit 2325e3f.

AxF carpaint: Fix a compilation issue on Vulkan until the cpp HLSLcc …

aabbb4b

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Revert "Add support for the camera bridge in the graphics com…

dfdb311

…positor (#4599)"" This reverts commit 30fffd5.

revert: Fix distortion when resizing the window in player builds with…

891fda0

… the Graphi

Merge branch 'master' into hd/bugfix

7b17e06

Merge branch 'master' into hd/bugfix

32df1bf

Fix for discrepancies in saturation and intensity between screen spac…

0032b9c

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

Fix a Divide-by-Zero Warning for some Anisotropic Models (Fabric, Lit) (

41716f0

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP] Fix VfX lit particle AOV output color space (#4646)

333c800

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP][Path Tracing] Fixed transparent unlit (#4605)

809316c

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

7b1ad29

Fix distortion with MSAA (#4711)

08a578d

Fix contact shadow debug views (#4720)

3c418c0

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Update Decal-Projector.md (#4695)

352f65d

[HDRP] Fixed nullref when deleting the texture asset assigned in a lo…

acc5073

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

fd54a00

Fix decal layer enum (#4753)

1672dc6

Fix typo

c40c5c5

FrancescoC-unity and others added 14 commits June 8, 2021 00:14

Fix volumetric fog in planar reflections (#4736)

97a953e

* Fix planar reflection * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix motion blur compute dispatch size (#4737)

419850b

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

- Updated the recursive rendering documentation (case 1338639). (#4759)

fc7efde

* - Updated the recursive rendering documentation (case 1338639). * review fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix cropping issue with the compositor camera bridge (#4802)

c674c41

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix for unused resources in depth of field (#4796)

e47a172

Merge branch 'master' into hd/bugfix

131d1cd

Merge branch 'master' into hd/bugfix

666d37f

Removing the word Radii from exposure settings (#4854)

61518ea

* Rename in UX * Update docs

[HDRP][Path Tracing] Support for shadow mattes (#4745)

85ebbc2

* Shadow matte support. * Updated changelog. * Only take occluders into account, closer match to raster mode. * Added test scene. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "[HDRP][Path Tracing] Support for shadow mattes (#4745)"

ad127f5

This reverts commit 85ebbc2.

Use non jittered projection in outline pass (#4836)

83ddbed

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP][Path Tracing] Sky settings now properly taken into account whe…

2d9d391

…n using recorder (#4856) * Make sure sky settings are correctly set when recording. * Updated changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

sebastienlagarde requested a review from JulienIgnace-Unity June 10, 2021 19:29

JulienIgnace-Unity approved these changes Jun 14, 2021

View reviewed changes

sebastienlagarde added HDRP needs-backport-10.x needs-backport-2021.1 labels Jun 14, 2021

eturquin and others added 2 commits June 14, 2021 21:27

Fixed bug introduced by sky-for-recorder support. (#4906)

5c6b711

[Fogbugz 1341576] Memory leaks when the player is paused, and the use…

3cb7354

…r changes pipeline… (#4845) * Memory leaks when the player is paused, and the user changes pipeline settings * changelog

sebastienlagarde marked this pull request as ready for review June 16, 2021 07:57

Merge branch 'master' into hd/bugfix

1ee6c2d

sebastienlagarde merged commit 0e0b92c into master Jun 16, 2021

sebastienlagarde added backported-10.x and removed needs-backport-10.x labels Jun 19, 2021

sebastienlagarde added a commit that referenced this pull request Jun 19, 2021

Merge Hd/bugfix #4883

a880666

sebastienlagarde mentioned this pull request Jun 19, 2021

[10.x.x backport][HDRP] Backport https://github.com/Unity-Technologies/Graphics/pull/4883 #4964

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge Hd/bugfix #4883

Merge Hd/bugfix #4883

Uh oh!

sebastienlagarde commented Jun 10, 2021 •

edited

Loading

Uh oh!

Uh oh!

Merge Hd/bugfix #4883

Merge Hd/bugfix #4883

Uh oh!

Conversation

sebastienlagarde commented Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Comments to reviewers

Uh oh!

Uh oh!

sebastienlagarde commented Jun 10, 2021 •

edited

Loading