Skip to content

[8.x.x] Backports #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 27, 2020
Merged

[8.x.x] Backports #420

merged 10 commits into from
May 27, 2020

Conversation

phi-lira
Copy link
Contributor

@phi-lira phi-lira commented May 12, 2020

phi-lira added 7 commits May 12, 2020 15:59
* Fixed shader pass name issue (case 1201696)

* Fixed typo in encodedIrradiance.

* Fixed viewport rect not working with render textures.

* Added changelog

* Enabled Allocations tests when rendering.

* Forward Renderer is not sealed anymore. Now developers can subclass it.

* Added Test Scene

* Excluded post-processing tests from build.

* Enabled playmode tests for all assemblies

* Removed unnecessary new shader. UnlitTexture is used instead.

* Updated reference images.

* Updated scene to fix tests.
# Conflicts:
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/LinuxEditor/OpenGLCore/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/LinuxEditor/OpenGLCore/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/OSXEditor/Metal/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/OSXEditor/Metal/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/OSXEditor/OpenGLCore/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/OSXEditor/OpenGLCore/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/OSXPlayer/Metal/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/OSXPlayer/Metal/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/OSXPlayer/OpenGLCore/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/OSXPlayer/OpenGLCore/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/127_ClearRenderTexture.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/WindowsPlayer/Vulkan/127_ClearRenderTexture.png
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/WindowsPlayer/Vulkan/127_ClearRenderTexture.png.meta
#	com.unity.render-pipelines.universal/CHANGELOG.md

# Conflicts:
#	TestProjects/UniversalGraphicsTest/ProjectSettings/ProjectSettings.asset
#	com.unity.render-pipelines.universal/CHANGELOG.md
#	com.unity.render-pipelines.universal/Runtime/ForwardRenderer.cs
* Fixed allocation caused by camera sort.

* Added changelog.
# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
* Fixed issue that caused wrong computation of unity inverse view and projection matrix.

* Added graphics tests.

* filtered test 130 from android due to trunk issues.
# Conflicts:
#	TestProjects/UniversalGraphicsTest/ProjectSettings/EditorBuildSettings.asset
#	com.unity.render-pipelines.universal/CHANGELOG.md
@phi-lira phi-lira requested a review from a team as a code owner May 12, 2020 14:52
@phi-lira phi-lira requested a review from Verasl May 12, 2020 14:52
* Fixed GC pressure in volume component's GetHashCode

* Changelog update

* Update com.unity.render-pipelines.core/CHANGELOG.md

Co-Authored-By: Felipe Lira <felipedrl@gmail.com>

Co-authored-by: Felipe Lira <felipedrl@gmail.com>
@phi-lira phi-lira removed the request for review from Verasl May 14, 2020 06:53
phi-lira added 2 commits May 25, 2020 14:03
* updated terrain scene and reference images.

* Reverted non OSX Metal images

This reverts commit 1cba18b.
# Conflicts:
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/035_Shader_TerrainShaders.png.meta
# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
#	com.unity.render-pipelines.universal/Editor/RendererFeatures/RenderObjectsPassFeatureEditor.cs
Copy link
Contributor

@ellioman ellioman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@phi-lira phi-lira merged commit 26be20f into 8.x.x/release May 27, 2020
@phi-lira phi-lira deleted the 8.2.0/universal/backports branch May 27, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants