Fixed decal normal for double sided materials (case 1312065) #3610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
com.unity.render-pipelines.high-definition/Runtime/Material/Decal/DecalUtilities.hlsl
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Material/Decal/DecalUtilities.hlsl
Outdated
Show resolved
Hide resolved
sebastienlagarde
requested review from
a team
and removed request for
a team
com.unity.render-pipelines.high-definition/Runtime/Material/Decal/DecalUtilities.hlsl
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Material/Lit/Lit.shader
Show resolved
Hide resolved
sebastienlagarde
approved these changes
Feb 24, 2021
remi-chapelain
approved these changes
Feb 24, 2021
Merged
sebastienlagarde
added
backported-10.x
and removed
needs-backport-10.x
needs-backport-2021.1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
fix https://fogbugz.unity3d.com/f/cases/1312065/
In case the material is double sided, this PR now use the double-sided normal mode on the decal normal for the backface.
I wrote the upgrade guide acordingly
Testing status
tested the repro steps.
Warning: the decal projector projects on the backface of the plane in the repro project
Compared the result of the normal modes when using a decal with normals and when using a normal map on the material
Tested with decal applied on a shader graph material
On the graphic test for double sided, added objects with normals coming from a decal projector