Hdrp/fix probe blend distance UI #3329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine to me, but I am maintainer of the system, so gonna @RSlysz that usually deals with this kind of UI stuff alongside my LGTM 🟢 |
FrancescoC-unity
approved these changes
Feb 1, 2021
…ions, not the maximum.
kecho
force-pushed
the
HDRP/fix-probe-blend-distance-ui
branch
from
1fab599 to
dc314bc
Compare
sebastienlagarde
approved these changes
Feb 2, 2021
RSlysz
approved these changes
Feb 3, 2021
iM0ve
approved these changes
Feb 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Blend distance of reflection probes was being bound by max. Instead, it should be bound by the min of the size.
This causes some annoyance when editing the blend distance of a reflection probe.
Testing status
Tested manually by adding / removing a probe
Fogbugz: https://fogbugz.unity3d.com/f/cases/1306525/