Skip to content

Hd/fix wizard runtime resources #3123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

RSlysz
Copy link
Contributor

@RSlysz RSlysz commented Jan 15, 2021

Purpose of this PR

Fix bug https://fogbugz.unity3d.com/f/cases/edit/1287627 caused by a regression from PR #345 from a change after reviews. Bug was: in Wizard the runtime resource cannot be fixed once broken.


Testing status

Manually tested that wizard fix work as intended.


Comments to reviewers

@sebastienlagarde we must backport this to all version having the above mentioned PR.

@sebastienlagarde sebastienlagarde requested a review from a team January 15, 2021 11:19
Copy link
Contributor

@iM0ve iM0ve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue with a workaround just to reopen the project. Developer tested that the wizard now runs properly. I think its safe to merge, no additional testing is required.

@sebastienlagarde sebastienlagarde merged commit 229f3e8 into hd/bugfix Jan 15, 2021
@sebastienlagarde sebastienlagarde deleted the hd/fix-wizard-runtime-resources branch January 15, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants