Fix box light attenuation #3056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Note: Still need to investigate why tests with shadows are failing
fix both issues raised in https://fogbugz.unity3d.com/f/cases/1299693/
The attenuation was divided by the the distance to the box light, which would make it drop very quickly and go above the light intensity when close to the light
Also removes two unused variables.
Note: this changes quite significantly the behaviour of box lights with range attenuation
Testing status
Tested the repro project.
Tried various light ranges, with light close to objects and further than range, with range attenuation enabled and disabled and verified all works as expected.