Merge Hd/bugfix #3047

sebastienlagarde · 2021-01-11T10:04:20Z

Purpose of this PR

Fixed Render Graph immediate mode. (Fixed Render Graph immediate mode. #3033)
Fix issue with shadow mask and area lights (Fix issue with shadow mask and area lights #3019)
Fix issue with capture callback (now includes post processing results) ([HDRP] Fix issue with capture callback (now includes post processing results) #3035)
[HDRP] Fix decal draw order for ShaderGraph decal materials ([HDRP] Fix decal draw order for ShaderGraph decal materials #3018)
Fixed various Look Dev issues after exiting Playmode (Fixed various Look Dev issues after exiting Playmode #2956)
StackLit: Fix SG surface option property block to only display energy conserving specular color option for the specular input parametrization (similar to case 1257050) (StackLit: Fix SG surface option property block for energy conserving specular #3060)
Fixed missing BeginCameraRendering call for custom render mode of a Camera (Fixed missing BeginCameraRendering call for custom render mode of a Camera #3063)
Implement custom drawer for layer mask parameters (Implement custom drawer for layer mask parameters #3066)
Adding mixed light baking shadowmask test (Adding mixed light baking shadowmask test #3052)
Changed the clamping approach for RTR and RTGI (in both perf and quality) to improve visual quality. (Changed the clamping approach for RTR and RTGI (in both perf and quality) to improve visual quality. #3020)
Fixed the condition on temporal accumulation in the reflection denoiser (case 1303504). (Fixed the condition on temporal accumulation in the reflection denoiser (case 1303504). #3027)
Changed the warning message for ray traced area shadows (case 1303410). (Changed the warning message for ray traced area shadows (case 1303410). #3029)
Disabled specular occlusion for what we consider medium and larger scale rtao > 1.25 with a 25cm falloff interval. (Disabled specular occlusion for what we consider medium and larger scale rtao > 1.25 with a 25cm falloff interval. #3023)
Removed 2505_Area_Light_ShadowMask_Baking from baking queue (Removed 2505_Area_Light_ShadowMask_Baking from baking queue #3087)
Fix box light attenuation (Fix box light attenuation #3056)

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

* Not checking NdotL since it's not really valid for area lights (We have multiple valid light directions, not one) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

#3035) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed ShaderGraph decal draw order * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed access to invalid Contexts references after exiting playmode. * Fixed comparison gizmo after playmode. * Fixes from PR feedback

github-actions · 2021-01-11T10:04:55Z

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

… conserving specular color option for the specular input parametrization (similar to case 1257050) (#3060)

…amera (#3063)

* adding a shadow mask test * Update reference images

…ity) to improve visual quality. (#3020) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…er (case 1303504). (#3027) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…). (#3029) * - Changed the warning message for ray traced area shadows (case 1303410). * Adds approximation information about ray-traced area shadows Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…ale rtao > 1.25 with a 25cm falloff interval. (#3023) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Lightmaps / Removed scene from baking queue + meta files * update reference screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

* Fix box light attenuation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…arger scale rtao > 1.25 with a 25cm falloff interval. (#3023)" This reverts commit 55bb6ff.

…um and larger scale rtao > 1.25 with a 25cm falloff interval. (#3023)"" This reverts commit 57ee23b.

* Fix issue with register spilling in light list shaders #3016 * Fix a flickering issue related to moving shadow receivers (case 1302392) and a refactoring to avoid computing the same value for every effect. #3039 * Merge Hd/bugfix #3047 * [HDRP]Improvements and fixes on Volumes Components Inspectors #3072 * Fix XR depth copy and MSAA #3075 * [HDRP][Compositor] Fix issues with compositor's undo #3100 * Hdrp/docs/fix 1305538 (#3112) * Added information about using recursive rendering and other effects * Fixed formatting * [HDRP] Merge Hd/bugfix #3120 * Formatting Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

JulienIgnace-Unity and others added 6 commits January 8, 2021 14:01

Fixed Render Graph immediate mode. (#3033)

77bae01

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

Fix issue with shadow mask and area lights (#3019)

47bd6c2

* Not checking NdotL since it's not really valid for area lights (We have multiple valid light directions, not one) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix issue with capture callback (now includes post processing results) (

88daab3

#3035) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP] Fix decal draw order for ShaderGraph decal materials (#3018)

4313b48

* Fixed ShaderGraph decal draw order * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed various Look Dev issues after exiting Playmode (#2956)

a9c4c27

* Fixed access to invalid Contexts references after exiting playmode. * Fixed comparison gizmo after playmode. * Fixes from PR feedback

Merge branch 'master' into hd/bugfix

d358740

sebastienlagarde requested a review from JulienIgnace-Unity January 11, 2021 10:04

sebastienlagarde marked this pull request as draft January 11, 2021 10:04

github-actions bot added HDRP SRP labels Jan 11, 2021

sebastienlagarde added needs-backport-10.x needs-backport-2021.1 labels Jan 11, 2021

sebastienlagarde and others added 5 commits January 11, 2021 19:12

Merge branch 'master' into hd/bugfix

11b5984

StackLit: Fix SG surface option property block to only display energy…

a22cfa4

… conserving specular color option for the specular input parametrization (similar to case 1257050) (#3060)

Fixed missing BeginCameraRendering call for custom render mode of a C…

a3c36a5

…amera (#3063)

Implement custom drawer for layer mask parameters (#3066)

6cb6820

Adding mixed light baking shadowmask test (#3052)

ccf4f96

* adding a shadow mask test * Update reference images

JulienIgnace-Unity approved these changes Jan 12, 2021

View reviewed changes

sebastienlagarde marked this pull request as ready for review January 12, 2021 17:47

github-actions bot added the testing label Jan 12, 2021

sebastienlagarde marked this pull request as draft January 12, 2021 17:48

anisunity and others added 5 commits January 12, 2021 18:53

Changed the clamping approach for RTR and RTGI (in both perf and qual…

6149540

…ity) to improve visual quality. (#3020) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed the condition on temporal accumulation in the reflection denois…

cf36177

…er (case 1303504). (#3027) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Disabled specular occlusion for what we consider medium and larger sc…

55bb6ff

…ale rtao > 1.25 with a 25cm falloff interval. (#3023) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

fd53759

sebastienlagarde marked this pull request as ready for review January 12, 2021 19:25

sebastienlagarde and others added 2 commits January 13, 2021 12:40

Merge branch 'master' into hd/bugfix

f3699e8

Removed 2505_Area_Light_ShadowMask_Baking from baking queue (#3087)

6ef21e5

* Lightmaps / Removed scene from baking queue + meta files * update reference screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

sebastienlagarde marked this pull request as draft January 13, 2021 16:15

sebastienlagarde and others added 5 commits January 13, 2021 21:04

Removed unused index parameter

deebf14

Fix box light attenuation (#3056)

d28af0d

* Fix box light attenuation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Disabled specular occlusion for what we consider medium and l…

57ee23b

…arger scale rtao > 1.25 with a 25cm falloff interval. (#3023)" This reverts commit 55bb6ff.

Revert "Revert "Disabled specular occlusion for what we consider medi…

19558b8

…um and larger scale rtao > 1.25 with a 25cm falloff interval. (#3023)"" This reverts commit 57ee23b.

Fix default value of _SpecularOcclusionBlend

5ca22bc

sebastienlagarde marked this pull request as ready for review January 14, 2021 10:51

sebastienlagarde merged commit 55b4e8a into master Jan 14, 2021

sebastienlagarde deleted the hd/bugfix branch January 14, 2021 10:52

sebastienlagarde added backported-10.x and removed needs-backport-10.x labels Jan 17, 2021

sebastienlagarde added a commit that referenced this pull request Jan 17, 2021

Merge Hd/bugfix #3047

a5d6c2d

sebastienlagarde mentioned this pull request Jan 18, 2021

[10.x.x Backport] backport several PRs for HDRP #3142

Merged

sebastienlagarde added backported-2021.1 needs-backport-2021.1 and removed needs-backport-2021.1 backported-2021.1 labels Mar 2, 2021

sebastienlagarde added a commit that referenced this pull request Mar 2, 2021

Merge Hd/bugfix #3047

a97fda5

sebastienlagarde added backported-2021.1 and removed needs-backport-2021.1 labels Mar 2, 2021

sebastienlagarde mentioned this pull request Mar 2, 2021

[Backport 2021.1][HDRP] Multiple HDRP PR backport #3731

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge Hd/bugfix #3047

Merge Hd/bugfix #3047

Uh oh!

sebastienlagarde commented Jan 11, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Jan 11, 2021

Uh oh!

Uh oh!

Merge Hd/bugfix #3047

Merge Hd/bugfix #3047

Uh oh!

Conversation

sebastienlagarde commented Jan 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Comments to reviewers

Uh oh!

github-actions bot commented Jan 11, 2021

Uh oh!

Uh oh!

sebastienlagarde commented Jan 11, 2021 •

edited

Loading