Skip to content

Project skybox without perspective for ortho cameras #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Feb 2, 2021

Conversation

adrien-de-tocqueville
Copy link
Contributor

Purpose of this PR

https://fogbugz.unity3d.com/f/cases/1264647

project the sybox in a similar way to what builtin does for orthographic cameras
Alternative to #1936, which is less correct but more usable

the result is now independant of the camera size.

Testing status

compared result with what's on builtin

alelievr and others added 30 commits December 15, 2020 13:46
* Fix coat normal space

* Update CHANGELOG.md

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
…hadows with unconventional aspect ratio) (#2776)

* Fixed volume component tooltips using the same parameter name (#2754)

* Use the proper history info for Bicubic resampling in TAA (#2759)

* Use proper info for previous buffer info

* changelog

* Fixed lookdev movement (#2757)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [HDRP] Fix issue with saving some quality settings in volume overrides (#2758)

* Fix issue with saving some quality settings volume overrides

* Fix typo in changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [HDRP] Fixed NullReferenceException in HDRenderPipeline.UpgradeResourcesIfNeeded (case 1292524) (#2765)

* fix issue with confusing text (#2766)

* Fix

* Fix white dots

* Changelog

* Rename the sunrise icon to fix typo, causing issue with 2x resolution loading. (#2809)

* [HDRP] Rename HDRP to HD Render Pipeline in menu item (#2819)

* [HDRP] Update HDRP menu in shader graph

* Update CHANGELOG.md

* HDRP/Fix package version showing package after the last "verified" package (#2783)

* Fix typo

* Remove last version checker from wizard and add link to package manager instead

* Update CHANGELOG.md

* Update documentation

* Update Render-Pipeline-Wizard.md

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

* Revert bad changelog merge

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: John Parsaie <johnpa@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
* Fixed invalid loop length for probe baking (case 1289680)

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix volumetric fog with XR single-pass rendering

* update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix first frame exposure, depth pyramid / AO

* Update changelog

* Comment

* Typo

* Add missing RenderGraphBuilder.ReadTexture call

* Move ComputePackedMipChainInfo at the beginning of ExecuteWithRenderGraph

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix AOV api in rendergraph

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs

* Update changelog
…bled (#2925)

* Fix

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Move EndCameraRendering callback out of the profiling scope

* added a comment

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…case 1296203). (#2915)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed default eye shader blocks

* Fix missing emission block in hair shader

* Updated changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…in the light cluster depending on its baking status. (#2932)

* - Fixed using the wrong method to define if a light should be included in the light cluster depending on its baking status.

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ed (#2930)

* Changed the behavior of custom passes when the Custom Pass Volume component is disabled

* Updated changelog
…ing Quality Levels (#2921)

* Fixed display of LOD Bias and maximum level in frame settings when using Quality Levels

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ev is not supported. (#2929)

* Fixed an issue when trying to open a look dev env library when Look Dev is not supported.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…4694). (#2933)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…d to (case 1299617). (#2926)

* Fixed the planar depth texture not being properly created and rendered to (case 1299617).

* adding comment

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants