Skip to content

Added a warning when trying to bake with static lighting being in an invalid state. #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2020
Merged

Added a warning when trying to bake with static lighting being in an invalid state. #2597

merged 2 commits into from
Nov 13, 2020

Conversation

JulienIgnace-Unity
Copy link
Contributor

Purpose of this PR

Added a warning when trying to bake with static lighting being in an invalid state.

It is possible that HDRP hasn't rendered any frame when clicking the bake lighting button.
This can happen when baked lighting debug are used for example and no other window with HDRP is visible.
This will result in the static lighting cubemap not being up to date with what the user put in the Environment Lighting panel.
We detect this and issue a warning if applicable.

Testing status

Tested the repro steps:

  • Have only scene view displaying.
  • Bake lighting with a valid static sky.
  • Switch to debug baked lightmaps in the scene view.
  • Switch static sky to None and bake.
  • Switch back to a valid sky and bake again => lighting is not updated => This is where the warning should be issued.

Also made sure that the warning did not appear with a valid sky.

remi-chapelain
remi-chapelain approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one as already been discussed while pair-testing this repro with @JulienIgnace-Unity
Issue was found using 7.x.x but not problematic enough to backport I suppose ! ✔️

@sebastienlagarde sebastienlagarde marked this pull request as ready for review November 13, 2020 12:24
@sebastienlagarde sebastienlagarde changed the base branch from master to hd/bugfix November 13, 2020 12:24
@sebastienlagarde sebastienlagarde merged commit c7cd799 into hd/bugfix Nov 13, 2020
@sebastienlagarde sebastienlagarde deleted the hd/invalid-static-bake-warning branch November 13, 2020 12:24
sebastienlagarde pushed a commit that referenced this pull request Nov 17, 2020
@JulienIgnace-Unity @sebastienlagarde
Added a warning when trying to bake with static lighting being in an …
749a368 
…invalid state. #2597
sebastienlagarde added a commit that referenced this pull request Nov 17, 2020
@sebastienlagarde @FrancescoC-unity
@JordanL8 @JulienIgnace-Unity @adrien-de-tocqueville @alelievr @martint-unity @jenniferd-unity @slunity @remi-chapelain @fredericv-unity3d @fabien-unity @EvgeniiG @eturquin @RSlysz @Vic-Cooper @wackoisgod @pmavridis
Merge 8.x.x/hd/staging (#2652)
545ef23 
* Fix for potentially corrupted refraction result on xbox #1699

* Update HDRenderPipeline.LookDev.cs (#1740)

* Update Layered-Lit-Shader #1766

* Fix for assertion on undoing a mod of diffuse profile list with volume profile deleted #1769

* Fixed two issues with sky static lighting. #1775

* Better tooltip for exposure weight on emission fields. #1821

* Fix rendering of custom passes in the Custom Pass Volume inspector #1824

* Updated the implementation details for pb sky (#1872)

* Fixed typo in TextureCache2D.cs (#1896)

* Add disclaimer about object motion vectors not working in the scene view (#1900)

* Update Render-Pipeline-Debug-Window.md

* Update Render-Pipeline-Debug-Window.md

* Fix double addition to sorted volume lists #1916

* Fix issues with bloom sampling outside #1930

* fix case 1244430 removing camera comp from prefab #1953

* Fix nan in the pbr sky #1983

* [HDRP][LookDev] Ensure stylesheet are loaded before applying them on Domain Reload #1985

* Fix Custom Post Process affecting preview cameras #1988

* Fix box light disappearing when range is below 1 and no range attenuation #1989

* Fix matcap preferences serialization issue #2013

* [Backport 8.x.x] Fixed error Maximum allowed thread group count is 65535 when resolution is very high (#2623)

* [10.x.x] Axf: add normal gradients and all mapping modes (uv, planar, triplanar) #583

* [10.x.x] Axf fix shininess exp to roughness, ssr transparent and alpha test #587

* Update Light-Component.md (#682)

* push meta

* removed undesired change in AXF

* Fix transparent movec scene view #698

* Porting console fixes to staging (#699)

* Update HDRP-Camera.md (#706)

* Pre warm RT Handle system so that reallocations are reduced. #713

* Update PlanarReflectionProbeCache.cs

* Update preview naming in raytrace component #753

* Workaround for GetKernelThreadGroupSizes returning wrong data #760

* Sanitize transparent motion vectors setting #761

* Standard terrain upgrader (#762)

* Update Reflection-Probe (#790)

* Update Reflection-Probe.md

* Update Reflection-Probe.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix reflection probe framesettings override #796

* Force post process parent setting to be before child settings #799

* Fixed 1253367 by rebaking probe with missing baked texture. #818

* Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823

* Fixed blend distance editing (1248931) #838

* Fix API breaking change: Add Public quality to Raytracing volume effect

* Fix API breaking change: Add Public quality to Raytracing volume effect - RR

* Update HDR information. Also updated format and links. (#853)

* Fix message for metal and ao (#859)

* d Fix issue with the blue line of prefab modifications for Volume mode #860

* Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865

* Upgrade default legacy terrain to HDRP default TerrainLit (#883)

* Editing volumes via script doc (#884)

* Added Volumes API doc

* Update Volumes-API.md

* Changed terminology back to Volume Override

* Added terminology disclaimer

* Update HDRenderPipeline.cs (#994)

* Delete 9713_VirtualTexturing.meta

* Fix SSAO with double sided material and normal mode to none #1043

* Fix emissive mesh layer mask behaviour #1062

* Use the wide mode to force the UI drawing on a single line (1251235) #1064

* Fix custom pass after post process buffer #1072

* Fix for area light baked data not updating when changing the gizmo #1075

* Fixed an error when switch area light shape to disk while an emissive… #1112

* Have the PBR Sky not render black when below horizon #1116

* Find the appropriate default frame settings per editor (case 1247631) #1129

* Fix taaFrameIndex and restore TAA tests for XR #534

* fix typo in the Render Pipeline Wizard #1037

* Add light layer on indirect lighting controller #777

* [8.x.x Backport]  Fix exposure white flash when enabling SSR (#842)

* fix white flash

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#837)

* port

* changelog

* Update HDRenderPipeline.cs

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Fix depth pyramid issues with dynamic resolution (#847)

* Port

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1105)

* Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change.

* Fixed issue when using Custom

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fixed Look Dev with Light Theme (#1106)

* Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity.

# Conflicts:
#	com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fixed decal duplication when editing a prefab in context (#1107)

* Implemented proper culling for decals when used in prefabs and edited in context.

* Compilation fix

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix API breaking change in indirect controller

* Fix area light gizmo not updating engine side light v2 #1156

* Add missing ClothObj.

* HDRP: Default indirect Lighting controller Layers to Everything to ease the migration

* Update HDRenderPipelineResources.asset

* Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824)

a warning message when not in batch mode.

* Rename h to hlsl

* Update cas include paths (#1227)

* Fix XR single-pass macros in tessellation shaders #1160

* Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228

* [8.x.x backport] Fix issues with history sampling and hw dynamic res (#1777)

* Fix TAA dynamic res issue

* Changelog

* [Backport 8.x.x] Fixed an issue where look dev lighting would go black when a new scene is loaded. (#1322)

* Fixed an issue where look dev lighting would go black when a new scene is loaded.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix

* Changelog

Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>

* Update Feature-Comparison.md (#2111)

* Update Feature-Comparison.md

Changed Feature compatabilitty with AR Foundation from "No" to "Yes"

* Update Feature-Comparison.md

HDRP compatability with AR Foundation changed to "No".

* Remove XRSystemTests #2241

* HDRP - Fix XR shadows culling #2263

* Fix volument component creation via script #2369

* Adding support for CloudRendering to HDRP #2436

* Fix light resolution scalable settings in the Light Explorer #2470

* [HDRP] Fix issue when changing FoV with the physical camera fold-out closed #2570

* [Backport 8.x.x] Fix issue with previous frame exposure texture being not null, but containing garbage (#2621)

* [10.x.x] Axf: add normal gradients and all mapping modes (uv, planar, triplanar) #583

* [10.x.x] Axf fix shininess exp to roughness, ssr transparent and alpha test #587

* Update Light-Component.md (#682)

* push meta

* removed undesired change in AXF

* Fix transparent movec scene view #698

* Porting console fixes to staging (#699)

* Update HDRP-Camera.md (#706)

* Pre warm RT Handle system so that reallocations are reduced. #713

* Update PlanarReflectionProbeCache.cs

* Update preview naming in raytrace component #753

* Workaround for GetKernelThreadGroupSizes returning wrong data #760

* Sanitize transparent motion vectors setting #761

* Standard terrain upgrader (#762)

* Update Reflection-Probe (#790)

* Update Reflection-Probe.md

* Update Reflection-Probe.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix reflection probe framesettings override #796

* Force post process parent setting to be before child settings #799

* Fixed 1253367 by rebaking probe with missing baked texture. #818

* Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823

* Fixed blend distance editing (1248931) #838

* Fix API breaking change: Add Public quality to Raytracing volume effect

* Fix API breaking change: Add Public quality to Raytracing volume effect - RR

* Update HDR information. Also updated format and links. (#853)

* Fix message for metal and ao (#859)

* d Fix issue with the blue line of prefab modifications for Volume mode #860

* Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865

* Upgrade default legacy terrain to HDRP default TerrainLit (#883)

* Editing volumes via script doc (#884)

* Added Volumes API doc

* Update Volumes-API.md

* Changed terminology back to Volume Override

* Added terminology disclaimer

* Update HDRenderPipeline.cs (#994)

* Delete 9713_VirtualTexturing.meta

* Fix SSAO with double sided material and normal mode to none #1043

* Fix emissive mesh layer mask behaviour #1062

* Use the wide mode to force the UI drawing on a single line (1251235) #1064

* Fix custom pass after post process buffer #1072

* Fix for area light baked data not updating when changing the gizmo #1075

* Fixed an error when switch area light shape to disk while an emissive… #1112

* Have the PBR Sky not render black when below horizon #1116

* Find the appropriate default frame settings per editor (case 1247631) #1129

* Fix taaFrameIndex and restore TAA tests for XR #534

* fix typo in the Render Pipeline Wizard #1037

* Add light layer on indirect lighting controller #777

* [8.x.x Backport]  Fix exposure white flash when enabling SSR (#842)

* fix white flash

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#837)

* port

* changelog

* Update HDRenderPipeline.cs

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Fix depth pyramid issues with dynamic resolution (#847)

* Port

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1105)

* Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change.

* Fixed issue when using Custom

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fixed Look Dev with Light Theme (#1106)

* Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity.

# Conflicts:
#	com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fixed decal duplication when editing a prefab in context (#1107)

* Implemented proper culling for decals when used in prefabs and edited in context.

* Compilation fix

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix API breaking change in indirect controller

* Fix area light gizmo not updating engine side light v2 #1156

* Add missing ClothObj.

* HDRP: Default indirect Lighting controller Layers to Everything to ease the migration

* Update HDRenderPipelineResources.asset

* Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824)

a warning message when not in batch mode.

* Rename h to hlsl

* Update cas include paths (#1227)

* Fix XR single-pass macros in tessellation shaders #1160

* Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228

* [8.x.x backport] Fix issues with history sampling and hw dynamic res (#1777)

* Fix TAA dynamic res issue

* Changelog

* [Backport 8.x.x] Fixed an issue where look dev lighting would go black when a new scene is loaded. (#1322)

* Fixed an issue where look dev lighting would go black when a new scene is loaded.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix

* Changelog

Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>

* Added a warning when trying to bake with static lighting being in an invalid state. #2597

* Fix volumetric fog nan #2174

* Fixed a null ref in the volume component list when there is no volume components in the project #1282

Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Martin Thorzen <35328557+martint-unity@users.noreply.github.com>
Co-authored-by: jenniferd-unity <71718938+jenniferd-unity@users.noreply.github.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Vic-Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: Andrew Spiering <aspiering@gmail.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
@sebastienlagarde
Copy link
Contributor

https://fogbugz.unity3d.com/f/cases/1289240/

sebastienlagarde added a commit that referenced this pull request Nov 23, 2020
@sebastienlagarde @JulienIgnace-Unity
@FrancescoC-unity @adrien-de-tocqueville @pmavridis @alelievr @slunity
Merge Hd/bugfix - Set of bugfix for 10.3 (#2681)
8cd4922 
* Update 1900_AlphaTestSG.renderTexture (#2608)

* update GBuffer description.

* Added a warning when trying to bake with static lighting being in an invalid state. (#2597)

* Added a warning when trying to bake with static lighting being in an invalid state.

* Update changelog.

* [HDRP] Fix runtime debug UI showing wrong entry (#2595)

* Redraw debug before re-registring the debugs

* changelog

* Fixed multi-editing with new light intensity slider (#2600)

* Fixed multi-editing with new light intensity slider

* Only update floatValue when changed

* Fixed useless editor repaint when using lod bias (#2601)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix issue with density volume gizmo editing (#2603)

* Fix

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [HDRP][Compositor] Fix issues with image layers (#2606)

* Empty image layers in the graphics compositor don't render black anymore

* Improve camera management in compositor

* Revert "Improve camera management in compositor"

This reverts commit cc3971d.

* Update changelog

* For image layers that are first, still clear to black if no texture is attached

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed issue when decal projector material is none (#2615)

* Fixed angle fading when rotating decal projector (#2618)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix issue with gameview repaint in the graphics compositor (#2617)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Remove cyanish color shifting during sharpening in YCoCg in TAA (#2627)

* Do sharpening in RGB space.

* Fix alpha case

* Oops

* Ref update aside OSX

* OSX refs

* More refs

* Missing refs.

* Did I get the wrong ref?

* Fixed the sampling of the normal buffer in the the forward transparent pass. (#2643)

* Fixed the sampling of the normal buffer in the the forward transparent pass.

* Update changelog

* Update CHANGELOG.md

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

* Fix custom pass reorder issue (#2609)

* Fix custom pass reorder issue

* Fix bad comment

* Refactor

* Fix bloom prefiltering tooltip (#2715)

* update reference screenshot for test 1900_AlphaTest_SG

* Fix error when loading new scene (#2713)

* Fix error when loading new scene

* Update CHANGELOG.md

* AxF Fix missing alpha blend state properties and update stencil prop (#2705)

* AxF: Fix missing alpha blend state properties and update stencil properties.

* Add changelog entry.

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix custom pass normal and template (#2716)

* Fix custom pass template not compiling

* Fix custom pass normal buffer not bound

* Updated changelog

* Update CHANGELOG.md

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

* [HDRP][Compositor] Fix edge cases when cameras are missing or deleted  (#2700)

* Fix warning spam related to cameras in compositor

* Fix null reference in AOVs

* Fix null reference when disabling camera in the compositor

* Reset target texture when disabling the compositor

* Update changelog + fix warning when output camera is deleted

* Fix issue when adding image layer without any cameras in the scene

* Fix error when disabling layer with no camera

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Update CHANGELOG.md

Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
@JulienIgnace-Unity JulienIgnace-Unity mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@remi-chapelain remi-chapelain remi-chapelain approved these changes

Assignees
No one assigned
Labels
backported-7.x backported-8.x backported-10.x HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulienIgnace-Unity @sebastienlagarde @remi-chapelain