Remove clear resources at release from rendergraph debug menu #2156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoC-unity
requested review from
sebastienlagarde and
JulienIgnace-Unity
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Oct 9, 2020
sebastienlagarde
deleted the
HDRP/remove-debug-option-that-kills-debuig
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This debug mode clears the resources upon their release, however, that means setting a render target to said resources and then clear them.
This ends up being an issue since we lose the currently set render target and as a consequence the debug menu doesn't know where to draw itself.
The only solution for now is to hide such mode from UI (while keeping it available from code)