Custom pass scene visibility #2136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
FrancescoC-unity
approved these changes
Oct 9, 2020
sebastienlagarde
approved these changes
Oct 9, 2020
|
Merged for 10.1 package. |
|
Testing status looks sufficient. No additional QA needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR is a bit related to this issue: https://fogbugz.unity3d.com/f/cases/1277644/ but doesn't fix the case as it's by design.
It fixes the scene visibility buttons in the hierarchy for the custom pass, that was previously ignored
Testing status
Manually tested with a custom pass using a Draw Renderer to render a cube in the scene: (note that the cube is using a hidden layer in the editor, otherwise we'd just see the original cube)
Also tested that only the scene view is affected by the visibility changes.