-
Notifications
You must be signed in to change notification settings - Fork 844
[Yamato] Use cache server for Yamato jobs #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Is there a recent nightly/ABV? I only see some that are 4 or 5 days old. Would love to see one for hdrp.
@@ -12,21 +12,21 @@ PR_HDRP_trunk: | |||
dependencies: | |||
- path: .yamato/hdrp-win-dx11.yml#HDRP_Win_DX11_Standalone_mono_Linear_trunk | |||
rerun: on-new-revision | |||
- path: .yamato/hdrp-win-dx11.yml#HDRP_Win_DX11_playmode_mono_Linear_trunk | |||
- path: .yamato/hdrp-win-dx11.yml#HDRP_Win_DX11_playmode_cache_mono_Linear_trunk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if
- keeping the same name (just
playmode
) for the playmode cache jobs and - renaming the regular playmode jobs to
playmode_no_cache
would make sense? That would allow us to keep the same unique names in yamato, and keep the run history.
Maybe that's too much rework for too little benefits though, only an idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good point. my thought is that "no cache" has been the default for so long that i dont want to sneak in like a "hidden" change, but maybe that doesnt matter 🤔
Purpose of this PR
TIming improvements examples:
HDRP Windows DX11 playmode on master - execution time: 1 hour 20 minutes
HDRP Windows DX11 playmode on cache server branch - execution time: 20 minutes
HDRP Windows Vulkan playmode on master - execution time: 1 hour 50 minutes
HDRP Windows Vulkan playmode on cache server branch - execution time: 50 minutes
Testing status
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fuse-cache-server
Comments to reviewers
yamato/cache-server
, but moved to this new branch for a cleaner PR and to use the new "extra utr args"