Skip to content

[Yamato] Use cache server for Yamato jobs #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jan 13, 2021
Merged

Conversation

sophiaaar
Copy link
Contributor

@sophiaaar sophiaaar commented Oct 7, 2020

Purpose of this PR

  • Add a new test platform "playmode_cache"
  • Changed project pipelines to use playmode_cache in their CI (regular playmode is still available to kick off)

TIming improvements examples:
HDRP Windows DX11 playmode on master - execution time: 1 hour 20 minutes
HDRP Windows DX11 playmode on cache server branch - execution time: 20 minutes

HDRP Windows Vulkan playmode on master - execution time: 1 hour 50 minutes
HDRP Windows Vulkan playmode on cache server branch - execution time: 50 minutes


Testing status

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fuse-cache-server

  • re-ran several playmode_cache jobs to note the time go down

Comments to reviewers

  • previously tested on the branch yamato/cache-server, but moved to this new branch for a cleaner PR and to use the new "extra utr args"
  • Tried to enable cache server for builds but it didn't make a time difference (case id 1305607)
  • Failures match master

@github-actions github-actions bot added the yamato label Oct 7, 2020
Copy link
Contributor

@theopnv theopnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Is there a recent nightly/ABV? I only see some that are 4 or 5 days old. Would love to see one for hdrp.

@@ -12,21 +12,21 @@ PR_HDRP_trunk:
dependencies:
- path: .yamato/hdrp-win-dx11.yml#HDRP_Win_DX11_Standalone_mono_Linear_trunk
rerun: on-new-revision
- path: .yamato/hdrp-win-dx11.yml#HDRP_Win_DX11_playmode_mono_Linear_trunk
- path: .yamato/hdrp-win-dx11.yml#HDRP_Win_DX11_playmode_cache_mono_Linear_trunk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if

  • keeping the same name (just playmode) for the playmode cache jobs and
  • renaming the regular playmode jobs to playmode_no_cache

would make sense? That would allow us to keep the same unique names in yamato, and keep the run history.
Maybe that's too much rework for too little benefits though, only an idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good point. my thought is that "no cache" has been the default for so long that i dont want to sneak in like a "hidden" change, but maybe that doesnt matter 🤔

@sophiaaar
Copy link
Contributor Author

sophiaaar commented Jan 12, 2021

Awesome!
Is there a recent nightly/ABV? I only see some that are 4 or 5 days old. Would love to see one for hdrp.

@theo-pnv
havent ran full abv yet but here are some recent hdrp jobs:

remember to look at execution time rather than the overall job time :) and always look at the most recent - the first runs do the upload to the cache server, so they will be similar timings to master (some are still running, sorry.)

@sophiaaar sophiaaar marked this pull request as ready for review January 12, 2021 16:15
@sophiaaar sophiaaar requested a review from a team as a code owner January 12, 2021 16:15
@sophiaaar sophiaaar changed the title [Yamato] Use cache server for HDRP and URP [Yamato] Use cache server for Yamato jobs Jan 12, 2021
@sophiaaar sophiaaar merged commit c4eef42 into master Jan 13, 2021
@sophiaaar sophiaaar deleted the yamato/use-cache-server branch January 13, 2021 11:04
sophiaaar added a commit that referenced this pull request Jan 15, 2021
sophiaaar added a commit that referenced this pull request Jan 19, 2021
* backport #2113

* backport #2734

* backport #3119

* use non-cache for vfx_hdrp ci

Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants