Skip to content

Fixed shader warning on Xbox for ResolveStencilBuffer.compute #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Fixed shader warning on Xbox for ResolveStencilBuffer.compute #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc3ea72
fix warning
FrancescoC-unity Apr 17, 2020
36d652e
changelog
FrancescoC-unity Apr 17, 2020
4ccbddb
Merge branch 'HDRP/staging' into HDRP/fix-warning-on-xbox
sebastienlagarde Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed NaN which can appear with real time reflection and inf value
- Fixed an issue that was collapsing the volume components in the HDRP default settings
- Fixed warning about missing bound decal buffer
- Fixed shader warning on Xbox for ResolveStencilBuffer.compute.

### Changed
- Color buffer pyramid is not allocated anymore if neither refraction nor distortion are enabled
Expand Down
5 changes: 4 additions & 1 deletion ...unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ResolveStencilBuffer.compute
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,10 @@ void KERNEL_NAME(uint3 groupId : SV_GroupID,

#else

bool isFirstThread = WaveIsFirstLane();
// Need to workaround a warning incorrectly triggered when on Xbox One, so instead of using WaveIsFirstLane()
// we check the groupThreadId as in the non intrinsic version.
//bool isFirstThread = WaveIsFirstLane();
bool isFirstThread = groupThreadId.x == 0 && groupThreadId.y == 0;
uint coarseStencilValue = WaveActiveBitOr(resolvedStencil);

#endif
Expand Down