Skip to content

Baked GI and shadow filter quality in deferred mode #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

Baked GI and shadow filter quality in deferred mode #145

merged 1 commit into from
Apr 16, 2020

Conversation

JordanL8
Copy link
Contributor

Purpose of this PR

  • Adds info about the Baked GI Node not working in HDRP's Unlit Master Node.
  • Adds clarity on settings shadow filter quality to high in deferred mode.

@sebastienlagarde sebastienlagarde merged commit 2119e84 into master Apr 16, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/docs/corrections-and-additions branch April 16, 2020 10:57
sebastienlagarde pushed a commit that referenced this pull request Apr 16, 2020
@JordanL8 @sebastienlagarde
Added baked GI rp support caveat and made setting shadow filter quali…
9bfbc94 
…ty clearer for deferred high. (#145)
sebastienlagarde added a commit that referenced this pull request Apr 16, 2020
@sebastienlagarde @anisunity
@FrancescoC-unity @skhiat @RSlysz @fabien-unity @EvgeniiG @alelievr @pmavridis @JulienIgnace-Unity @fredericv-unity3d @Chman @JordanL8 @vlad-andreev @ChristianF-ARM @timcannellunity3d @JussiKnuuttila @remi-chapelain @adrien-de-tocqueville @slunity @iTris666
Merge 8.x.x/hd/staging [Skip CI] (#141)
0b856a4 
* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210)

* Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge.

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204)

* Update documentation to mention more explicitely the lack of support  of vertex animation

* Update Ray-Tracing-Getting-Started.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202)

* Make subsection in decal debug menu

* changelog

* Support cookie on light backing for Disc Area Light #6138

* Hdrp /lookdev/fix crash on adding volume as viewed game object #6129

* fixed changelog

* Add smoothness remark (#6226)

* Removed legacy VR code from HDRP #5923

* Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895

* Improve light clipping and culling #2 #4711

* Hdrp/fix/decal material ui errors #6225

* Fix z-fighting in sceneview when scene lighting is off (#6213)

* Do not override the depth state of transparent materials in RenderDebugView

* Changelog

* Changelog - add case number

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Update CHANGELOG.md

* Mention default post processing in default volumes. (#6233)

* Fix cubemap inspector so that thumbnail for cubemap work #6231

* - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fix some typos in the debug menu (#6249)

* Backport renaming

* changelog

* Added debug exposure to light hierarchy debug. (#6216)

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254)

* Clearer naming of tile and cluster categories for environment lights #6227

* Fix texture curve destroy (#6277)

# Conflicts:
#	com.unity.render-pipelines.core/CHANGELOG.md

* Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270)

* fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266)

* Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235

* Add XR setting to control camera jitter for temporal effects #6259

* fix unreachable code in TextureXR.useTexArray (#6260)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Deprecate Utilities namespace #6219

* Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265

* Update CHANGELOG.md

* [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289)

* Fix null texture usage happening on CoreRP upgrade

* Partially fix garbage collected stylesheet issue.

(Need more work on UIElement side, see case 1228706 )

* Update CHANGELOG.md

* Clean log

* [Backport 8.x.x] Hdrp/fix default volume switch (#6336)

* Fixed an issue where default volume would not update when switching profile.

* Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied

* Changelog

* [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339)

* Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335)

* Fixed an issue where Volume inspector might not refresh correctly in some cases.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Hdrp/fix material baked emission #5392

* Fixed volume components lifespan in the clipboard #5869

* Hdrp/fix/particle light shadows #6111

* Bugfix: uncached reflection probe cameras were reseting the debug mode #6245

* Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272

* Hdrp/probe scale 1219246 (#6288)

* Fix when scale down < 0 all direction of box Influence Volume

* Update Change log

* Update CHANGELOG.md

* Split set rendering feature set and API validity check #6301

* Fix Render Texture with XR #6306

* Fix sRGB mismatch with XR SDK #6311

* Fix XR single-pass with Mock HMD plugin #6313

* Fix XR culling with multiple cameras #6314

* Add custom pass opaque rendering error message #6330

* Update Light-Component.md (#6332)

* Update CHANGELOG.md

* Update TextureCurve.cs

* fix merge issue

* Update CHANGELOG.md

* - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410)

* First pass of light loop optimizations (still single threaded) (#6367) (#6424)

* Saving 10% off the PrepareLightForGPU

* 18% decrease in cost with this

* Around 12% cost shaving off GetLightData

* Around 6.5% win here

* Faster View matrix flip

* Missing *=-1

* About 7% win in preprocess light data

* Another small batch

* Small cleanup for first optimization pass

* Tiny bit more cleanup

* Address review points

* Add comment

* changelog
# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Catch and handle NRefactory parser exceptions (#6392)

Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com>

* Avoid negative input to sqrt() (#6397)

- The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value.
- This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21.
- This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`.
- On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact.

* Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394)

* Added known issues page (#6447)

* Platform/playstation #6380

* Shadow cascade tooltip fix (when using the metric mode) #6448

* Focus on Decal uses the extends of the projectors #6449

* [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455)

* - Fixed how the area light influence volume is computed to match rasterization.

* Fix an issue with axis order

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed usage of light size data that are not available at runtime. (#6490)

* Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481)

* Fix shadow tesselation culling (#6477)

* Fix custom pass culling params

* Fixed shadow tessellation culling

* revert custom pass code

* Add option to disable XR rendering on the camera settings #6372

* Move scene view camera settings to camera settings window #6390

* Corrected typo and changed links to .md (#6414)

* Corrected typo and changed links to .md

* Update Master-Node-Fabric.md

* Hdrp /fix reset of HDAdditionalLightData #6453

* Fix null error when leaving debug menu #6467

* Hdrp /fix drag area width at left of light intensity #6471

* Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473

* Fix custom pass depth copy #6484

* Hdrp /lookdev ui fixes #6491

* Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496

* fix unused leftover (#6497)

* Fix custom pass test reference images (#6512)

* [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#27)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* path validation when creating new volume profile (#36)

* Clamp probes compression factor to 0 #19

* [Backport 8.x.x] Fix various leaks in HDRP (#119)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs

* Update changelog

* [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996)  (#115)

* Follow references when unloading unneeded assets

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix MSAA resolve when there is no motion vectors

* Fix issues causing planar probes to be broken with multiple cameras in the scene

* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint.

* Hdrp/fix/custom pass msaa rendering info

* Added disocclusion and ghosting to the glossary (#75)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position

* Fix null reference when processing light probe

* Fix black screen in XR when HDRP package is present but not used

* [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

* Added support for rasterized area light shadows in StackLit + slight refactor

* fix Stacklit.hlsl after merge

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* Vfx/docs/bulk review continued (#78)

* Reviewed Contexts and terminology.

* Began reviewing Events

* Added sticky notes doc and reviewed Events

* Update Contexts.md

* Formatted documentation.

* Update Contexts.md

Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Thomas <Chman@users.noreply.github.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com>
Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com>
Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com>
Co-authored-by: Tim Cannell <timcannell@unity3d.com>
Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Tristan Genevet <tristan@unity3d.com>
sebastienlagarde pushed a commit that referenced this pull request Apr 16, 2020
@JordanL8 @sebastienlagarde
Added baked GI rp support caveat and made setting shadow filter quali…
5b4fce1 
…ty clearer for deferred high. (#145)
sebastienlagarde added a commit that referenced this pull request Apr 16, 2020
@sebastienlagarde @anisunity
@FrancescoC-unity @skhiat @RSlysz @fabien-unity @EvgeniiG @alelievr @pmavridis @JulienIgnace-Unity @fredericv-unity3d @Chman @JordanL8 @vlad-andreev @ChristianF-ARM @timcannellunity3d @JussiKnuuttila @remi-chapelain @adrien-de-tocqueville @slunity @iTris666 @victor-unity
Merge 8.x.x/hd/staging (#153)
2a4aa3f 
* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210)

* Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge.

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204)

* Update documentation to mention more explicitely the lack of support  of vertex animation

* Update Ray-Tracing-Getting-Started.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202)

* Make subsection in decal debug menu

* changelog

* Support cookie on light backing for Disc Area Light #6138

* Hdrp /lookdev/fix crash on adding volume as viewed game object #6129

* fixed changelog

* Add smoothness remark (#6226)

* Removed legacy VR code from HDRP #5923

* Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895

* Improve light clipping and culling #2 #4711

* Hdrp/fix/decal material ui errors #6225

* Fix z-fighting in sceneview when scene lighting is off (#6213)

* Do not override the depth state of transparent materials in RenderDebugView

* Changelog

* Changelog - add case number

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Update CHANGELOG.md

* Mention default post processing in default volumes. (#6233)

* Fix cubemap inspector so that thumbnail for cubemap work #6231

* - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fix some typos in the debug menu (#6249)

* Backport renaming

* changelog

* Added debug exposure to light hierarchy debug. (#6216)

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254)

* Clearer naming of tile and cluster categories for environment lights #6227

* Fix texture curve destroy (#6277)

# Conflicts:
#	com.unity.render-pipelines.core/CHANGELOG.md

* Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270)

* fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266)

* Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235

* Add XR setting to control camera jitter for temporal effects #6259

* fix unreachable code in TextureXR.useTexArray (#6260)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Deprecate Utilities namespace #6219

* Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265

* Update CHANGELOG.md

* [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289)

* Fix null texture usage happening on CoreRP upgrade

* Partially fix garbage collected stylesheet issue.

(Need more work on UIElement side, see case 1228706 )

* Update CHANGELOG.md

* Clean log

* [Backport 8.x.x] Hdrp/fix default volume switch (#6336)

* Fixed an issue where default volume would not update when switching profile.

* Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied

* Changelog

* [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339)

* Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335)

* Fixed an issue where Volume inspector might not refresh correctly in some cases.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Hdrp/fix material baked emission #5392

* Fixed volume components lifespan in the clipboard #5869

* Hdrp/fix/particle light shadows #6111

* Bugfix: uncached reflection probe cameras were reseting the debug mode #6245

* Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272

* Hdrp/probe scale 1219246 (#6288)

* Fix when scale down < 0 all direction of box Influence Volume

* Update Change log

* Update CHANGELOG.md

* Split set rendering feature set and API validity check #6301

* Fix Render Texture with XR #6306

* Fix sRGB mismatch with XR SDK #6311

* Fix XR single-pass with Mock HMD plugin #6313

* Fix XR culling with multiple cameras #6314

* Add custom pass opaque rendering error message #6330

* Update Light-Component.md (#6332)

* Update CHANGELOG.md

* Update TextureCurve.cs

* fix merge issue

* Update CHANGELOG.md

* - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410)

* First pass of light loop optimizations (still single threaded) (#6367) (#6424)

* Saving 10% off the PrepareLightForGPU

* 18% decrease in cost with this

* Around 12% cost shaving off GetLightData

* Around 6.5% win here

* Faster View matrix flip

* Missing *=-1

* About 7% win in preprocess light data

* Another small batch

* Small cleanup for first optimization pass

* Tiny bit more cleanup

* Address review points

* Add comment

* changelog
# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Catch and handle NRefactory parser exceptions (#6392)

Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com>

* Avoid negative input to sqrt() (#6397)

- The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value.
- This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21.
- This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`.
- On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact.

* Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394)

* Added known issues page (#6447)

* Platform/playstation #6380

* Shadow cascade tooltip fix (when using the metric mode) #6448

* Focus on Decal uses the extends of the projectors #6449

* [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455)

* - Fixed how the area light influence volume is computed to match rasterization.

* Fix an issue with axis order

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed usage of light size data that are not available at runtime. (#6490)

* Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481)

* Fix shadow tesselation culling (#6477)

* Fix custom pass culling params

* Fixed shadow tessellation culling

* revert custom pass code

* Add option to disable XR rendering on the camera settings #6372

* Move scene view camera settings to camera settings window #6390

* Corrected typo and changed links to .md (#6414)

* Corrected typo and changed links to .md

* Update Master-Node-Fabric.md

* Hdrp /fix reset of HDAdditionalLightData #6453

* Fix null error when leaving debug menu #6467

* Hdrp /fix drag area width at left of light intensity #6471

* Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473

* Fix custom pass depth copy #6484

* Hdrp /lookdev ui fixes #6491

* Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496

* fix unused leftover (#6497)

* Fix custom pass test reference images (#6512)

* [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#27)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* path validation when creating new volume profile (#36)

* Clamp probes compression factor to 0 #19

* [Backport 8.x.x] Fix various leaks in HDRP (#119)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs

* Update changelog

* [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996)  (#115)

* Follow references when unloading unneeded assets

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix MSAA resolve when there is no motion vectors

* Fix issues causing planar probes to be broken with multiple cameras in the scene

* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint.

* Hdrp/fix/custom pass msaa rendering info

* Added disocclusion and ghosting to the glossary (#75)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position

* Fix null reference when processing light probe

* Fix black screen in XR when HDRP package is present but not used

* [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

* Added support for rasterized area light shadows in StackLit + slight refactor

* fix Stacklit.hlsl after merge

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* Vfx/docs/bulk review continued (#78)

* Reviewed Contexts and terminology.

* Began reviewing Events

* Added sticky notes doc and reviewed Events

* Update Contexts.md

* Formatted documentation.

* Update Contexts.md

Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Fix for white flash happening when changing lighting condition (like teleport)

* Fix issue with metal shader and raytracing

* Fix default volume profile collapse

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Thomas <Chman@users.noreply.github.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com>
Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com>
Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com>
Co-authored-by: Tim Cannell <timcannell@unity3d.com>
Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Tristan Genevet <tristan@unity3d.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Apr 16, 2020
@sebastienlagarde @anisunity
@remi-chapelain @JulienIgnace-Unity @JordanL8 @FrancescoC-unity @adrien-de-tocqueville @slunity @alelievr @RSlysz @pmavridis @fabien-unity @victor-unity
Merge 7.x.x/hd/staging [Skip CI] (#158)
c10b375 
* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping too much

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#28)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Update PostProcessSystem.cs

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* Clamp probes compression factor to 0 (#19)

* path validation when creating new volume profile (#36)

* [Backport 7.x.x] Fix various leaks in HDRP (#120)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs

* Update changelog

* [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128)

* Follow references when unloading unneeded assets

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* d Fix MSAA resolve when there is no motion vectors #1

* Fix issues causing planar probes to be broken with multiple cameras in the scene #4

* Pospow and SG triplanar fix #40

* Hdrp/fix/custom pass msaa rendering info #42

* Added disocclusion and ghosting to the glossary (#75)

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position #121

* Fix null reference when processing light probe #131

* Fix black screen in XR when HDRP package is present but not used #137

* Fix default volume profile collapse #138

* Fix for white flash happening when changing lighting condition (like teleport) #140

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Apr 18, 2020
@sebastienlagarde @anisunity
@FrancescoC-unity @skhiat @RSlysz @fabien-unity @EvgeniiG @alelievr @pmavridis @JulienIgnace-Unity @fredericv-unity3d @Chman @JordanL8 @vlad-andreev @ChristianF-ARM @timcannellunity3d @JussiKnuuttila @remi-chapelain @adrien-de-tocqueville @slunity @iTris666 @victor-unity
Merge 8.x.x/hd/staging (#176)
65e98a8 
* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210)

* Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge.

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204)

* Update documentation to mention more explicitely the lack of support  of vertex animation

* Update Ray-Tracing-Getting-Started.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202)

* Make subsection in decal debug menu

* changelog

* Support cookie on light backing for Disc Area Light #6138

* Hdrp /lookdev/fix crash on adding volume as viewed game object #6129

* fixed changelog

* Add smoothness remark (#6226)

* Removed legacy VR code from HDRP #5923

* Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895

* Improve light clipping and culling #2 #4711

* Hdrp/fix/decal material ui errors #6225

* Fix z-fighting in sceneview when scene lighting is off (#6213)

* Do not override the depth state of transparent materials in RenderDebugView

* Changelog

* Changelog - add case number

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Update CHANGELOG.md

* Mention default post processing in default volumes. (#6233)

* Fix cubemap inspector so that thumbnail for cubemap work #6231

* - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fix some typos in the debug menu (#6249)

* Backport renaming

* changelog

* Added debug exposure to light hierarchy debug. (#6216)

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254)

* Clearer naming of tile and cluster categories for environment lights #6227

* Fix texture curve destroy (#6277)

# Conflicts:
#	com.unity.render-pipelines.core/CHANGELOG.md

* Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270)

* fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266)

* Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235

* Add XR setting to control camera jitter for temporal effects #6259

* fix unreachable code in TextureXR.useTexArray (#6260)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Deprecate Utilities namespace #6219

* Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265

* Update CHANGELOG.md

* [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289)

* Fix null texture usage happening on CoreRP upgrade

* Partially fix garbage collected stylesheet issue.

(Need more work on UIElement side, see case 1228706 )

* Update CHANGELOG.md

* Clean log

* [Backport 8.x.x] Hdrp/fix default volume switch (#6336)

* Fixed an issue where default volume would not update when switching profile.

* Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied

* Changelog

* [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339)

* Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335)

* Fixed an issue where Volume inspector might not refresh correctly in some cases.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Hdrp/fix material baked emission #5392

* Fixed volume components lifespan in the clipboard #5869

* Hdrp/fix/particle light shadows #6111

* Bugfix: uncached reflection probe cameras were reseting the debug mode #6245

* Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272

* Hdrp/probe scale 1219246 (#6288)

* Fix when scale down < 0 all direction of box Influence Volume

* Update Change log

* Update CHANGELOG.md

* Split set rendering feature set and API validity check #6301

* Fix Render Texture with XR #6306

* Fix sRGB mismatch with XR SDK #6311

* Fix XR single-pass with Mock HMD plugin #6313

* Fix XR culling with multiple cameras #6314

* Add custom pass opaque rendering error message #6330

* Update Light-Component.md (#6332)

* Update CHANGELOG.md

* Update TextureCurve.cs

* fix merge issue

* Update CHANGELOG.md

* - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410)

* First pass of light loop optimizations (still single threaded) (#6367) (#6424)

* Saving 10% off the PrepareLightForGPU

* 18% decrease in cost with this

* Around 12% cost shaving off GetLightData

* Around 6.5% win here

* Faster View matrix flip

* Missing *=-1

* About 7% win in preprocess light data

* Another small batch

* Small cleanup for first optimization pass

* Tiny bit more cleanup

* Address review points

* Add comment

* changelog
# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Catch and handle NRefactory parser exceptions (#6392)

Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com>

* Avoid negative input to sqrt() (#6397)

- The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value.
- This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21.
- This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`.
- On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact.

* Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394)

* Added known issues page (#6447)

* Platform/playstation #6380

* Shadow cascade tooltip fix (when using the metric mode) #6448

* Focus on Decal uses the extends of the projectors #6449

* [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455)

* - Fixed how the area light influence volume is computed to match rasterization.

* Fix an issue with axis order

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed usage of light size data that are not available at runtime. (#6490)

* Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481)

* Fix shadow tesselation culling (#6477)

* Fix custom pass culling params

* Fixed shadow tessellation culling

* revert custom pass code

* Add option to disable XR rendering on the camera settings #6372

* Move scene view camera settings to camera settings window #6390

* Corrected typo and changed links to .md (#6414)

* Corrected typo and changed links to .md

* Update Master-Node-Fabric.md

* Hdrp /fix reset of HDAdditionalLightData #6453

* Fix null error when leaving debug menu #6467

* Hdrp /fix drag area width at left of light intensity #6471

* Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473

* Fix custom pass depth copy #6484

* Hdrp /lookdev ui fixes #6491

* Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496

* fix unused leftover (#6497)

* Fix custom pass test reference images (#6512)

* [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#27)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* path validation when creating new volume profile (#36)

* Clamp probes compression factor to 0 #19

* [Backport 8.x.x] Fix various leaks in HDRP (#119)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs

* Update changelog

* [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996)  (#115)

* Follow references when unloading unneeded assets

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix MSAA resolve when there is no motion vectors

* Fix issues causing planar probes to be broken with multiple cameras in the scene

* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint.

* Hdrp/fix/custom pass msaa rendering info

* Added disocclusion and ghosting to the glossary (#75)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position

* Fix null reference when processing light probe

* Fix black screen in XR when HDRP package is present but not used

* [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

* Added support for rasterized area light shadows in StackLit + slight refactor

* fix Stacklit.hlsl after merge

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* Vfx/docs/bulk review continued (#78)

* Reviewed Contexts and terminology.

* Began reviewing Events

* Added sticky notes doc and reviewed Events

* Update Contexts.md

* Formatted documentation.

* Update Contexts.md

Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Fix for white flash happening when changing lighting condition (like teleport)

* Fix issue with metal shader and raytracing

* Fix default volume profile collapse

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

* Enable Light Baking Cookies by default + Warning #79

* Fix compil issue with Enable BakeCookie

* Enable Light Baking Cookies by default + Warning - part 3 #79

* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Thomas <Chman@users.noreply.github.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com>
Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com>
Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com>
Co-authored-by: Tim Cannell <timcannell@unity3d.com>
Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Tristan Genevet <tristan@unity3d.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Apr 22, 2020
@sebastienlagarde @anisunity
@FrancescoC-unity @skhiat @RSlysz @fabien-unity @EvgeniiG @alelievr @pmavridis @JulienIgnace-Unity @fredericv-unity3d @Chman @JordanL8 @vlad-andreev @ChristianF-ARM @timcannellunity3d @JussiKnuuttila @remi-chapelain @adrien-de-tocqueville @slunity @iTris666 @victor-unity
merge 8.x.x/hd/staging (#223)
b0352a1 
* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210)

* Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge.

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204)

* Update documentation to mention more explicitely the lack of support  of vertex animation

* Update Ray-Tracing-Getting-Started.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202)

* Make subsection in decal debug menu

* changelog

* Support cookie on light backing for Disc Area Light #6138

* Hdrp /lookdev/fix crash on adding volume as viewed game object #6129

* fixed changelog

* Add smoothness remark (#6226)

* Removed legacy VR code from HDRP #5923

* Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895

* Improve light clipping and culling #2 #4711

* Hdrp/fix/decal material ui errors #6225

* Fix z-fighting in sceneview when scene lighting is off (#6213)

* Do not override the depth state of transparent materials in RenderDebugView

* Changelog

* Changelog - add case number

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Update CHANGELOG.md

* Mention default post processing in default volumes. (#6233)

* Fix cubemap inspector so that thumbnail for cubemap work #6231

* - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fix some typos in the debug menu (#6249)

* Backport renaming

* changelog

* Added debug exposure to light hierarchy debug. (#6216)

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254)

* Clearer naming of tile and cluster categories for environment lights #6227

* Fix texture curve destroy (#6277)

# Conflicts:
#	com.unity.render-pipelines.core/CHANGELOG.md

* Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270)

* fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266)

* Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235

* Add XR setting to control camera jitter for temporal effects #6259

* fix unreachable code in TextureXR.useTexArray (#6260)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Deprecate Utilities namespace #6219

* Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265

* Update CHANGELOG.md

* [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289)

* Fix null texture usage happening on CoreRP upgrade

* Partially fix garbage collected stylesheet issue.

(Need more work on UIElement side, see case 1228706 )

* Update CHANGELOG.md

* Clean log

* [Backport 8.x.x] Hdrp/fix default volume switch (#6336)

* Fixed an issue where default volume would not update when switching profile.

* Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied

* Changelog

* [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339)

* Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335)

* Fixed an issue where Volume inspector might not refresh correctly in some cases.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Hdrp/fix material baked emission #5392

* Fixed volume components lifespan in the clipboard #5869

* Hdrp/fix/particle light shadows #6111

* Bugfix: uncached reflection probe cameras were reseting the debug mode #6245

* Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272

* Hdrp/probe scale 1219246 (#6288)

* Fix when scale down < 0 all direction of box Influence Volume

* Update Change log

* Update CHANGELOG.md

* Split set rendering feature set and API validity check #6301

* Fix Render Texture with XR #6306

* Fix sRGB mismatch with XR SDK #6311

* Fix XR single-pass with Mock HMD plugin #6313

* Fix XR culling with multiple cameras #6314

* Add custom pass opaque rendering error message #6330

* Update Light-Component.md (#6332)

* Update CHANGELOG.md

* Update TextureCurve.cs

* fix merge issue

* Update CHANGELOG.md

* - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410)

* First pass of light loop optimizations (still single threaded) (#6367) (#6424)

* Saving 10% off the PrepareLightForGPU

* 18% decrease in cost with this

* Around 12% cost shaving off GetLightData

* Around 6.5% win here

* Faster View matrix flip

* Missing *=-1

* About 7% win in preprocess light data

* Another small batch

* Small cleanup for first optimization pass

* Tiny bit more cleanup

* Address review points

* Add comment

* changelog
# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Catch and handle NRefactory parser exceptions (#6392)

Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com>

* Avoid negative input to sqrt() (#6397)

- The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value.
- This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21.
- This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`.
- On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact.

* Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394)

* Added known issues page (#6447)

* Platform/playstation #6380

* Shadow cascade tooltip fix (when using the metric mode) #6448

* Focus on Decal uses the extends of the projectors #6449

* [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455)

* - Fixed how the area light influence volume is computed to match rasterization.

* Fix an issue with axis order

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed usage of light size data that are not available at runtime. (#6490)

* Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481)

* Fix shadow tesselation culling (#6477)

* Fix custom pass culling params

* Fixed shadow tessellation culling

* revert custom pass code

* Add option to disable XR rendering on the camera settings #6372

* Move scene view camera settings to camera settings window #6390

* Corrected typo and changed links to .md (#6414)

* Corrected typo and changed links to .md

* Update Master-Node-Fabric.md

* Hdrp /fix reset of HDAdditionalLightData #6453

* Fix null error when leaving debug menu #6467

* Hdrp /fix drag area width at left of light intensity #6471

* Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473

* Fix custom pass depth copy #6484

* Hdrp /lookdev ui fixes #6491

* Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496

* fix unused leftover (#6497)

* Fix custom pass test reference images (#6512)

* [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#27)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* path validation when creating new volume profile (#36)

* Clamp probes compression factor to 0 #19

* [Backport 8.x.x] Fix various leaks in HDRP (#119)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs

* Update changelog

* [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996)  (#115)

* Follow references when unloading unneeded assets

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix MSAA resolve when there is no motion vectors

* Fix issues causing planar probes to be broken with multiple cameras in the scene

* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint.

* Hdrp/fix/custom pass msaa rendering info

* Added disocclusion and ghosting to the glossary (#75)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position

* Fix null reference when processing light probe

* Fix black screen in XR when HDRP package is present but not used

* [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

* Added support for rasterized area light shadows in StackLit + slight refactor

* fix Stacklit.hlsl after merge

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* Vfx/docs/bulk review continued (#78)

* Reviewed Contexts and terminology.

* Began reviewing Events

* Added sticky notes doc and reviewed Events

* Update Contexts.md

* Formatted documentation.

* Update Contexts.md

Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Fix for white flash happening when changing lighting condition (like teleport)

* Fix issue with metal shader and raytracing

* Fix default volume profile collapse

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

* Enable Light Baking Cookies by default + Warning #79

* Fix compil issue with Enable BakeCookie

* Enable Light Baking Cookies by default + Warning - part 3 #79

* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)

* [Backport 8.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#180)

* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.

* Update changelog

* Add range attenuation to box-shaped spotlights [Skip CI] #101

* Contact shadow min distance + fix scalarization code #150

* Hdrp/combine material samples with shader samples [Skip CI] #117

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Thomas <Chman@users.noreply.github.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com>
Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com>
Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com>
Co-authored-by: Tim Cannell <timcannell@unity3d.com>
Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Tristan Genevet <tristan@unity3d.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Apr 24, 2020
@sebastienlagarde @anisunity
@remi-chapelain @JulienIgnace-Unity @JordanL8 @FrancescoC-unity @adrien-de-tocqueville @slunity @alelievr @RSlysz @pmavridis @fabien-unity @victor-unity
[7.x.x] Merge 7.x.x/hd/staging (#248)
b4795fb 
* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping too much

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#28)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Update PostProcessSystem.cs

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* Clamp probes compression factor to 0 (#19)

* path validation when creating new volume profile (#36)

* [Backport 7.x.x] Fix various leaks in HDRP (#120)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs

* Update changelog

* [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128)

* Follow references when unloading unneeded assets

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* d Fix MSAA resolve when there is no motion vectors #1

* Fix issues causing planar probes to be broken with multiple cameras in the scene #4

* Pospow and SG triplanar fix #40

* Hdrp/fix/custom pass msaa rendering info #42

* Added disocclusion and ghosting to the glossary (#75)

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position #121

* Fix null reference when processing light probe #131

* Fix black screen in XR when HDRP package is present but not used #137

* Fix default volume profile collapse #138

* Fix for white flash happening when changing lighting condition (like teleport) #140

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

* [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179)

* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs

* Update changelog

* Catch and handle NRefactory parser exceptions #6392

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
sebastienlagarde added a commit that referenced this pull request May 15, 2020
@sebastienlagarde @anisunity
@remi-chapelain @JulienIgnace-Unity @JordanL8 @FrancescoC-unity @adrien-de-tocqueville @slunity @alelievr @RSlysz @pmavridis @fabien-unity @victor-unity @fredericv-unity3d @aras-p @eturquin @skhiat
[7.x.x] Merge 7.x.x/hd/staging [Skip CI] (#492)
e0a423b 
* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping too much

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#28)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Update PostProcessSystem.cs

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* Clamp probes compression factor to 0 (#19)

* path validation when creating new volume profile (#36)

* [Backport 7.x.x] Fix various leaks in HDRP (#120)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs

* Update changelog

* [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128)

* Follow references when unloading unneeded assets

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* d Fix MSAA resolve when there is no motion vectors #1

* Fix issues causing planar probes to be broken with multiple cameras in the scene #4

* Pospow and SG triplanar fix #40

* Hdrp/fix/custom pass msaa rendering info #42

* Added disocclusion and ghosting to the glossary (#75)

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position #121

* Fix null reference when processing light probe #131

* Fix black screen in XR when HDRP package is present but not used #137

* Fix default volume profile collapse #138

* Fix for white flash happening when changing lighting condition (like teleport) #140

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

* [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179)

* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs

* Update changelog

* Catch and handle NRefactory parser exceptions #6392

* [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123)

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update CHANGELOG.md

* fix typo

* fix typo 2

* Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284)

* [7.x.x Backport] Fix pre/post pass sg properties #82 (#85)

* Fix depth pre/post passes not correctly enabled when switching shaders on the material

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs
#	com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs
#	com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs

* Hide prepass and postpass in the material UI

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed a performance issue with stochastic ray traced area shadows. (#306)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Updated raytracing async compute warning. (#304)

* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303)

* Fixed a null ref exception in static sky when the default volume profile is invalid.

* Update changelog

* [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307)

* Fixed an error about procedural sky being logged by mistake.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379)

* Fixed flickering of the game/scene view when lookdev is running.

* Update changelog

* [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317)

* render until ambient probe is ready

* remove comment

* changelog

* [Backport 7.x.x] Fixed some gcalloc in the debug window (#464)

* Fixed some GCAlloc in the debug window

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs

* Update changelog

* [Backport 7.x.x] Hdrp/small ui update (#466)

* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs
#	com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs

* update changelog

* [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482)

* PBR Sky renderer now shares its internal precomputation table between different instances.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs

* Doc update

* Update changelog

* [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480)

* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs

* Update changelog

* [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479)

* Fixed an issue where asset preview could be rendered white because of static lighting sky.

Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs

* Update changelog

* Changed UI name, tooltip, and doc for maximum decals on screen (#232)

Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/

* Update Custom-Post-Process.md (#233)

* Update HDRP-Features.md (#235)

* Hdrp/reflection probe scale perf #252

* HD: Switch to 1920x1080 default standalone resolution (#279)

Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res

(moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo)

* Makes sure quaternion is normalized and valid before converting to ma… #331

* Fix cookie srgb #297

* Updated forward and deferred rendering definitions (#350)

* Update Forward-And-Deferred-Rendering.md

* Update Forward-And-Deferred-Rendering.md

* Update Light-Component.md (#357)

* Hd/add layer modification on generated emissive mesh for area light #364

* Update Look-Dev-Environment-Library.md (#365)

* Update Volumetric-Lighting.md (#402)

Fixes https://fogbugz.unity3d.com/f/cases/1238592

* Hd/fix nullref while removing decal component #416

* Fix issue with Uber Post process shader when alpha is enabled #422

* Fix the bug (#430)

* Fix issue causing not all baked reflection probes to be deleted #441

* Updated Decal Projector doc (#477)

Updated Limitations section and added a disclaimer about decal shader stripping.

* Look Dev docs refactor 2 #484

* [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425)

* Saturate vertex color to avoid negative values.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix Motion Vectors written by transparent when rendering with MSAA #315

* Fix issue with the resolve of motion vectors (#421)

* fix issue with ShowPrePassAndPostPass

* fix compilation issue in rendergraph

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Aras Pranckevičius <aras@unity3d.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
sebastienlagarde added a commit that referenced this pull request May 15, 2020
@sebastienlagarde @anisunity
@remi-chapelain @JulienIgnace-Unity @JordanL8 @FrancescoC-unity @adrien-de-tocqueville @slunity @alelievr @RSlysz @pmavridis @fabien-unity @victor-unity @fredericv-unity3d @aras-p @eturquin @skhiat
[7.x.x] Merge 7.x.x/hd/staging (#512)
2e579c5 
* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping too much

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#28)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Update PostProcessSystem.cs

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* Clamp probes compression factor to 0 (#19)

* path validation when creating new volume profile (#36)

* [Backport 7.x.x] Fix various leaks in HDRP (#120)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs

* Update changelog

* [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128)

* Follow references when unloading unneeded assets

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* d Fix MSAA resolve when there is no motion vectors #1

* Fix issues causing planar probes to be broken with multiple cameras in the scene #4

* Pospow and SG triplanar fix #40

* Hdrp/fix/custom pass msaa rendering info #42

* Added disocclusion and ghosting to the glossary (#75)

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position #121

* Fix null reference when processing light probe #131

* Fix black screen in XR when HDRP package is present but not used #137

* Fix default volume profile collapse #138

* Fix for white flash happening when changing lighting condition (like teleport) #140

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

* [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179)

* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs

* Update changelog

* Catch and handle NRefactory parser exceptions #6392

* [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123)

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update CHANGELOG.md

* fix typo

* fix typo 2

* Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284)

* [7.x.x Backport] Fix pre/post pass sg properties #82 (#85)

* Fix depth pre/post passes not correctly enabled when switching shaders on the material

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs
#	com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs
#	com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs

* Hide prepass and postpass in the material UI

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed a performance issue with stochastic ray traced area shadows. (#306)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Updated raytracing async compute warning. (#304)

* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303)

* Fixed a null ref exception in static sky when the default volume profile is invalid.

* Update changelog

* [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307)

* Fixed an error about procedural sky being logged by mistake.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379)

* Fixed flickering of the game/scene view when lookdev is running.

* Update changelog

* [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317)

* render until ambient probe is ready

* remove comment

* changelog

* [Backport 7.x.x] Fixed some gcalloc in the debug window (#464)

* Fixed some GCAlloc in the debug window

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs

* Update changelog

* [Backport 7.x.x] Hdrp/small ui update (#466)

* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs
#	com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs

* update changelog

* [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482)

* PBR Sky renderer now shares its internal precomputation table between different instances.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs

* Doc update

* Update changelog

* [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480)

* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs

* Update changelog

* [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479)

* Fixed an issue where asset preview could be rendered white because of static lighting sky.

Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs

* Update changelog

* Changed UI name, tooltip, and doc for maximum decals on screen (#232)

Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/

* Update Custom-Post-Process.md (#233)

* Update HDRP-Features.md (#235)

* Hdrp/reflection probe scale perf #252

* HD: Switch to 1920x1080 default standalone resolution (#279)

Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res

(moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo)

* Makes sure quaternion is normalized and valid before converting to ma… #331

* Fix cookie srgb #297

* Updated forward and deferred rendering definitions (#350)

* Update Forward-And-Deferred-Rendering.md

* Update Forward-And-Deferred-Rendering.md

* Update Light-Component.md (#357)

* Hd/add layer modification on generated emissive mesh for area light #364

* Update Look-Dev-Environment-Library.md (#365)

* Update Volumetric-Lighting.md (#402)

Fixes https://fogbugz.unity3d.com/f/cases/1238592

* Hd/fix nullref while removing decal component #416

* Fix issue with Uber Post process shader when alpha is enabled #422

* Fix the bug (#430)

* Fix issue causing not all baked reflection probes to be deleted #441

* Updated Decal Projector doc (#477)

Updated Limitations section and added a disclaimer about decal shader stripping.

* Look Dev docs refactor 2 #484

* [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425)

* Saturate vertex color to avoid negative values.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix Motion Vectors written by transparent when rendering with MSAA #315

* Fix issue with the resolve of motion vectors (#421)

* fix issue with ShowPrePassAndPostPass

* fix compilation issue in rendergraph

* Fixed null reference exception in LookDev when setting the SRP to None #447

* Check reflection probe null pointer before use. (case 1244047) #456

* Remove max atlas probe alloc size in HDRP asset (#458)

* Fixed max alloc planar size not taking in account the max cache size

* Removed the max cache clamp on texture atlases

* Fix few multi-editing issues with Emission UI #473

* Re-enable cubemap thumbnail gen only for d3d11 #487

* Hd/fix undo environmentlibrary lookdev #490

* Added system requirements and frame settings api docs (#510)

* Added system requirements and frame settings api doc

* Update System-Requirements.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Aras Pranckevičius <aras@unity3d.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
sebastienlagarde added a commit that referenced this pull request May 19, 2020
@sebastienlagarde @anisunity
@remi-chapelain @JulienIgnace-Unity @JordanL8 @FrancescoC-unity @adrien-de-tocqueville @slunity @alelievr @RSlysz @pmavridis @fabien-unity @victor-unity @fredericv-unity3d @aras-p @eturquin @skhiat
Merge 7.x.x/hd/staging [Skip CI] (#537)
4f50ded 
* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping too much

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#28)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Update PostProcessSystem.cs

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* Clamp probes compression factor to 0 (#19)

* path validation when creating new volume profile (#36)

* [Backport 7.x.x] Fix various leaks in HDRP (#120)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs

* Update changelog

* [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128)

* Follow references when unloading unneeded assets

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* d Fix MSAA resolve when there is no motion vectors #1

* Fix issues causing planar probes to be broken with multiple cameras in the scene #4

* Pospow and SG triplanar fix #40

* Hdrp/fix/custom pass msaa rendering info #42

* Added disocclusion and ghosting to the glossary (#75)

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position #121

* Fix null reference when processing light probe #131

* Fix black screen in XR when HDRP package is present but not used #137

* Fix default volume profile collapse #138

* Fix for white flash happening when changing lighting condition (like teleport) #140

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

* [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179)

* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs

* Update changelog

* Catch and handle NRefactory parser exceptions #6392

* [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123)

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update CHANGELOG.md

* fix typo

* fix typo 2

* Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284)

* [7.x.x Backport] Fix pre/post pass sg properties #82 (#85)

* Fix depth pre/post passes not correctly enabled when switching shaders on the material

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs
#	com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs
#	com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs

* Hide prepass and postpass in the material UI

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed a performance issue with stochastic ray traced area shadows. (#306)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Updated raytracing async compute warning. (#304)

* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303)

* Fixed a null ref exception in static sky when the default volume profile is invalid.

* Update changelog

* [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307)

* Fixed an error about procedural sky being logged by mistake.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379)

* Fixed flickering of the game/scene view when lookdev is running.

* Update changelog

* [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317)

* render until ambient probe is ready

* remove comment

* changelog

* [Backport 7.x.x] Fixed some gcalloc in the debug window (#464)

* Fixed some GCAlloc in the debug window

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs

* Update changelog

* [Backport 7.x.x] Hdrp/small ui update (#466)

* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs
#	com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs

* update changelog

* [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482)

* PBR Sky renderer now shares its internal precomputation table between different instances.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs

* Doc update

* Update changelog

* [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480)

* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs

* Update changelog

* [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479)

* Fixed an issue where asset preview could be rendered white because of static lighting sky.

Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs

* Update changelog

* Changed UI name, tooltip, and doc for maximum decals on screen (#232)

Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/

* Update Custom-Post-Process.md (#233)

* Update HDRP-Features.md (#235)

* Hdrp/reflection probe scale perf #252

* HD: Switch to 1920x1080 default standalone resolution (#279)

Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res

(moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo)

* Makes sure quaternion is normalized and valid before converting to ma… #331

* Fix cookie srgb #297

* Updated forward and deferred rendering definitions (#350)

* Update Forward-And-Deferred-Rendering.md

* Update Forward-And-Deferred-Rendering.md

* Update Light-Component.md (#357)

* Hd/add layer modification on generated emissive mesh for area light #364

* Update Look-Dev-Environment-Library.md (#365)

* Update Volumetric-Lighting.md (#402)

Fixes https://fogbugz.unity3d.com/f/cases/1238592

* Hd/fix nullref while removing decal component #416

* Fix issue with Uber Post process shader when alpha is enabled #422

* Fix the bug (#430)

* Fix issue causing not all baked reflection probes to be deleted #441

* Updated Decal Projector doc (#477)

Updated Limitations section and added a disclaimer about decal shader stripping.

* Look Dev docs refactor 2 #484

* [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425)

* Saturate vertex color to avoid negative values.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix Motion Vectors written by transparent when rendering with MSAA #315

* Fix issue with the resolve of motion vectors (#421)

* fix issue with ShowPrePassAndPostPass

* fix compilation issue in rendergraph

* Fixed null reference exception in LookDev when setting the SRP to None #447

* Check reflection probe null pointer before use. (case 1244047) #456

* Remove max atlas probe alloc size in HDRP asset (#458)

* Fixed max alloc planar size not taking in account the max cache size

* Removed the max cache clamp on texture atlases

* Fix few multi-editing issues with Emission UI #473

* Re-enable cubemap thumbnail gen only for d3d11 #487

* Hd/fix undo environmentlibrary lookdev #490

* Added system requirements and frame settings api docs (#510)

* Added system requirements and frame settings api doc

* Update System-Requirements.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* hide exposure compensation for fixed exposure (#535)

* hide exposure compensation for fixed exposure

* Update PostProcessSystem.cs

* [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522

* Use path relative to package for depth of field #523

* Fix taaFrameIndex and restore TAA tests for XR #534

* Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538)

* fix DXR manifest

* update reference screenshots

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Aras Pranckevičius <aras@unity3d.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
sebastienlagarde added a commit that referenced this pull request May 19, 2020
@sebastienlagarde @anisunity
@remi-chapelain @JulienIgnace-Unity @JordanL8 @FrancescoC-unity @adrien-de-tocqueville @slunity @alelievr @RSlysz @pmavridis @fabien-unity @victor-unity @fredericv-unity3d @aras-p @eturquin @skhiat
[7.x.x] Merge 7.x.x/hd/staging [Skip CI] (#551)
bb8efed 
* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping too much

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#28)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Update PostProcessSystem.cs

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* Clamp probes compression factor to 0 (#19)

* path validation when creating new volume profile (#36)

* [Backport 7.x.x] Fix various leaks in HDRP (#120)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs

* Update changelog

* [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128)

* Follow references when unloading unneeded assets

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* d Fix MSAA resolve when there is no motion vectors #1

* Fix issues causing planar probes to be broken with multiple cameras in the scene #4

* Pospow and SG triplanar fix #40

* Hdrp/fix/custom pass msaa rendering info #42

* Added disocclusion and ghosting to the glossary (#75)

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position #121

* Fix null reference when processing light probe #131

* Fix black screen in XR when HDRP package is present but not used #137

* Fix default volume profile collapse #138

* Fix for white flash happening when changing lighting condition (like teleport) #140

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

* [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179)

* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs

* Update changelog

* Catch and handle NRefactory parser exceptions #6392

* [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123)

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update CHANGELOG.md

* fix typo

* fix typo 2

* Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284)

* [7.x.x Backport] Fix pre/post pass sg properties #82 (#85)

* Fix depth pre/post passes not correctly enabled when switching shaders on the material

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs
#	com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs
#	com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs

* Hide prepass and postpass in the material UI

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed a performance issue with stochastic ray traced area shadows. (#306)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Updated raytracing async compute warning. (#304)

* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303)

* Fixed a null ref exception in static sky when the default volume profile is invalid.

* Update changelog

* [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307)

* Fixed an error about procedural sky being logged by mistake.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379)

* Fixed flickering of the game/scene view when lookdev is running.

* Update changelog

* [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317)

* render until ambient probe is ready

* remove comment

* changelog

* [Backport 7.x.x] Fixed some gcalloc in the debug window (#464)

* Fixed some GCAlloc in the debug window

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs

* Update changelog

* [Backport 7.x.x] Hdrp/small ui update (#466)

* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs
#	com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs

* update changelog

* [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482)

* PBR Sky renderer now shares its internal precomputation table between different instances.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs

* Doc update

* Update changelog

* [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480)

* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs

* Update changelog

* [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479)

* Fixed an issue where asset preview could be rendered white because of static lighting sky.

Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs

* Update changelog

* Changed UI name, tooltip, and doc for maximum decals on screen (#232)

Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/

* Update Custom-Post-Process.md (#233)

* Update HDRP-Features.md (#235)

* Hdrp/reflection probe scale perf #252

* HD: Switch to 1920x1080 default standalone resolution (#279)

Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res

(moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo)

* Makes sure quaternion is normalized and valid before converting to ma… #331

* Fix cookie srgb #297

* Updated forward and deferred rendering definitions (#350)

* Update Forward-And-Deferred-Rendering.md

* Update Forward-And-Deferred-Rendering.md

* Update Light-Component.md (#357)

* Hd/add layer modification on generated emissive mesh for area light #364

* Update Look-Dev-Environment-Library.md (#365)

* Update Volumetric-Lighting.md (#402)

Fixes https://fogbugz.unity3d.com/f/cases/1238592

* Hd/fix nullref while removing decal component #416

* Fix issue with Uber Post process shader when alpha is enabled #422

* Fix the bug (#430)

* Fix issue causing not all baked reflection probes to be deleted #441

* Updated Decal Projector doc (#477)

Updated Limitations section and added a disclaimer about decal shader stripping.

* Look Dev docs refactor 2 #484

* [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425)

* Saturate vertex color to avoid negative values.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix Motion Vectors written by transparent when rendering with MSAA #315

* Fix issue with the resolve of motion vectors (#421)

* fix issue with ShowPrePassAndPostPass

* fix compilation issue in rendergraph

* Fixed null reference exception in LookDev when setting the SRP to None #447

* Check reflection probe null pointer before use. (case 1244047) #456

* Remove max atlas probe alloc size in HDRP asset (#458)

* Fixed max alloc planar size not taking in account the max cache size

* Removed the max cache clamp on texture atlases

* Fix few multi-editing issues with Emission UI #473

* Re-enable cubemap thumbnail gen only for d3d11 #487

* Hd/fix undo environmentlibrary lookdev #490

* Added system requirements and frame settings api docs (#510)

* Added system requirements and frame settings api doc

* Update System-Requirements.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* hide exposure compensation for fixed exposure (#535)

* hide exposure compensation for fixed exposure

* Update PostProcessSystem.cs

* [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522

* Use path relative to package for depth of field #523

* Fix taaFrameIndex and restore TAA tests for XR #534

* Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538)

* fix DXR manifest

* update reference screenshots

* Clone in the Asset folder when the original volume profile is in a re… #508

* Add support for batchmode (#542)

* Update Reflection-Probes-Intro.md (#548)

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Aras Pranckevičius <aras@unity3d.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
sebastienlagarde added a commit that referenced this pull request May 23, 2020
@sebastienlagarde @anisunity
@remi-chapelain @JulienIgnace-Unity @JordanL8 @FrancescoC-unity @adrien-de-tocqueville @slunity @alelievr @RSlysz @pmavridis @fabien-unity @victor-unity @fredericv-unity3d @aras-p @eturquin @skhiat
[7.x.x] Merge 7.x.x/hd/staging (#581)
3b44398 
* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping too much

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#28)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Update PostProcessSystem.cs

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* Clamp probes compression factor to 0 (#19)

* path validation when creating new volume profile (#36)

* [Backport 7.x.x] Fix various leaks in HDRP (#120)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs

* Update changelog

* [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128)

* Follow references when unloading unneeded assets

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* d Fix MSAA resolve when there is no motion vectors #1

* Fix issues causing planar probes to be broken with multiple cameras in the scene #4

* Pospow and SG triplanar fix #40

* Hdrp/fix/custom pass msaa rendering info #42

* Added disocclusion and ghosting to the glossary (#75)

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position #121

* Fix null reference when processing light probe #131

* Fix black screen in XR when HDRP package is present but not used #137

* Fix default volume profile collapse #138

* Fix for white flash happening when changing lighting condition (like teleport) #140

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

* [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179)

* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs

* Update changelog

* Catch and handle NRefactory parser exceptions #6392

* [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123)

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update CHANGELOG.md

* fix typo

* fix typo 2

* Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284)

* [7.x.x Backport] Fix pre/post pass sg properties #82 (#85)

* Fix depth pre/post passes not correctly enabled when switching shaders on the material

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs
#	com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs
#	com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs

* Hide prepass and postpass in the material UI

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed a performance issue with stochastic ray traced area shadows. (#306)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Updated raytracing async compute warning. (#304)

* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303)

* Fixed a null ref exception in static sky when the default volume profile is invalid.

* Update changelog

* [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307)

* Fixed an error about procedural sky being logged by mistake.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379)

* Fixed flickering of the game/scene view when lookdev is running.

* Update changelog

* [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317)

* render until ambient probe is ready

* remove comment

* changelog

* [Backport 7.x.x] Fixed some gcalloc in the debug window (#464)

* Fixed some GCAlloc in the debug window

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs

* Update changelog

* [Backport 7.x.x] Hdrp/small ui update (#466)

* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs
#	com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs

* update changelog

* [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482)

* PBR Sky renderer now shares its internal precomputation table between different instances.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs

* Doc update

* Update changelog

* [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480)

* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs

* Update changelog

* [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479)

* Fixed an issue where asset preview could be rendered white because of static lighting sky.

Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs

* Update changelog

* Changed UI name, tooltip, and doc for maximum decals on screen (#232)

Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/

* Update Custom-Post-Process.md (#233)

* Update HDRP-Features.md (#235)

* Hdrp/reflection probe scale perf #252

* HD: Switch to 1920x1080 default standalone resolution (#279)

Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res

(moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo)

* Makes sure quaternion is normalized and valid before converting to ma… #331

* Fix cookie srgb #297

* Updated forward and deferred rendering definitions (#350)

* Update Forward-And-Deferred-Rendering.md

* Update Forward-And-Deferred-Rendering.md

* Update Light-Component.md (#357)

* Hd/add layer modification on generated emissive mesh for area light #364

* Update Look-Dev-Environment-Library.md (#365)

* Update Volumetric-Lighting.md (#402)

Fixes https://fogbugz.unity3d.com/f/cases/1238592

* Hd/fix nullref while removing decal component #416

* Fix issue with Uber Post process shader when alpha is enabled #422

* Fix the bug (#430)

* Fix issue causing not all baked reflection probes to be deleted #441

* Updated Decal Projector doc (#477)

Updated Limitations section and added a disclaimer about decal shader stripping.

* Look Dev docs refactor 2 #484

* [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425)

* Saturate vertex color to avoid negative values.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix Motion Vectors written by transparent when rendering with MSAA #315

* Fix issue with the resolve of motion vectors (#421)

* fix issue with ShowPrePassAndPostPass

* fix compilation issue in rendergraph

* Fixed null reference exception in LookDev when setting the SRP to None #447

* Check reflection probe null pointer before use. (case 1244047) #456

* Remove max atlas probe alloc size in HDRP asset (#458)

* Fixed max alloc planar size not taking in account the max cache size

* Removed the max cache clamp on texture atlases

* Fix few multi-editing issues with Emission UI #473

* Re-enable cubemap thumbnail gen only for d3d11 #487

* Hd/fix undo environmentlibrary lookdev #490

* Added system requirements and frame settings api docs (#510)

* Added system requirements and frame settings api doc

* Update System-Requirements.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* hide exposure compensation for fixed exposure (#535)

* hide exposure compensation for fixed exposure

* Update PostProcessSystem.cs

* [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522

* Use path relative to package for depth of field #523

* Fix taaFrameIndex and restore TAA tests for XR #534

* Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538)

* fix DXR manifest

* update reference screenshots

* Clone in the Asset folder when the original volume profile is in a re… #508

* Add support for batchmode (#542)

* Update Reflection-Probes-Intro.md (#548)

* Added note on decal emission on transparent surfaces (#567)

* Update Decal-Projector.md

* Update Decal-Projector.md

* Update Decal-Projector.md

* Added terrain lit doc (#573)

* Add terrain lit doc

* Update HDRP-Features.md

* Update HDRP-Features.md

* Hd/fix wizard defaultvolumeprofile creation #565

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Aras Pranckevičius <aras@unity3d.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
sebastienlagarde added a commit that referenced this pull request May 26, 2020
@sebastienlagarde @anisunity
@remi-chapelain @JulienIgnace-Unity @JordanL8 @FrancescoC-unity @adrien-de-tocqueville @slunity @alelievr @RSlysz @pmavridis @fabien-unity @victor-unity @fredericv-unity3d @aras-p @eturquin @skhiat
[7.x.x] Merge 7.x.x/hd/staging (#620)
0e07758 
* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping too much

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#28)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Update PostProcessSystem.cs

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* Clamp probes compression factor to 0 (#19)

* path validation when creating new volume profile (#36)

* [Backport 7.x.x] Fix various leaks in HDRP (#120)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs

* Update changelog

* [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128)

* Follow references when unloading unneeded assets

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* d Fix MSAA resolve when there is no motion vectors #1

* Fix issues causing planar probes to be broken with multiple cameras in the scene #4

* Pospow and SG triplanar fix #40

* Hdrp/fix/custom pass msaa rendering info #42

* Added disocclusion and ghosting to the glossary (#75)

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position #121

* Fix null reference when processing light probe #131

* Fix black screen in XR when HDRP package is present but not used #137

* Fix default volume profile collapse #138

* Fix for white flash happening when changing lighting condition (like teleport) #140

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

* [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179)

* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs

* Update changelog

* Catch and handle NRefactory parser exceptions #6392

* [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123)

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update CHANGELOG.md

* fix typo

* fix typo 2

* Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284)

* [7.x.x Backport] Fix pre/post pass sg properties #82 (#85)

* Fix depth pre/post passes not correctly enabled when switching shaders on the material

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs
#	com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs
#	com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs

* Hide prepass and postpass in the material UI

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed a performance issue with stochastic ray traced area shadows. (#306)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Updated raytracing async compute warning. (#304)

* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303)

* Fixed a null ref exception in static sky when the default volume profile is invalid.

* Update changelog

* [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307)

* Fixed an error about procedural sky being logged by mistake.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379)

* Fixed flickering of the game/scene view when lookdev is running.

* Update changelog

* [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317)

* render until ambient probe is ready

* remove comment

* changelog

* [Backport 7.x.x] Fixed some gcalloc in the debug window (#464)

* Fixed some GCAlloc in the debug window

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs

* Update changelog

* [Backport 7.x.x] Hdrp/small ui update (#466)

* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs
#	com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs

* update changelog

* [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482)

* PBR Sky renderer now shares its internal precomputation table between different instances.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs

* Doc update

* Update changelog

* [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480)

* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs

* Update changelog

* [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479)

* Fixed an issue where asset preview could be rendered white because of static lighting sky.

Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs

* Update changelog

* Changed UI name, tooltip, and doc for maximum decals on screen (#232)

Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/

* Update Custom-Post-Process.md (#233)

* Update HDRP-Features.md (#235)

* Hdrp/reflection probe scale perf #252

* HD: Switch to 1920x1080 default standalone resolution (#279)

Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res

(moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo)

* Makes sure quaternion is normalized and valid before converting to ma… #331

* Fix cookie srgb #297

* Updated forward and deferred rendering definitions (#350)

* Update Forward-And-Deferred-Rendering.md

* Update Forward-And-Deferred-Rendering.md

* Update Light-Component.md (#357)

* Hd/add layer modification on generated emissive mesh for area light #364

* Update Look-Dev-Environment-Library.md (#365)

* Update Volumetric-Lighting.md (#402)

Fixes https://fogbugz.unity3d.com/f/cases/1238592

* Hd/fix nullref while removing decal component #416

* Fix issue with Uber Post process shader when alpha is enabled #422

* Fix the bug (#430)

* Fix issue causing not all baked reflection probes to be deleted #441

* Updated Decal Projector doc (#477)

Updated Limitations section and added a disclaimer about decal shader stripping.

* Look Dev docs refactor 2 #484

* [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425)

* Saturate vertex color to avoid negative values.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix Motion Vectors written by transparent when rendering with MSAA #315

* Fix issue with the resolve of motion vectors (#421)

* fix issue with ShowPrePassAndPostPass

* fix compilation issue in rendergraph

* Fixed null reference exception in LookDev when setting the SRP to None #447

* Check reflection probe null pointer before use. (case 1244047) #456

* Remove max atlas probe alloc size in HDRP asset (#458)

* Fixed max alloc planar size not taking in account the max cache size

* Removed the max cache clamp on texture atlases

* Fix few multi-editing issues with Emission UI #473

* Re-enable cubemap thumbnail gen only for d3d11 #487

* Hd/fix undo environmentlibrary lookdev #490

* Added system requirements and frame settings api docs (#510)

* Added system requirements and frame settings api doc

* Update System-Requirements.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* hide exposure compensation for fixed exposure (#535)

* hide exposure compensation for fixed exposure

* Update PostProcessSystem.cs

* [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522

* Use path relative to package for depth of field #523

* Fix taaFrameIndex and restore TAA tests for XR #534

* Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538)

* fix DXR manifest

* update reference screenshots

* Clone in the Asset folder when the original volume profile is in a re… #508

* Add support for batchmode (#542)

* Update Reflection-Probes-Intro.md (#548)

* Added note on decal emission on transparent surfaces (#567)

* Update Decal-Projector.md

* Update Decal-Projector.md

* Update Decal-Projector.md

* Added terrain lit doc (#573)

* Add terrain lit doc

* Update HDRP-Features.md

* Update HDRP-Features.md

* Hd/fix wizard defaultvolumeprofile creation #565

* Fixed light layers not correctly disabled when the lightlayers is set to Nothing #584

* Hdrp/fix camera switcher (#591)

* Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions.

* update changelog.

* Added Lit master node doc (#613)

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Aras Pranckevičius <aras@unity3d.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
sebastienlagarde added a commit that referenced this pull request Aug 4, 2020
@sebastienlagarde @anisunity
@remi-chapelain @JulienIgnace-Unity @JordanL8 @FrancescoC-unity @adrien-de-tocqueville @slunity @alelievr @RSlysz @pmavridis @fabien-unity @victor-unity @fredericv-unity3d @aras-p @eturquin @skhiat @robinb-u3d
[7.x.x] Merge hd/staging [Skip CI] (#1147)
9ef3a11 
* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507)

* - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).

* Small fix to avoid text overlapping too much

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>

* Fixed an usage of a a compute buffer not bound (1229964) (#28)

Co-authored-by: Anis <anis@unity3d.com>

* Removed wrongly serialized fields in StaticLightingSky (#6441)

* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480

* Update PostProcessSystem.cs

* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493

* Hdrp/docs/glossary f number (#6523)

* Update Glossary.md

* Update Glossary.md

* Clamp probes compression factor to 0 (#19)

* path validation when creating new volume profile (#36)

* [Backport 7.x.x] Fix various leaks in HDRP (#120)

* Fixed a number of leak in HDRP

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs

* Update changelog

* [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128)

* Follow references when unloading unneeded assets

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21)

* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).

* update ssr screenshot

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* d Fix MSAA resolve when there is no motion vectors #1

* Fix issues causing planar probes to be broken with multiple cameras in the scene #4

* Pospow and SG triplanar fix #40

* Hdrp/fix/custom pass msaa rendering info #42

* Added disocclusion and ghosting to the glossary (#75)

* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)

* fix switch shader compilation (#111)

* Update SceneViewDrawMode.cs (#118)

* Fix culling of reflection probes that change position #121

* Fix null reference when processing light probe #131

* Fix black screen in XR when HDRP package is present but not used #137

* Fix default volume profile collapse #138

* Fix for white flash happening when changing lighting condition (like teleport) #140

* Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145)

* Update AxF-Shader.md (#152)

* Bind missing buffer #159

* [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179)

* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs

* Update changelog

* Catch and handle NRefactory parser exceptions #6392

* [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123)

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update CHANGELOG.md

* fix typo

* fix typo 2

* Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284)

* [7.x.x Backport] Fix pre/post pass sg properties #82 (#85)

* Fix depth pre/post passes not correctly enabled when switching shaders on the material

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs
#	com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs
#	com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs

* Hide prepass and postpass in the material UI

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed a performance issue with stochastic ray traced area shadows. (#306)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Updated raytracing async compute warning. (#304)

* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303)

* Fixed a null ref exception in static sky when the default volume profile is invalid.

* Update changelog

* [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307)

* Fixed an error about procedural sky being logged by mistake.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379)

* Fixed flickering of the game/scene view when lookdev is running.

* Update changelog

* [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317)

* render until ambient probe is ready

* remove comment

* changelog

* [Backport 7.x.x] Fixed some gcalloc in the debug window (#464)

* Fixed some GCAlloc in the debug window

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs

* Update changelog

* [Backport 7.x.x] Hdrp/small ui update (#466)

* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs
#	com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs

* update changelog

* [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482)

* PBR Sky renderer now shares its internal precomputation table between different instances.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs

* Doc update

* Update changelog

* [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480)

* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs

* Update changelog

* [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479)

* Fixed an issue where asset preview could be rendered white because of static lighting sky.

Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs

* Update changelog

* Changed UI name, tooltip, and doc for maximum decals on screen (#232)

Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/

* Update Custom-Post-Process.md (#233)

* Update HDRP-Features.md (#235)

* Hdrp/reflection probe scale perf #252

* HD: Switch to 1920x1080 default standalone resolution (#279)

Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res

(moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo)

* Makes sure quaternion is normalized and valid before converting to ma… #331

* Fix cookie srgb #297

* Updated forward and deferred rendering definitions (#350)

* Update Forward-And-Deferred-Rendering.md

* Update Forward-And-Deferred-Rendering.md

* Update Light-Component.md (#357)

* Hd/add layer modification on generated emissive mesh for area light #364

* Update Look-Dev-Environment-Library.md (#365)

* Update Volumetric-Lighting.md (#402)

Fixes https://fogbugz.unity3d.com/f/cases/1238592

* Hd/fix nullref while removing decal component #416

* Fix issue with Uber Post process shader when alpha is enabled #422

* Fix the bug (#430)

* Fix issue causing not all baked reflection probes to be deleted #441

* Updated Decal Projector doc (#477)

Updated Limitations section and added a disclaimer about decal shader stripping.

* Look Dev docs refactor 2 #484

* [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425)

* Saturate vertex color to avoid negative values.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix Motion Vectors written by transparent when rendering with MSAA #315

* Fix issue with the resolve of motion vectors (#421)

* fix issue with ShowPrePassAndPostPass

* fix compilation issue in rendergraph

* Fixed null reference exception in LookDev when setting the SRP to None #447

* Check reflection probe null pointer before use. (case 1244047) #456

* Remove max atlas probe alloc size in HDRP asset (#458)

* Fixed max alloc planar size not taking in account the max cache size

* Removed the max cache clamp on texture atlases

* Fix few multi-editing issues with Emission UI #473

* Re-enable cubemap thumbnail gen only for d3d11 #487

* Hd/fix undo environmentlibrary lookdev #490

* Added system requirements and frame settings api docs (#510)

* Added system requirements and frame settings api doc

* Update System-Requirements.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* hide exposure compensation for fixed exposure (#535)

* hide exposure compensation for fixed exposure

* Update PostProcessSystem.cs

* [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522

* Use path relative to package for depth of field #523

* Fix taaFrameIndex and restore TAA tests for XR #534

* Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538)

* fix DXR manifest

* update reference screenshots

* [Backport 7.x.x] Fixed an issue where manipulating the color wheels in a volume component would reset the cursor every time. (#988)

* Fixed an issue where manipulating the color wheels in a volume component would reset the cursor every time.

* Update changelog

* [Backport 7.x.x] Fixed an issue where static sky lighting would not be updated for a new scene until it's reloaded at least once. (#990)

* Fixed an issue where static sky lighting would not be updated for a new scene until it's reloaded at least once.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Sky/SkyManager.cs

* Update changelog

* [Backport 7.x.x] Add defines guards around shadows hlsl files (#1091)

* Add guards to shadow includes

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowAlgorithms.hlsl

* changelog

* [Backport 7.x.x]  Fix issue with light layers > 7 in the deferred path (#1093)

* Mask layers to consider only the supported 8 bits

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fix decal being duplicated in prefab isolation mode.  (#1103)

* Fixed decals being duplicated in prefab isolation mode.

* Fix decals in the player.

* Update changelog

* Revert "[Backport 7.x.x] Fix decal being duplicated in prefab isolation mode.  (#1103)"

This reverts commit 5e5ecd9.

* Update CHANGELOG.md

* Hdrp/docs/volumetric lighting format fix (#628)

* Updated volumetric lighting and subsurface scattering docs

* Update Override-Diffusion-Profile.md

* Adds mention of fidelityfx-cas as requested by AMD (#629)

* Update Light-Component.md (#682)

* Fix transparent movec scene view #698

* Update HDRP-Camera.md (#706)

* Update Reflection-Probe (#790)

* Update Reflection-Probe.md

* Update Reflection-Probe.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix reflection probe framesettings override #796

* Workaround for GetKernelThreadGroupSizes returning wrong data #760

* Sanitize transparent motion vectors setting #761

* Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823

* Force post process parent setting to be before child settings #799

* Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824)

a warning message when not in batch mode.

* Fix warning in HDAdditionalLightData OnValidate #885

* Revert "Fix warning in HDAdditionalLightData OnValidate #885"

This reverts commit 1798e28.

* Fix warning in HDAdditionalLightData OnValidate #885

* Fix warning in HDAdditionalLightData OnValidate #885 - fix merge issue

* Editing volumes via script doc (#884)

* Added Volumes API doc

* Update Volumes-API.md

* Changed terminology back to Volume Override

* Added terminology disclaimer

* Fix message for metal and ao (#859)

* Update HDR information. Also updated format and links. (#853)

* Fix issue with the blue line of prefab modifications for Volume mode #860

* Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865

* Rename h to hlsl

* Change extensions of CAS includes from h to hlsl #961

* Fix SSAO with double sided material and normal mode to none #1043

* fix typo in the Render Pipeline Wizard #1037

* Fix emissive mesh layer mask behaviour #1062

* Fix for area light baked data not updating when changing the gizmo #1075

* Fixed an error when switch area light shape to disk while an emissive… #1112

* Have the PBR Sky not render black when below horizon #1116

* Fix area light gizmo not updating engine side light v2 #1156

* Fix XR single-pass macros in tessellation shaders #1160

* Update Override-Micro-Shadows.md (#1236)

* Added disclaimer to volumes (#1247)

* Fix XR Display providers not getting zNear and zFar updated on them. #1269

* Moved requirements in toc to make it consistent with URP/VFX #1352

* Docs quality fixes #1445

* Added enable Volume snippet #1477

* Update Volume-Override-Enable-Override.md

* Porting console fixes to staging (#699)

* Fix some NaNs issues on consoles - fix

* [7.x.x Backport] Fix exposure white flash when enabling SSR (#845)

* inform postprocess

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [7.x.x Backport] Fix depth pyramid issues with dynamic resolution  (#849)

* Port

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fixed Look Dev with Light Theme (#1101)

* Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1104)

* Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change.

* Fixed issue when using Custom

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Backport 7.x.x] Fixed an issue where look dev lighting would go black when a new scene is loaded. (#1321)

* Fixed an issue where look dev lighting would go black when a new scene is loaded.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: Anis <anis@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: victor <victor.ceitelis@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Aras Pranckevičius <aras@unity3d.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com>
Co-authored-by: robinb-u3d <robinb-u3d@users.noreply.github.com>
Wilfrid-Unity added a commit that referenced this pull request Aug 17, 2020
@Wilfrid-Unity
Update reference image for UniversalGraphicsTest #145 on OSX
dded503
Wilfrid-Unity added a commit that referenced this pull request Aug 17, 2020
@Wilfrid-Unity
Update reference image for UniversalGraphicsTest #145 on OSX
1f5924b
Wilfrid-Unity added a commit that referenced this pull request Aug 19, 2020
@Wilfrid-Unity
Update reference image for UniversalGraphicsTest #145 on OSXEditor
2b43be2
Wilfrid-Unity added a commit that referenced this pull request Sep 25, 2020
@Wilfrid-Unity
Update URP GFX test #145 reference images (becasue normal bias for po…
953edd5 
…int lights changed in 503afaf
julienf-unity pushed a commit that referenced this pull request Oct 24, 2020
@iTris666
Add one pixel to height in non wide mode so that margin is equal to w…
15e6ed8 
…ide mode. (#145)
PaulDemeulenaere pushed a commit that referenced this pull request Nov 17, 2020
@iTris666 @julienf-unity
Add one pixel to height in non wide mode so that margin is equal to w…
1221603 
…ide mode. (#145)
sebastienlagarde added a commit that referenced this pull request Nov 18, 2020
@julienf-unity @iTris666
@PaulDemeulenaere @JordanL8 @ludovic-theobald @gabrieldelacruz @sebastienlagarde
VFX 8.3 backports (#2669)
fbcd094 
* Fix for blackboard scrollable element hidden by resize.

* Target Gameobject windows resize doesn't go too far above scrollbars

* e3ba0e6 - Missing or incorrect unit in uss.

* [VFX] Fix crash on NDA platform : 100_Fog (#1265)

* Disable noperspective flag for driver issue on NDA platform

* Add minor note to track the actual issue

* Isolate on concerned platform

* Change define condition

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix for node window staying when clicking elsewhere #68

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Fix position of block creation window (#72)

* Fix Prefab Highlight for initial event name toggle & override #71

* Call recreateCopy after recusion test not before. #52

* Uniquify create visual effect gameobject name. Standard behaviour. #75

* Vfx/fix/1246989 normals and scale (#81)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* int and uint support in Compare (#53)

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching

* Fix vfx view not beeing framed at launch

* Fix for the lookup of mixed values in the VisualEffectEditor with obj…

* SampleSDF operator (#88)

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* Fix Construct Matrix on GPU (#102)

* Remove Debug Log

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* Setting ZClip in shadow caster templates (#99)

* Fix and reenable test (#117)

* Fix spawner set attribute/ custom category (#115)

* Fix non uniform scale test (once again)

* Fix cascaded type popup width (#124)

* Forbid creation of context in VisualEffectSubgraphBlock through edge … (#119)

* Make sure m_DependentDirty is flagged when the strutu change because kExpressionGraphChanged is not send for subgraphs. Cleanup (#121)

* Fix overlap in properties (#128)

* Fix Sample installation in URP #122

* Four bug fixes for event tester (#123)

* Reset the indentLevel at the end of VisualEffectEditor, also better c… (#127)

* Un edit nodes that are collapsed (#133)

* Fixes https://fogbugz.unity3d.com/f/cases/1268956/ (#125)

* Create new VisualEffect Graph" creates a graph

* fixed spelling (#142)

* Fix Several issue in Property Binder (#106)

* Add one pixel to height in non wide mode so that margin is equal to wide mode. (#145)

* Fix 1285603 View and Object mode of Shadergraph position node don't r…

* Fix collapse exception and added automated test (#149)

* Misc fixes for vfx shadergraph integrations (#130)

* Small fix for collapse test

* Fix 1255182 Compile errors using Baked GI (default UV settings) / Output Particle Mesh / Connected Attributes (#139)

* Update rebuild all script to take subgraph into account

* Fix suitableContext for subblocks not being serialized

* Fix subgraph not being sanitized at import

* [HDRP] Fix debug view material (albedo/normal/...)

* Force ui update when shader might be reimported in StaticMeshOutput (#158)

* Revert "Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)"

This reverts commit 84ad80d.

* Fix compil

* Backout int and uint support in Compare (#53)

* Override VFXPropertyAttribute equals to make it correct. (#73)

* Override VFXPropertyAttribute equals to make it correct.

* Update CHANGELOG.md

* 8.x.x Fix compile loop in vfxoperator by adding a RecreateCopy mecanism (#63)

* fix 8.x.x/vfx/sugraphoperator compile loop

* Update VFXSubgraphOperator.cs

* Fix changelog

* backout SampleSDF operator (#88)

* Fix some tests (8 and 26)

* Update HDRP VFX + meta

* Update URP project + add missing metas

* *Update HDRP_Debug considering the blending is enable for debug material

* *Add missing standalone 28_CameraProject.png

* *Increase treshold for 26_NonUnifomScale.unity

Co-authored-by: Tristan Genevet <tristan@unity3d.com>
Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>
Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com>
Co-authored-by: Gabriel de la Cruz <gabriel.delacruz@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
PaulDemeulenaere pushed a commit that referenced this pull request Nov 27, 2020
@iTris666 @julienf-unity
Add one pixel to height in non wide mode so that margin is equal to w…
27ad35a 
…ide mode. (#145)
julienf-unity added a commit that referenced this pull request Nov 29, 2020
@PaulDemeulenaere @iTris666
@julienf-unity @JordanL8 @gabrieldelacruz @ludovic-theobald
[7.x.x] [VFX] Batch of backport for 7.5.2 (#2777)
e94ad24 
* Vfx/fix/sgoperator create context drag (#28)

* Vfx/fix/context no blocks (#27)

* PropertyBinder : Minor Fixes #29

* Fix strips outputs, spawnIndex and default metallic value

* [Fix] Disable reset option (#41)

* Fix minor issue with PreviousPropertyBinder (bis) #31

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Simulate headers on enum values in SlotContainerEditor (#49)

* Fix 1246738 - Remove incorrect propagation of expression flags

* [VFX] Fix crash on NDA platform : 100_Fog (#1265)

* Disable noperspective flag for driver issue on NDA platform

* Add minor note to track the actual issue

* Isolate on concerned platform

* Change define condition

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Update ref images

* Update assets

* Fix changelog

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Call recreateCopy after recusion test not before. #52

* Fix Prefab Highlight for initial event name toggle & override #71

* Uniquify create visual effect gameobject name. Standard behaviour. #75

* Vfx/fix/1246989 normals and scale (#81)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching

* Fix vfx view not beeing framed at launch

* Fix for the lookup of mixed values in the VisualEffectEditor with obj…

* Update assets

* Fix 1154328 - infinite recompile with rand (#93)

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* Setting ZClip in shadow caster templates (#99)

* Fix and reenable test (#117)

* Fix spawner set attribute/ custom category (#115)

* Fix non uniform scale test (once again)

* Fix cascaded type popup width (#124)

* Forbid creation of context in VisualEffectSubgraphBlock through edge … (#119)

* Fix overlap in properties (#128)

* Fix overlap in properties

* Update CHANGELOG.md

* Fix Sample installation in URP #122

* Reset the indentLevel at the end of VisualEffectEditor, also better c… (#127)

* Un edit nodes that are collapsed (#133)

* Un edit nodes that are collapsed

* Update CHANGELOG.md

* Update CHANGELOG.md

* Add one pixel to height in non wide mode so that margin is equal to wide mode. (#145)

* Fix 1285603 View and Object mode of Shadergraph position node don't r…

* Fix collapse exception and added automated test (#149)

* Small fix for collapse test

* Fix 1255182 Compile errors using Baked GI (default UV settings) / Output Particle Mesh / Connected Attributes (#139)

* Fix suitableContext for subblocks not being serialized

* Remove Debug Log

* [HDRP] Fix debug view material (albedo/normal/...)

* Fix changelog

* Fix compilation of expression tests

* Fix shadow test ref images

* Fix Non Uniform Scale test (remove physical sky)

* *Update HDRP_Debug reference image

* *Rebuild all .vfx (HDRP by default)

* Revert "*Rebuild all .vfx (HDRP by default)"

This reverts commit 2aea342.

* *Rebuild all remaining vfx (HDRP)

* *Rebuild all remaining vfx (URP)

Co-authored-by: Tristan Genevet <tristan@unity3d.com>
Co-authored-by: Julien Fryer <julienf@unity3d.com>
Co-authored-by: Thomas Iché <thomasi@unity3d.com>
Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: Gabriel de la Cruz <gabriel.delacruz@unity3d.com>
Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com>
ellioman pushed a commit that referenced this pull request Nov 30, 2020
@Wilfrid-Unity
Universal/point light shadows (#1616)
a803690 
* Update Runtime/Passes/AdditionalLightsShadowCasterPass to support point lights

Like with spot lights, resolution for each shadow map is computed every frame in order to fit all of them in the common shadow atlas.

Some of the current limitations:
- ShadowBias possibly needs more precise values
- FovBias possibly needs more precise values
- Unused shadow faces allocate a slot in the common shadow atlas
- Draw calls are generated even for shadow frustums that do not contain shadow casters
- Not tested: Standalone players
- Not tested: Dynamic scenes
- Not tested: Performances
- Not tested: Code path using Structured Buffers to pass shadow information to GPU (during shadow pass and lighting loop)
- Not tested: Deferred Renderer

* Enable shadow parameters in Point Lights Inspector windows

* Add comments

* Fix point light shadow normal bias issues

Normal bias for point lights now behaves similarly as for spot lights

* Include point light shadow fov bias when computing their normal bias - This makes point light shadows look closer to spot light shadows

* For punctual lights, use per-vertex light direction when applying shadow normal bias - This fixes the issue of shadows that changed when point light was rotated.

Built-In RP uses a similar approach to apply punctual light shadow normal bias. See UnityWorldSpaceLightDir called by UnityClipSpaceShadowCasterPos in UnityCG.cginc:
https://github.cds.internal.unity3d.com/unity/unity/commit/93015b67a6e1afdfe00867fdd3a336eaa835f54d#diff-c2818feb2f37e566cf36ca5cab57a99eR533
https://github.cds.internal.unity3d.com/unity/unity/blob/93015b67a6e1afdfe00867fdd3a336eaa835f54d/External/shaderlab/CGIncludes/UnityCG.cginc#L76

* Update comments

* Fix limit of shadow map slices available when using the "Uniform Buffer" code path

* Fix in all supported resolutions point light shadow frustum fov biases, to avoid missing shadows at cube face boundaries

* Fix Point Light Shadows in Deferred Renderer

* Point Light Shadows work also when using StructuredBuffers to pass shadow data to the lighting shaders + Fixed indexing issue when using non-shadow-casting additional light

Some known issues still happening:
- If only a single light in the scene is set to use soft shadows, all punctual light shadows will be soft (even if their setting is "Hard")
- Toggling setting "Soft Shadows" in UniversalRP asset also impacts shape of shadows from punctual light set to cast "Hard Shadows"

* Fix out-of-bound array access reported by several tests in the UniversalGraphicsTest suite

* Enable per-light "soft" or "hard" shadow type setting

* Update UniversalGraphicsTest scene 105_TransparentReceiveShadows's spot light shadow's Normal Bias to match reference image - Since revision ed8fcbe Normal Bias is applied using actual spot light direction

* Apply change ed8fcbe to Terrain shaders too (i.e for punctual lights, use per-vertex light direction when applying shadow normal bias)

* Fix issue: "disabling Soft Shadows in UniversalRP.asset changes shape of Hard Shadows"

* Assign ShadowSplitData info to ShadowDrawingSettings before passing it to ScriptableRenderContext.DrawShadows - Reduces the number of shadow casters rendered to the shadow map

* Update UniversalGraphicsTest scenes 142_SSAO_DepthNormal_Projection and 143_SSAO_DepthNormals_Orthographic directional light shadows Normal Bias to match reference images - Since revision ed8fcbe formula to apply Normal Bias changed slightly

* Add an entry to changelog.md

* Update comment about Directional Light Shadow culling

See also native-side changes introduced for Persistent Intermediate Renderer:
https://github.cds.internal.unity3d.com/unity/unity/commit/89f4e3b
https://github.cds.internal.unity3d.com/unity/unity/commit/fbe6025
https://github.cds.internal.unity3d.com/unity/unity/commit/8652678

* Add Obsoletes and #defines to avoid user script/shader compilation errors

* Update comment about Directional Light Shadow culling (2)

* Add UniversalGraphicsTest suite scene checking for regressions with additional light shadows

Test fails if "hard shadows" setting is replaced by "soft shadows" setting
Test fails if "soft shadows" setting is replaced by "hard shadows" setting
Test fails if "no shadows" setting is replaced by "shadows" setting
Test fails if one of the punctual lights in the scene is not rendered

* Update reference image for UniversalGraphicsTest #145 on OSX

* Update reference image for UniversalGraphicsTest #145 on OSXEditor

* Fix issue "influence of point light shadow depth bias depends on spotlight angle" introduced in 1552692

* Re-introduce variable _LightDirection and introduce _LightPosition (instead of _ShadowCastingLightParameters from revision 6341928)

This avoids deprecation of public variables, and makes code easier to understand
Addresses comments:
#1616 (comment)
#1616 (comment)
#1616 (comment)

* Remove unused structure ShadowData from hlsl declarations

Addresses comment #1616 (comment)

* Make code slightly more readable as suggested in #1616 (comment)

* Move deprecated variable declarations, and avoid shader API breakage

Addresses following comments:
#1616 (comment)
#1616 (comment)
#1616 (comment)

* Mark ShaderInput.ShadowData as obsolete - Addresses comment #1616 (comment)

Moving ShaderInput.ShadowData declaration into com.unity.render-pipelines.universal/Runtime/Deprecated.cs would cause compilation errors (because it is in a different assembly), therefore a different Deprecated.cs file must be used (in the Unity.RenderPipelines.Universal.ShaderLibrary assembly)

* Apply change ed8fcbe to ShaderGraph shaders too (i.e for punctual lights, use per-vertex light direction when applying shadow normal bias)

Addresses comment #1616 (review)

* Add comment

* Avoid storing incorrect depth in shadow map when object scale causes vertices to be outside shadow frustum

Issue illustrated by project https://github.com/Wilfrid-Unity/scaled-box-spot-shadow

* Update UniversalGraphicsTest scenes 144_SSAO_RenderToBackBuffer directional light shadows Normal Bias to match reference images - Since revision ed8fcbe formula to apply Normal Bias changed slightly

* Add upgrade guide entry regarding Normal Bias

Formula changed in ed8fcbe

* Update documentation

* Update UniversalGraphicsTest scene 145_ManyAdditionalLightShadowTypes reference images

* Apply change ed8fcbe to ComplexLit shader too (i.e for punctual lights, use per-vertex light direction when applying shadow normal bias)

* Update UniversalGraphicsTest scene 143_SSAO_DepthNormals_Orthographic reference images

* Add documentation page about shadows

According to https://docs.google.com/document/d/1tkQdYKx2bED5hp3dTmUlkeZS_moiUsRZeMS4hMXHfXk/edit?disco=AAAAG79JQOc

* Update changelog

Addresses comment https://github.com/Unity-Technologies/Graphics/pull/1616/files?file-filters%5B%5D=.md#r488637466

* Update versioning in documentation

* Do not remove older version of ShadowUtils.ExtractDirectionalLightMatrix

Related comment: #1616 (comment)

* Update reference images for UniversalGraphicsTest 142 (SSAO)

* Strip unused ShadowCaster shader variants

* Use the same value as Built-In RP for Point-Light Shadows Normal Bias (0.0)

* Match default Additional Lights Shadow Atlas resolution to default Main Lights Shadow Atlas resolution (this also matches default point light light shadow slice resolution to Built-In RP default lowest shadow quality setting)

* Revert URP.asset files used for tests (incorrectly modified in 25f890c )

* Add explanations about Normal Bias in Editor U.I

* Update URP GFX test #145 reference images (becasue normal bias for point lights changed in 503afaf

* Use a slope-scaled depth bias (like HDRP and Built-In RP) to reduce shadow acne on self-shadowing objects

Fixes shadow acne illustrated by scene Wilfrid-Unity/compare-rp-shadows@bdd8aa2b62e48c5a2dffa5357c86792d1a864fe6( that tries to reproduce symptoms reported by @simon-engelbrecht-soerensen )

* Restore default depth bias values before exiting ShadowUtils.RenderShadowSlice

Fixes rendering issue that happened in revision 7c022e1 with test TestProjects/UniversalGraphicsTest/Assets/Scenes/119_CameraToRTWithViewportRect

* Give Yamato more time to build DX11 & Android-ES3 Graphics test projects (~30min -> ~5h)

* Prevent rendering issues when too many shadowed additional lights are active at the same time

This fixes the issue illustrated by internal ticket https://fogbugz.unity3d.com/f/cases/1290117

* Improve performance on mobiles, and avoid shader compilation issues on GLES3.0 devices, by reducing _AdditionalLightsWorldToShadow size

* Improve performance on Mobiles (especially for scenes with lot of overdraw)

Thanks again to @hkr suggestion

* Add work-around against OnePlus6T GLES3 crash reported in #1616 (comment)

Work-around can be removed after https://fogbugz.unity3d.com/f/cases/1293454/ is fixed

* Fix incomplete initialization of _AdditionalShadowParams that could cause stale data artifacts after disabling a light

Solves internal issue https://fogbugz.unity3d.com/f/cases/1293532/

* Update UniversalGraphicsTest reference images (results from change 503afaf )

* Apply Main Light's shadow fade (based on distance to camera) to Additional Lights too

Fixes "shadows popping" behavior illustrated by https://github.com/Unity-Technologies/BoatAttack/tree/testing/urp-pointlight-shadows, when changing PipelineAsset's "Shadows Max Distance" setting

* Update UniversalGraphicsTest reference images (iPhone)
Wilfrid-Unity added a commit that referenced this pull request Dec 14, 2020
@Wilfrid-Unity
Universal/custom shadow resolution for additional lights (#2126)
ac5d178 
* Update Runtime/Passes/AdditionalLightsShadowCasterPass to support point lights

Like with spot lights, resolution for each shadow map is computed every frame in order to fit all of them in the common shadow atlas.

Some of the current limitations:
- ShadowBias possibly needs more precise values
- FovBias possibly needs more precise values
- Unused shadow faces allocate a slot in the common shadow atlas
- Draw calls are generated even for shadow frustums that do not contain shadow casters
- Not tested: Standalone players
- Not tested: Dynamic scenes
- Not tested: Performances
- Not tested: Code path using Structured Buffers to pass shadow information to GPU (during shadow pass and lighting loop)
- Not tested: Deferred Renderer

* Enable shadow parameters in Point Lights Inspector windows

* Add comments

* Fix point light shadow normal bias issues

Normal bias for point lights now behaves similarly as for spot lights

* Include point light shadow fov bias when computing their normal bias - This makes point light shadows look closer to spot light shadows

* For punctual lights, use per-vertex light direction when applying shadow normal bias - This fixes the issue of shadows that changed when point light was rotated.

Built-In RP uses a similar approach to apply punctual light shadow normal bias. See UnityWorldSpaceLightDir called by UnityClipSpaceShadowCasterPos in UnityCG.cginc:
https://github.cds.internal.unity3d.com/unity/unity/commit/93015b67a6e1afdfe00867fdd3a336eaa835f54d#diff-c2818feb2f37e566cf36ca5cab57a99eR533
https://github.cds.internal.unity3d.com/unity/unity/blob/93015b67a6e1afdfe00867fdd3a336eaa835f54d/External/shaderlab/CGIncludes/UnityCG.cginc#L76

* Update comments

* Fix limit of shadow map slices available when using the "Uniform Buffer" code path

* Fix in all supported resolutions point light shadow frustum fov biases, to avoid missing shadows at cube face boundaries

* Fix Point Light Shadows in Deferred Renderer

* Point Light Shadows work also when using StructuredBuffers to pass shadow data to the lighting shaders + Fixed indexing issue when using non-shadow-casting additional light

Some known issues still happening:
- If only a single light in the scene is set to use soft shadows, all punctual light shadows will be soft (even if their setting is "Hard")
- Toggling setting "Soft Shadows" in UniversalRP asset also impacts shape of shadows from punctual light set to cast "Hard Shadows"

* Fix out-of-bound array access reported by several tests in the UniversalGraphicsTest suite

* Enable per-light "soft" or "hard" shadow type setting

* Update UniversalGraphicsTest scene 105_TransparentReceiveShadows's spot light shadow's Normal Bias to match reference image - Since revision ed8fcbe Normal Bias is applied using actual spot light direction

* Apply change ed8fcbe to Terrain shaders too (i.e for punctual lights, use per-vertex light direction when applying shadow normal bias)

* Fix issue: "disabling Soft Shadows in UniversalRP.asset changes shape of Hard Shadows"

* Assign ShadowSplitData info to ShadowDrawingSettings before passing it to ScriptableRenderContext.DrawShadows - Reduces the number of shadow casters rendered to the shadow map

* Update UniversalGraphicsTest scenes 142_SSAO_DepthNormal_Projection and 143_SSAO_DepthNormals_Orthographic directional light shadows Normal Bias to match reference images - Since revision ed8fcbe formula to apply Normal Bias changed slightly

* Add an entry to changelog.md

* Update comment about Directional Light Shadow culling

See also native-side changes introduced for Persistent Intermediate Renderer:
https://github.cds.internal.unity3d.com/unity/unity/commit/89f4e3b
https://github.cds.internal.unity3d.com/unity/unity/commit/fbe6025
https://github.cds.internal.unity3d.com/unity/unity/commit/8652678

* Add Obsoletes and #defines to avoid user script/shader compilation errors

* Update comment about Directional Light Shadow culling (2)

* Add UniversalGraphicsTest suite scene checking for regressions with additional light shadows

Test fails if "hard shadows" setting is replaced by "soft shadows" setting
Test fails if "soft shadows" setting is replaced by "hard shadows" setting
Test fails if "no shadows" setting is replaced by "shadows" setting
Test fails if one of the punctual lights in the scene is not rendered

* Update reference image for UniversalGraphicsTest #145 on OSX

* Update reference image for UniversalGraphicsTest #145 on OSXEditor

* Fix issue "influence of point light shadow depth bias depends on spotlight angle" introduced in 1552692

* Re-introduce variable _LightDirection and introduce _LightPosition (instead of _ShadowCastingLightParameters from revision 6341928)

This avoids deprecation of public variables, and makes code easier to understand
Addresses comments:
#1616 (comment)
#1616 (comment)
#1616 (comment)

* Remove unused structure ShadowData from hlsl declarations

Addresses comment #1616 (comment)

* Make code slightly more readable as suggested in #1616 (comment)

* Move deprecated variable declarations, and avoid shader API breakage

Addresses following comments:
#1616 (comment)
#1616 (comment)
#1616 (comment)

* Mark ShaderInput.ShadowData as obsolete - Addresses comment #1616 (comment)

Moving ShaderInput.ShadowData declaration into com.unity.render-pipelines.universal/Runtime/Deprecated.cs would cause compilation errors (because it is in a different assembly), therefore a different Deprecated.cs file must be used (in the Unity.RenderPipelines.Universal.ShaderLibrary assembly)

* Apply change ed8fcbe to ShaderGraph shaders too (i.e for punctual lights, use per-vertex light direction when applying shadow normal bias)

Addresses comment #1616 (review)

* Add comment

* Avoid storing incorrect depth in shadow map when object scale causes vertices to be outside shadow frustum

Issue illustrated by project https://github.com/Wilfrid-Unity/scaled-box-spot-shadow

* Update UniversalGraphicsTest scenes 144_SSAO_RenderToBackBuffer directional light shadows Normal Bias to match reference images - Since revision ed8fcbe formula to apply Normal Bias changed slightly

* Add upgrade guide entry regarding Normal Bias

Formula changed in ed8fcbe

* Update documentation

* Update UniversalGraphicsTest scene 145_ManyAdditionalLightShadowTypes reference images

* Apply change ed8fcbe to ComplexLit shader too (i.e for punctual lights, use per-vertex light direction when applying shadow normal bias)

* Update UniversalGraphicsTest scene 143_SSAO_DepthNormals_Orthographic reference images

* Add documentation page about shadows

According to https://docs.google.com/document/d/1tkQdYKx2bED5hp3dTmUlkeZS_moiUsRZeMS4hMXHfXk/edit?disco=AAAAG79JQOc

* Update changelog

Addresses comment https://github.com/Unity-Technologies/Graphics/pull/1616/files?file-filters%5B%5D=.md#r488637466

* Update versioning in documentation

* Do not remove older version of ShadowUtils.ExtractDirectionalLightMatrix

Related comment: #1616 (comment)

* Update reference images for UniversalGraphicsTest 142 (SSAO)

* Strip unused ShadowCaster shader variants

* Use the same value as Built-In RP for Point-Light Shadows Normal Bias (0.0)

* Match default Additional Lights Shadow Atlas resolution to default Main Lights Shadow Atlas resolution (this also matches default point light light shadow slice resolution to Built-In RP default lowest shadow quality setting)

* Revert URP.asset files used for tests (incorrectly modified in 25f890c )

* Add explanations about Normal Bias in Editor U.I

* Update URP GFX test #145 reference images (becasue normal bias for point lights changed in 503afaf

* Use a slope-scaled depth bias (like HDRP and Built-In RP) to reduce shadow acne on self-shadowing objects

Fixes shadow acne illustrated by scene Wilfrid-Unity/compare-rp-shadows@bdd8aa2b62e48c5a2dffa5357c86792d1a864fe6( that tries to reproduce symptoms reported by @simon-engelbrecht-soerensen )

* Restore default depth bias values before exiting ShadowUtils.RenderShadowSlice

Fixes rendering issue that happened in revision 7c022e1 with test TestProjects/UniversalGraphicsTest/Assets/Scenes/119_CameraToRTWithViewportRect

* [Universal RP] Add support for custom additional (i.e punctual) light shadow resolution

Includes UI similar to HDRP, and a new Graphics test

* Enable incorrectly commented out debug warnings

* Give Yamato more time to build DX11 & Android-ES3 Graphics test projects (~30min -> ~5h)

* Prevent rendering issues when too many shadowed additional lights are active at the same time

This fixes the issue illustrated by internal ticket https://fogbugz.unity3d.com/f/cases/1290117

* Improve performance on mobiles, and avoid shader compilation issues on GLES3.0 devices, by reducing _AdditionalLightsWorldToShadow size

* Improve performance on Mobiles (especially for scenes with lot of overdraw)

Thanks again to @hkr suggestion

* Add work-around against OnePlus6T GLES3 crash reported in #1616 (comment)

Work-around can be removed after https://fogbugz.unity3d.com/f/cases/1293454/ is fixed

* Fix incomplete initialization of _AdditionalShadowParams that could cause stale data artifacts after disabling a light

Solves internal issue https://fogbugz.unity3d.com/f/cases/1293532/

* Do not render shadow slices for which we cannot allocate a big enough slot in the shadow atlas

This avoids visual artifacts happening when there are too many shadows ; as illustrated in internal ticket https://fogbugz.unity3d.com/f/cases/1289619

# Conflicts:
#	com.unity.render-pipelines.universal/Runtime/Passes/AdditionalLightsShadowCasterPass.cs

* Only output additional light shadows warnings when the shadow configuration changes

# Conflicts:
#	com.unity.render-pipelines.universal/Runtime/Passes/AdditionalLightsShadowCasterPass.cs

* Fix merge conflict

* Update UniversalGraphicsTest reference images (results from change 503afaf )

* Update UniversalGraphicsTest reference image for Android/Vulkan

* Make changelog more clear to reflect comment #2126 (comment)

* Add public APIs documentation as recommended in #2126 (comment)

* Adjust Point Light shadow resolution in UniversalGraphicsTest#105 in order to match reference images

* Apply Main Light's shadow fade (based on distance to camera) to Additional Lights too

Fixes "shadows popping" behavior illustrated by https://github.com/Unity-Technologies/BoatAttack/tree/testing/urp-pointlight-shadows, when changing PipelineAsset's "Shadows Max Distance" setting

* Update UniversalGraphicsTest reference images (iPhone)

* Fix inconsistency in code handling high number of punctual light shadows

Solves issue described in https://docs.google.com/document/d/1tkQdYKx2bED5hp3dTmUlkeZS_moiUsRZeMS4hMXHfXk/edit#bookmark=id.dqn8fqx5f45
(i.e: repro by editing TestProjects/UniversalGraphicsTest/Assets/Scenes/010_AdditionalLightsSorted/SortedLightsTestPrefab.prefab to make the meshes cast shadows, and running UniversalGraphicsTest#010_AdditionalLightsSorted)

* Fix incorrectly initialized array

Solves issue happening when after procedure described in https://docs.google.com/document/d/1tkQdYKx2bED5hp3dTmUlkeZS_moiUsRZeMS4hMXHfXk/edit#bookmark=id.dqn8fqx5f45
(i.e: repro by editing TestProjects/UniversalGraphicsTest/Assets/Scenes/010_AdditionalLightsSorted/SortedLightsTestPrefab.prefab to make the meshes cast shadows, running UniversalGraphicsTest#010_AdditionalLightsSorted, and switching to Scene view)

* Update UniversalGraphicsTest reference image (iPhone)

* Cache array member variable (to reduce heap allocations)

See example in section "Unity function calls" of https://learn.unity.com/tutorial/fixing-performance-problems

* Increase priority of shadowRequests for light near camera to reduce shadow popping when scene uses more shadows than what the atlas can hold

Mitigates issues illustrated by test scene https://github.com/Wilfrid-Unity/compare-rp-shadows/blob/master/urp-shadows/Assets/Scenes/010_ManyPointShadows.unity

* Update UniversalGraphicsTest reference image for Android-GLES3
PaulDemeulenaere added a commit that referenced this pull request May 5, 2021
@PaulDemeulenaere @pastasfuture
@julienf-unity @gabrieldelacruz @JordanL8 @iTris666 @ludovic-theobald @peeweek
[VFX] Test for exact fixed time step (& restore option) (#4365)
30e69c2 
* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* update asset and scripts

* Remove unwanted files

* Output Event Helpers (revival) (#111)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

* Revert "Revert "Output Event Helpers" (#110)"

This reverts commit e72745d0ce4df6205dffa8aca7332a8afea96880.

* Revert "Revert "Output Event Helpers" (#110)"

This reverts commit e72745d0ce4df6205dffa8aca7332a8afea96880.

* First pass of coding rule validation

* Rename VFXOutputEventHandler in VFXOutputEventAbstractHandler

Following coding rule from https://ono.unity3d.com/unity-extra/unity-meta/files/@/ReferenceSource/CSharp/Assets/CSharpReference.cs

* *Missing rename

* Remove useless member

* Rework VFXOutputEventPrefabSpawn :

- Avoid any inconsistency with transform
- Use prefab link when available
- Use a lazy approach and lock editable values to editor

* Fix issue with "Open Prefab" which was resetting the "Hide Flag"

* *Minor cleanup

* *Minor Change

* Missing DisposeInstance when we are disabling "Execute In Editor"

* Fix missing full stop at the end of all tooltips

* *Apply auto formatting

* Fix spamming null reference error reported by @vlad

https://unity.slack.com/archives/GA2Q6JU1X/p1601055259085900?thread_ts=1601044036.085800&cid=GA2Q6JU1X

* Safely fallback on Instanciate when InstantiatePrefab returns silently null

Instance of prefab within the scene are actually copies because an override could have been applied.

* Fix model spawn using NotAPrefab instead of Regular

* Expliciter code in VFXOutputEventPrefabSpawn

Doesn't change the internal behavior

* Minor fix : audio != null isn't equivalent than audio?.

* Fix assignement : prevent setting audioSource or rigidBody from a prefab asset

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/111#discussion_r73827

Use explicit DrawOutputEventProperties to avoid multiple serializedObject.Update per Inspector

* Minor : remove unexpected carriage return

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>
Co-authored-by: Thomas Iché <thomasi@unity3d.com>

* Fix spawner set attribute/ custom category (#115)

* Fix spawner set attribute/ custom category

* Update CHANGELOG.md

* Update CHANGELOG.md

* Setting ZClip in shadow caster templates (#99)

* Setting ZClip in shadow caster templates

Shadows from directional lights where culled by the near plane in some cascades
Added ZClip [_ZClip] to every PassShadowCaster.template file.

* Update CHANGELOG.md

Update changelog

* Modify graphic test for vfx shadows to test ZClip

Added an extra particle mesh output that could potentially be clipped by the near plane in some cascades

* Trigger output can start an edge drag [Case 1271691] (#114)

* Trigger output can start an edge drag [Case 1271691](https://fogbugz.unity3d.com/f/cases/1271691/)

* Update CHANGELOG.md

* Fix and reenable test (#117)

* Error display in vfx editor (#33)

* First commit for link impossible explanation.

* Some cleanup, delay before info appear. info appear always in the view.

* added error management when linking a GPU operator to a CPU slot.

* added uninitilized attribute message with context granularity.

* Alert when a context a context slot, a block or a block slot use an attribute that is not initialized, except for a known list of attributes with good default values (TBC).

* adding age to the list of attributes with good initial value

* fix errorr message bases on vlad feedback.

* fix for rebase

* use RequireInitialization Flag on attributes instead of list of attribute name with good value.

* really remove attribute with good default values.

* Fix for rebase

* fixes based on PR review

* cleanup based on PR comments

* Move resources for this PR to Editor Default Resources

* fixes for merge

* Work on error handling for invalidate

* Compile and Invalidate Error works.

* add ignore error

* Make sure non ignored error are visible at start

* make sure error indices are unique.

* clear unwanted diffs

* Fixes for merge

* fixes for uss warnings.

* Remove incrorrect code from VFXGraph.cs

* Fixes based on PR review.

* Removed VFXErrors

* Started working on drag ignore for refresherrors

* Drag on filed label on refresherrors once.

* Slider drag do not trigger a refresh error

* Remove debug log.

* Removed useless line

* Update CHANGELOG.md

* Fix editorTest which cover copy/past without a graph attached to the controller

* Add missing meta

* delete Editor/Resource empty directories and metas

* Removed VFXBlockDataAnchor from this branch as a bad merge readded it.

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

* *Add missing reference image & fix changelog bad merde

* Fix bad merge : unexpected change in "ConstantBuffer.cs"

* Fix non uniform scale test (once again)

* Update assets

* Update URP assets

* Increase error threshold on test 26 (due to sky)

* Fix reference images for shadow test

* Fix cascaded type popup width (#124)

* Fix cascaded type popup width

* Update CHANGELOG.md

* Be resilient to possible null subgraph references. (#120)

* Be resilient to possible null subgraph references.

* Update CHANGELOG.md

* Update CHANGELOG.md

* Fix 101_Exposure on PS4 (#126)

* Fix wrong code generation from PSSL

* *Update changelog.md

* Remove inout BuiltInData which is a bit counter intuitive

Bonus : Remove VFXClipFragmentColor which was done twice.

* Forbid creation of context in VisualEffectSubgraphBlock through edge … (#119)

* Forbid creation of context in VisualEffectSubgraphBlock through edge dropping

* Update CHANGELOG.md

* Make sure m_DependentDirty is flagged when the strutu change because kExpressionGraphChanged is not send for subgraphs. Cleanup (#121)

* Fix overlap in properties (#128)

* Fix overlap in properties

* Update CHANGELOG.md

* Fix bad merge from c72287dfdb8c9b041db6c6d49582241810c73a9b

Wrongly formed meta files

* Fix Sample installation in URP (#122)

* Fix RecreateCopy since subouput are conserved

Regression introduced at 273b6e32cac0e7ad19b7c8dbbed08593e39fe4f8

* *Update changelog.md

* Four bug fixes for event tester (#123)

* Fixe some bugs on event tester window

* Update CHANGELOG.md

* adding another bugfix

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Fix for displaying error from the creation of a node. (#131)

* Fix for displaying error from the creation of a node.

* *Add warning for CollisionDepthBuffer

Update & Fix Changelog.md

* Update message from @vlad suggestion

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

* Blackboard improvements ( clear unused properties, add output ) (#45)

* Added clear unused properties menu

* added add button to outputcategories.

* unused properties are greyed in the blackboard.

* Fix from PR review

* Update CHANGELOG.md

* Fix

* Menu for blackboard separated from menu for Pills no more triple dot menu.

* Fix unwanted changelog changes

* reset modified icon meta

* Delete Parameter in Blackboard deletes all selected parameters.

* Fixed weird blackboard field selection behaviour on Windows

* Reset the indentLevel at the end of VisualEffectEditor, also better c… (#127)

* Reset the indentLevel at the end of VisualEffectEditor, also better criteria for doubling the width when the inspector is not wide enough.

* Conserve original enabled state in VisualEffectEditor

* Update CHANGELOG.md

* Un edit nodes that are collapsed (#133)

* Un edit nodes that are collapsed

* Update CHANGELOG.md

* Update CHANGELOG.md

* Fixes https://fogbugz.unity3d.com/f/cases/1268956/ (#125)

* Block - Position on SDF (#105)

* Initial commit

* Update PositionOnSDF.cs

* Test scene + new SDF assets

* Two step approach for projection, texture margin in expression, new test scene

* Performance improvement

* Revert "Performance improvement"

This reverts commit 42ce897756bcdb3bb279abbd529fa9fe33e49884.

* Modify test scene

* minor changes

* Fixing the output direction

* Add graphic tests

* Update references

* Update CHANGELOG.md

* Fast derivatives, outliers killing option, cleaning

* Convert line endings

* Added docoumentation and supporting media.

* Update PositionOnSDF.cs

* Filename did not match the class name ...

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix several URP issue (for 10.2) (#116)

* *Prepare Scene for new sample reflection test

* *Update Scene

* Fix Reflection Probe missing edition

URP only because SupportedRenderingFeatures.active.reflectionProbes is tested

* Filter out rendererPriority if SupportedRenderingFeatures.active.rendererPriority returns false

* Fix missing layer option : correctly fallback to the default layer if srpAsset.renderingLayerMaskNames returns null

* Prepare test addition for RenderDepth

* Fix missing depthpass in URP

* *Add test data

* *Add Test Data for SubPixelAA

* Fix SubPixelAA

* Fix missing warning using Proxy Volume with URP

* Add two sections in inspector to separate probe setting than additionnal

Also add a comment about m_SortingOrder

* *Update 014 before moving this to common

* Add 014_ScreenSpaceSize to HDRP

* *Add graphicTest for URP

* *Add Reference images for player

* *Add missing meta file

* *Add Editor Image reference

* *Update changelog.md

* Add editor test : Check_VFXRenderer_DefaultRenderingLayerNames

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/116#discussion_r78363

* "Create new VisualEffect Graph" creates a graph from the default template [Case 1279999](https://fogbugz.unity3d.com/f/cases/1279999/) (#113)

* fixed spelling (#142)

* Positition on SDF - Graphics Tests Fix (#138)

* Complete .vfx files and update references

* Updated documentation.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Update assets

* Fix changelog

* More changelog fixes

* Add missing warning for other block operator using depth (#140)

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#discussion_r79026

* *Adding missing meta file in TestProject

* Missing doc & Deprecate VFXViewModicationProcessor (#143)

* Fix missing doc & Deprecate VFXViewModicationProcessor

Unexpected public API

* *Revert unexpected change

* Fix several issue from @lewisjordan

- fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/143#discussion_r79397
- fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/143#discussion_r79398

* Fix Several issue in Property Binder (#106)

* Fix case 1274790 : Use DestroyImmediate when editor isn't playing

* Fix case 1247230 : Avoid null exposed property

Property entry is modified by UX always not null, however, it requires a default value

* Fix case 1274788 : Missing null check in Hierarchy to Attribute Map

* Fix case 1248711 : Property window view wasn't working

Missing Update, it also fixes Undo/Redo

* *Update changelog

* Fix compilation when ENABLE_LEGACY_INPUT_MANAGER isn't enabled

Should be fix for 10.2

* Fix case 1279471 : Avoid OnMouseDown/Up/... declaration

Game scripts or other custom code contains OnMouse_ event handlers. Presence of such handlers might impact performance on handheld devices." when building for Android/IOS

* Fix positionDepthOperator ref images

* Add one pixel to height in non wide mode so that margin is equal to wide mode. (#145)

* Update CHANGELOG.md

* Fix API validation

* Harmonize Composition in Position / Velocity Blocks (#44)

* Base refactor + Attempt to get position from AABox (not working for thickness ATM)

* Fixed cone syntax issues + correct computation of AABox direction

* Added Variant providers + Composition in Sequential

* Updated Variants for Shape Sequential Blocks

* Harmonized Namings + added composition to Position Depth

* Updated Changelog

* Fixes for PR

* Fixed Blend Composition in Sequential

* Added Direction to PositionSequential

* Fixes in Position Circle / Set Blend factor in shapes to 1.0 by default

* Used Absolute Box size as expression

* Propal for https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44/files/e029bb9ec37555e70af21a97399774667030c031#r61533

Use case by case approach for direction of AABox

* *Temp add test data for graphicTest

* Fix ApplyAddressingMode : clamp & mirror was overflowing, mirror has also a wrong pattern

* Edit graphicTest

* Move 014 to common package

* Add 014_PositionBlock in editor test listing

* Precompute line_direction in PositionLine

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44/files#r67908

* *Add reference images

* Fix editor test (wrong reference data)

* Fix issue introduced at 9c54056a68e9ef90354e969e9baba18aa552f8f4 : Looping correctly the circle

See also : https://unity.slack.com/archives/G1BTWN88Z/p1598508170069200?thread_ts=1598429838.039200&cid=G1BTWN88Z

* Probably uploaded the wrong image reference for standalone

* *Update reference images (I think I mess up twice, I should double check the change in motionVector)

* Fix build (VFXExpressionCondition now supports uint)

* *Temp* Delete motion vector reference image, should regenerate them from yamato.

* Readd reference image using yamato result at b9a04b7424323e0c3801e34c13213c4050f020f1

* *Update changelog

Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44#discussion_r70582

* Fix PositionTorus when used in vertex shader

* Fix multiple definition of UNITY_PI

* Fix changelog

bad automatic merge

* Fix incorrect volume

Base radius while computing volume factor on sphere & circle : use fix approach from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/89 using name instead of index
See : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44#issuecomment-28990 & https://docs.google.com/document/d/1RAVkfmMQA9D_hKkJyt6PKOgRs8JHkjlYRhcfBtIU1Ag/edit?disco=AAAAJ7Z4S18

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>
Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>
Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix 1285603 View and Object mode of Shadergraph position node don't return proper values (#141)

* Update VFXShaderGraphParticleOutput.cs

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix collapse exception and added automated test (#149)

* Misc fixes for vfx shadergraph integrations  (#130)

* Diffusion profile has PropertyType.Float but isn't castable in Vector1ShaderProperty : safeprof code

* Unity serialization produced a beast with object.ReferenceEquals(null) != 0 and instanceID == 0 foolProof code for this

* Update CHANGELOG.md

* Small fix for collapse test

* Some extra security around error feedback (#153)

* Prevent exceptions from making notification stay. Prevent exception in errors to potential break the ui

* Prevent list from being badly deserialized.

* Fix Event connected directly to Output Event (#152)

* Add missing filter in CanLink function

* Add editor test

* *Update changelog.md

* *Update comment

* *Update Comment

* Misc fixes in strips (#136)

* Vfx/feature/strips improvements (#265)

* Add spanwIndexInStrip attribute

* Fix particleCountInStrip in Init

* Add OrientStrip block

* Remove some useless code

* Add From Target Position mode in Orient Strip

* Update changelog

* Fix SpawnOverDistance

* Fix reference images

* Fix changelog

* Merge Orient and OrientStrip blocks

* Remove FaceCameraPlane from strips

* Sanitize quad strip orientation

* Update VFX

* Update changelog

* Add error feedback

* Use IsPerspectiveProjection

* Fix GetStripTangent for lines

* Add subpixel AA to head and trails template system

* Add strip variant for intialize in menu

* Fix for errors not appearing after convert output

* Update graph version

* Fix ribbon VFX

* Fix spawnIndexInStrip (tooltip + init)

* Fix issue with inspector not triggering OnSettingChanged

* Check that a converted output could keep the same flow links.

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Revert adaeba7f20802aa19fe089463e1abfaf2a0488e6

* update vfx

* Update URP assets

* Update URP ref

* Vfx/fix/additional subgraphs 2 (#155)

* Updated Changelog

* Updated Blocks with Fixes and Missing Workflows

* update VFX additions

Co-authored-by: Thomas Iché <peeweek@gmail.com>

* Fix 1255182 Compile errors using Baked GI (default UV settings) / Output Particle Mesh / Connected Attributes (#139)

* Reindex the TEXCOORD[n]

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix serveral minor issues (#103)

Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458987790
Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988272
Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988870

* Update rebuild all script to take subgraph into account

* Update VFX assets

* Fix URP vfx assets

* *WIP graphicTest

* Renable exact fixed time option

Actual fix in progress, I'm adding a graphicTest to cover problematic behavior.

* *Update test effect

* Share same graph for both mode

TODO : Updat graphicTest frame to allow special case

* *Add settings to scale fixed time step

* *Update fixed time scene

* Fix Event connected directly to Output Event (revival) (#154)

* Add missing filter in CanLink function

* Add editor test

* *Update changelog.md

* *Update comment

* *Update Comment

* Fix regression with subgraph

* Add Subgraph_Event_Link_To_Spawn editor test

* Cover test with prewarm behavior

* Fix changelog

Add entry in the right place from 0009e5373ddd6927977fc8054e2ab16c14b5e81b

* Restore disabled 26_NonUnifomScale due to a wrong merge (need backport to 10.x.x)

* *Update 015 settings & Move force paused in testing repro

* Move 015_FixedTime to common testing package

* Add 015_FixedTime test to HDRP as well

* [HDRP] Fix debug view material (albedo/normal/...) (#163)

* Fix debug view material

TODO : Add GraphicTest

* Fix tab/space mix

* Add HDRP debug scene

* *Add reference image for HDRD_Debug(Property)

* *Update changelog.md

* Use explicitly layer zero for independant system

That's actually the way the runtime assumed

* *Add reference image (yamato & local result strictly identical)

* Force ui update when shader might be reimported in StaticMeshOutput (#158)

* Don't create VFXGraph during import callbacks (#148)

* do not Create VFXGraph in import callbacks

* error when graph missing. Better test code for asset creation

* Add the necessary openasset callback for the system to know if we open the asset inside the editor. (#118)

* Added OnOpenAssetAttributeMode.Validate

* added UNITY_2021_1

* remove the shaders has they are not edited in the editor.

* Fix macro

* Select node on create (#166)

* Select node on create

* Fix for right click in block and add doesn't deselect clicked block

* fix for subgraph not being selected on drag and drop

* Select converted node/block after convert subgraph

* Fix for selection undo separate in some cases. Fixed flow anchor drag context selection.

* Fix for undo of add subgraph operator

* “Refactor”

* "Refactor" bis (some file has been missed)

* Dont flag dirty in vfxgraph is the model modified is a copy (#165)

* Workflow improvement : Change VisualEffect inspector "Edit" button to "New" when no asset is set. (#173)

* Base Commit
* Documentation
* Updated Changelog
* Fixed Typo

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Added excludeFromTAA setting to VFX outputs (#170)

* Added excludeFromTAA setting to VFX outputs

Added excludeFromTAA setting to VFX outputs.
Currently it is only supported in HDRP suboutputs.
Required adding ${VFXStencilForward} variable to forward pass templates

* Update VFXHDRPSubOutput.cs

suport exclude from TAA in transparent only

* Added documentation to exclude from TAA property

* Graphic test

Added graphic test: 32_ExcludeFromTAA

* Update graphic test background for better contrast

* Update CHANGELOG.md

Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>

* Missing Reference image for test 32_ExcludeFromTAA

* Add test to cover case exposed by 1258022 (#54)

* Fix Custom Spawn serialization (#132)

* Allow Set Spawn Count & Set Spawn Time

TODO : List Spawn count in available variant

* Fix reference lost in m_SerializableType

No idea of implication of this :-/

* Squashed commit of the following: (retrieve fix from @tristan)

commit c24981d7dad15100eb40a92a6a9370e9ba800acd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Oct 9 17:27:57 2020 +0200

    Update message from @vlad suggestion

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757

commit a87ba182b30da7683e31a29048c9f2f3a0312927
Merge: 13b501e15863 296ffd333bcf
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Oct 9 09:25:02 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/error-at-creation

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 13b501e158634dfc98b96058723d248cd5d1f34d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Oct 9 09:24:27 2020 +0200

    *Add warning for CollisionDepthBuffer

    Update & Fix Changelog.md

commit 4bfb1e7c9874d8a9403ca5267d1e10735e52a87b
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Thu Oct 8 18:10:42 2020 +0200

    Fix for displaying error from the creation of a node.

* Add error feedback on failing custom spawner reference

* Revert "Allow Set Spawn Count & Set Spawn Time"

This reverts commit 0a6c75cc54072b831dcc56bffc3bbe04734d3324.

# Conflicts:
#	com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs

* Remove unexpected change

* *Revert change in changelog

* *WIP* add ResolveCustomCallbackInstance

Some refactor mark as "TODOPAUL"

* Clean implementation : customBehavior & comment

* *Add test to cover sanitize before modify references

* Change namespace for builtin custom spawner & sanitize

* Extend test to verify connexion

* *Update changelog.md

* Add specific error if customBehavior returns null

* Fix corner case when ScriptableObject reference has been lost

* Work but not idea with copy/past + potential leak

* Better implementation : use directly "MonoScript"

* Fix spawnerTest

* Rename "Can't found" => "Can't find"

* Fix case 1294180 : Error feedback throwing an error while changing capacity (#174)

Issue introduced with https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136
And more precisely https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136/commits/27c041da92ec89407ae775fe4c4f24681f156cb8

* [Test] Add test to cover "Thread Group Size" error (#104)

* Add test

* Add test to cover behavior from case 1271839

* Fix Preset (with exclusion) (#177)

* Trick ExcludeFromPreset

Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject.
Extend the VFXInfo is valid to filter out preset.

* Fix missing ExcludeFromPreset for subgraph

* *Update changelog

* Fix 1276602 incorrect uchar pcache import (#129)

* Base Commit

* Updated Documentation with explicit limitations.

* Fixed incorrect Merge

* Add regression Test

* Removed Test as It can't handle Exceptions thrown in Custom Importers

* Fixed value divider

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Update gradient test (#151)

* Update gradient test

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Sample Point Cache Operator (#92)

* Initial commit

* Overflow handling options for the user

* Addressing mode for overflow to the choice of the user

* Foldable to Constant value

* Update 09_PointCache.vfx

* Added reference images

* Remove float-to-integer conversion

* Put the choice of the output type in the Inspector only

* Simplify output type handling

* Sample Point cache != Attribute map => two operators

* Update Branch (error .yamato/docs/editor_pinning.png)

* Update SamplePointCache.cs

* Update 09_PointCache.vfx

* Output type set in a cogwheel

* Update 09_PointCache.vfx

* Revert "Update Branch (error .yamato/docs/editor_pinning.png)"

This reverts commit 02f6b6c993c2382bb10669edd16f7d06876a0cbc.

* Restore vfx asset

* Revert back to using generics for type handling

* Update SampleAttributeMap.cs

* Reformating + changelog

* Update 09_PointCache.vfx

* Update SamplePointCache.cs

* Refactor of AttributeFromMap using VFXExpressionSampleAttributeMap

* Merge branch 'vfx/staging' into vfx/feature/sample-point-cache

* Revert "Merge branch 'vfx/staging' into vfx/feature/sample-point-cache"

This reverts commit b4a03e182a3e106c2fabc262777615f9c3b94a7e.

* Fix point cache vfx + update HDRP vfx

* Update URP assets

* Fix changelog

* Fix Case 1223747 - NaN caused by normal bending (#181)

* Update Pass.template

* Update CHANGELOG.md

* 1293608 - Fix LPPV not working in deferred (#180)

* Enable LPPV in HDRP test project

* Fix LPPV for gbuffer pass

* Add graphics test

* Update changelog

* Fix 1290493 - Spaceship specific warnings (#176)

* Avoid implicit trucation in template + safe normalize setting

* Update CHANGELOG.md

* Added variants

* Delete conditioning on GPU evaluation + conservative safe normalize

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix incorrect compilation condition for linux build (#184)

* Fix formatting

* Update 26_NonUniformScale kind of sky : gradient instead of procedural

* Fix regression from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/176

Issue introduced at 44f497b438b46a54072721d335910bfab3e392ef : Incorrect VFXExpressionCondition
See also : https://unity.slack.com/archives/G1BTWN88Z/p1607963794139900?thread_ts=1607955907.136600&cid=G1BTWN88Z

* Disable Gradient Sky in 26_NonUniformScale & 33_LightProbe

* *Update VFX (newly introduced safeNormalize, default 0)

* Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA

* Revert "Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA"

This reverts commit ddee2e356dc7e529cad2904836fef8a688e546a8.

* 32_ExcludeFromTAA : Disable XR

* 33_LightProbe : Slighlty increase treshold from 0.0005 to 0.0006

* *Update Image Reference for D312 (mainly missing file)

* *Disable 32_ExcludeFromTAA

Instability detected.

* *Add missing D3D12 image references

* Fix GPUEvent & SubGraph (#178)

* Fix SelectionHasCompleteSystems

Detect correctly if there are dependencies due to GPUEvent (or stripAttribute)

* Add allDependenciesIncludingNotCompilable in VFXData

This helper is usefull for UI + use it in SelectionHasCompleteSystems

* Add note without change the beahvior

* Remove debug ToArray()

* [Subgraph] Prevent Pasting Context invalid subgraph (#191)

* Prevent pasting context within operator/block subgraph

* Fix case https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/191#discussion_r102007

Fix Approximate english log warning

* Update VFXPaste log message

Missing "the"

* Fix Mouse Event Binder in player (#175)

* Fix missing call to CreateVFXEventAttribute

OnValidate is only called in editor, in runtime, we should init cache data with OnEnable

* *Update changelog.md

* Add editor test to cover Safe Normalize behavior (#189)

* Vfx/docs/bugfixes (#188)

* Resolved 1272101

* Resolved 1264943

* Removed uncertainty around 'should'

* Resolved 1298031

* Added snippets file

* Resolved 1292127

* Fixed typos

* Resolved 1295296

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Texture2D Array Layout for Flipbooks (#97)

* Initial commit, working for planar primitives only

* Increased support to Cube, Decals, Meshes, Lit Planar Primitives, Lit Meshes

* Correct handling of depth pass

* Added Reference images for test

* Added graphic test / restore defaut HD Material

This reverts commit 1d8c36af255f41e515cbe3c87ea691125cd43077.

* Update Test References

* Added Tooltips, simplify input type selection

* Fix handling of Lit Mesh output

* Automatic Flipbook size for Array Layout

* Delete the flipBookSize slot when Texture2DArray is set

* More explicative Tooltip + end of flipbook blend fixed

* Update CHANGELOG.md

* Distortion Quad and Mesh output support

* Update VFXAbstractParticleHDRPLitOutput.cs

* Retrieve changelog from staging

* Added entry

* Motion Vector generation improvements (#194)

* Added VFX_FEATURE_MOTION_VECTORS_VERTS mode to store motion vector info per vertex

Optimized default motion vectors mode to store 4x3 matrix instead of 4x4.
Added mode to store each previous vertex position for quads, triangles, lines and points.
Refactor of motion vector defines.

* Motion vectors support in lines and points

* Resize buffer according to the element size

* fix points and lines when not using the optimization

* Fix motion vectors for lines

* Changes suggested in review

- Removed misplaced comment in VFXLineStripOutput
- Access VFXLineOutput useTargetOffset through GetSettingValue in VFXOutputUpdate
- Moved previous frame position calculation to the end of OutputUpdate compute
- Added 4 bytes per particle for last frame index in elementToVFXBufferMotionVector buffer
- Added noperspective when using VFX_FEATURE_MOTION_VECTORS_VERTS, through VFX_FEATURE_MOTION_VECTORS_INTERPOLATION define.
- Fixed order of verts in lineSW particles.

* Missing define rename in ParticleMeshes/PassForward.template

* Improved condition for discarding due to not enough indirect buffers

* Missing renaming of WRITE_MOTION_VECTOR_IN_FORWARD for particle lit meshes

* Spawn State documentation  (#195)

* Added Spawn State doc

* Fixed formatting

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Added what's new page and moved blocks out one level in the table of contents  (#199)

* Added what's new documentation for version 10

* Updated image and minor rewording

* Added link from what's new to node library

* Updated changelog link

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* HDRP - Fix Debug View Material (#182)

* Fix fallback (?) depth state in debug view material

Not sure about this : should double check with HDRP team

* *Update changelog

* *Updare reference image

It corresponds to the result in 7.x.x & 8.x.x

* *Apply reformat

* *Apply reformat (bis)

* Fix CameraFade for shadows (#179)

* Fix CameraFade for shadows

+CameraFade was taking the distance to the light when rendering the shadow map.
+Added setting to optionally affect shadow, with warning for multiple cameras
+Implemented functions to get camera position and direction

* Update CHANGELOG.md

* Update CameraFade.cs

-Change fade default value to false.
-Fix behaviour when affect shadows is false

* Update documentation

Added Affect shadows setting

* Update documentation

Modified AffectShadows setting description following @lewisjordan suggestions

* Move camera functions to VFXCommonOutput

* Remove ${VFXFragmentCommonFunctions}

${VFXFragmentCommonFunctions} was used only for the VFXCommonOutput.hlsl include, which is now generated by VFXCodeGenerator as part of ${VFXPerPassInclude}

* Correct Sign operator node output for float when input is 0.0f (#190)

* Changed specialization for floats to be consistent with others.

* Update CHANGELOG.md

* Update test

* changed sky, emission scale, and updated references (#203)

* Fix ProcessOperatorSign test

Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/190 & this change 1d6e19db547ca6a79f75c839825e15943fde6288

* Allow remaking an existing link. (#146)

* Allow remaking an existing link.

* Update CHANGELOG.md

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

* ShaderGraph loosing reference while updating (sync with 7.x.x) (#185)

* Use explicit GetOrRefreshShaderGraphObject & always lazy init the shadeGraph access.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/VFXGraph/Outputs/VFXAbstractParticleHDRPLitOutput.cs
#	com.unity.visualeffectgraph/Editor/Models/Contexts/Implementations/VFXMeshOutput.cs
#	com.unity.visualeffectgraph/Editor/Models/VFXGraph.cs
#	com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphParticleOutput.cs
#	com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphPostProcessor.cs

* Fix shaderGraph not listed in VFXModel

This is actually an issue in VFXModel.GetSettings, we don't have any cases like this where the parent value is private.

* Update changelog.md

Same entry than https://github.com/Unity-Technologies/Graphics/pull/2873/

* Removing changelog entry

The actual fix was already there, this code is only a synchronisation with 7.x.x & prior version.

* *Minimal test to check actual content of modified property after an override (#171)

* Add test to cover behavior from https://fogbugz.unity3d.com/f/cases/1122404/ (#196)

* *Updating reference image for D3D12

Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/182

* Force re-apply formatting

* Fix ordering for "+" button in blackboard (#197)

* Add test to cover behavior of https://fogbugz.unity3d.com/f/cases/1300115/ (#192)

* Fix changelog.md (new entries should be in 12.0.)

* *Update changelog.md (unexpected diff in 11.x.x)

* [Fix Case 1221557] Checkbox Age Particles consistency (#202)

* Provides consistent behavior with Add Age and Set Age

* Update Changelog

* update changelog

* Add _CameraViewMatrix shader variable (#208)

Add _CameraViewMatrix shader variable in HDRP, instead of using legacy unity_CameraToWorld.
Remove functions using unity_CameraToWorld from VFXCommonOutput.hlsl and move to SRP specific VFXCommon.hlsl files

* Fix compute culling compilation in URP (case 1309174) (#210)

* Add GeometricTools.hlsl include

Missing include containing DistanceFromPlane function used by IsSphereOutsideFrustum

* Update changelog

* [pCache] Fix minor UX issues (#207)

* Disable mesh statistic field

* Fix cancel while save texture

* Fix create pCache from unreadable texture

* *Update changelog.md

* Fix missing disable for Texture Statistics

* Disable motion vector per vertex optimization (#214)

Temporarily disable motion vector per vertex optimization.
Small refactor for vertex count calculation

* Fallback for camera buffers from Main camera (#200)

* Add setting for main camera buffer fallback

* Move enum to C++

* Update changelog

* Rename setting to Main Camera fallback and the option "None" to "No fallback"

* Added an entry for Main Camera feedback in the preferences doc.

* Updated tooltip

* Reworded tooltip and doc entry

* Added doc entry for User Systems.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* [VCS] Handle correctly locked asset (#193)

* Prelimary refactor : gather IsAssetEditable in common test to ease testing

* Move always m_LockedElement in front

* Fix inspector of slot container when asset is locked

* Fix inspector for VFXManager when asset is locked

* *Update changelog.md

* Fix incorrect cast in VFXSlotContainerEditor

* Use m_LockedElement in blackboard & redirect it when needed

Simplify integration from m_ComponentBoard

* Fix case 1243947 : Debug View artefact

Correctly clear the VFXDebugView while reassigning

* *Update changelog.md

* Let selection passing through locked label : it allows inspection

* Fix locked label in blackboard when empty

* Fix "Shader Value is not saved when switching between VFX Manager and Version Control"

* Prevent Drag&Drop when asset is locked

* Prevent tricky way to instantiate BuildContextualMenu

There was an issue while clicking on left & right at the same time

* Fix two issue with target

- Attach a stopped visualEffect component
- Stop & Reset behavior

* Fix UpdateDebugMode which could be called too soon

In the case of an not yet loaded VisualEffect component (because the VFXGraph has been just recompiled)

* Fix ordering

We want the "asset locked" just after contentViewContainer and not just before m_ComponentBoard

* Update maxAlive state checking the actual IsAssetEditable during update

* Fix locked issue with the VFXParameterEditor

Should disable everything if IsAssetEditable returns false

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/193#discussion_r109552

blackboard => componentBoard

* Mesh Index & Skinned (#30)

* Squashed commit of the following:

commit f51b7d616b77487339b2ec3db1e2e8bee35b3ae1
Merge: 2589034c08 229945b992
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Apr 6 17:32:10 2020 +0200

    Merge branch 'vfx/feature/mesh-sampling-support-texcoord-dimension' into vfx/feature/mesh-sampling-index-buffer

commit 229945b99247402006916c9c73a640d2b5662486
Merge: d26b342644 4cd4cb244d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Apr 6 17:31:23 2020 +0200

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 2589034c088795ba63bf61f22e8ba84a7ffe7607
Merge: 47e04162e6 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:24:43 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling-index-buffer

commit 47e04162e60683e331c930a02e77f6d5eeae568e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:18:43 2020 +0200

    Minor : add a TODO

commit a7bd11748549e25789e7515c50b1c3d96499301b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:17:32 2020 +0200

    Actually, keep minimal scope for VFX_GENERIC_BUFFER, it's useful for platform testing purpose.

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 0f9fc14afb9e6e8666b39860bd84922eba4a64e5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 16:49:52 2020 +0200

    Remove temporary code

commit bc8121349789de632d1115a7804a17b882559e1b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 16:02:23 2020 +0200

    Choose StructuredBuffer<float> over ByteAddressBuffer

commit 21b9d002b29b9887da8661f32505973e75d0420f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 30 17:16:37 2020 +0200

    Change Buffer<uint> to Buffer<float> to avoid dx warning issue.

commit be691cd625a18194c5662de17c952613b4f591e3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sun Mar 29 19:06:25 2020 +0200

    Fix alignement for ByteAddressBuffer

commit 3ec05dfadefc483507d3de12caf4a2e216af6e66
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sun Mar 29 17:58:05 2020 +0200

    WIP : Trying to move to ByteAddressBuffer

commit 2cf1db8679851ff55afcd5f17afa8a52b4d9e179
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 18:06:49 2020 +0100

    add note for later

commit e6fd7c1931919c657b7c65f8197be03e387e56dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 17:44:24 2020 +0100

    *Draft test data (will be removed)

commit c84f0e927ebe00f655d3fb92bbe98d6c03fdcf34
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 17:16:12 2020 +0100

    Fix expressionMesh format

commit 6f48ffbdb55f38da5750f63fc1a38d79a5d19800
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 15:01:01 2020 +0100

    Update draft test

commit edec8e1e997188e0dbc82ad9bb38e0ac178476d2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 15:00:41 2020 +0100

    Sample Index *WIP*

commit 2853d8b25eabd0dcf3f5af4718d71f17685d5a7b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 15:54:29 2020 +0100

    *Remove End expression for mesh evaluation (invalid because we can't guess context for this case)

commit d4f09e0cc4c058d07a2c40366e4e0bd45476d7fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 12:00:30 2020 +0100

    Add minimal integration for newly added VFXExpressionVertexBufferFromMesh

commit baf39dcdf6fc340269fb5442c763e4932ead57f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 11:59:25 2020 +0100

    Add test data (to revert)

commit 7a2fd0337ecc965dcea105dfd34973499f736bb8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 11:58:53 2020 +0100

    Revert "Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh"

    This reverts commit 6d507a684f14dc09641877d6d691fd96adb63be4.

commit 6d507a684f14dc09641877d6d691fd96adb63be4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 11:56:51 2020 +0100

    Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh

commit d26b342644bc08c2ab4118a71899bb78a2c303a7
Merge: b1512335cb 40749ce2ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 09:27:26 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit b1512335cb09b7b3e1ee783f991347704c4952be
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 18:24:05 2020 +0100

    Fix after merge

commit 43e25995ca9a15aa0ee5c88297616ccbd3fc5c2d
Merge: e357f4871b 7abaf9bbf2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 17:47:34 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionMesh.cs

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit e357f4871b8c39257c62daf1fe63f85241325712
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 25 08:56:53 2020 +0100

    Fix build in 2020.1 to resolve comment https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/258#pullrequestreview-52608

commit bfc0d9f7aeaa8b34407bfa8279d30bf59cf55099
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 18:44:28 2020 +0100

    *Fix compilation

commit 6cfd2d90292796c5b21e63d01c4b4bf8563c0184
Merge: 41a1a8e212 128101bc63
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 14:56:22 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 41a1a8e212c82b48832ab88f68348c145c0960c6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 15:19:24 2020 +0100

    *Update expression name

commit 27794064fd01207a35e7d967ff322e9d552a2054
Merge: ad597a0388 28f0ca20a0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 10:21:38 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit ad597a03881e11743e68555f985c304ee2d7557d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:18:40 2020 +0100

    Support float or uint read in sample mesh color

commit 8ca98dd9a375431ddc04c7a0cb625c35a2c99f57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 10:05:40 2020 +0100

    Add compatibility code & use new available expression from https://ono.unity3d.com/unity/unity/changeset/6afd1f99b768984023366f3aba746390c763432f

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player referenc…
PaulDemeulenaere added a commit that referenced this pull request May 17, 2021
@PaulDemeulenaere @julienf-unity
@iTris666 @peeweek @ludovic-theobald @gabrieldelacruz @JordanL8
[VFX] Direct Link Event & Multiple Per Frame (#4457)
405f572 
* More changelog fixes

* Add missing warning for other block operator using depth (#140)

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#discussion_r79026

* *Adding missing meta file in TestProject

* Missing doc & Deprecate VFXViewModicationProcessor (#143)

* Fix missing doc & Deprecate VFXViewModicationProcessor

Unexpected public API

* *Revert unexpected change

* Fix several issue from @lewisjordan

- fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/143#discussion_r79397
- fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/143#discussion_r79398

* Fix Several issue in Property Binder (#106)

* Fix case 1274790 : Use DestroyImmediate when editor isn't playing

* Fix case 1247230 : Avoid null exposed property

Property entry is modified by UX always not null, however, it requires a default value

* Fix case 1274788 : Missing null check in Hierarchy to Attribute Map

* Fix case 1248711 : Property window view wasn't working

Missing Update, it also fixes Undo/Redo

* *Update changelog

* Fix compilation when ENABLE_LEGACY_INPUT_MANAGER isn't enabled

Should be fix for 10.2

* Fix case 1279471 : Avoid OnMouseDown/Up/... declaration

Game scripts or other custom code contains OnMouse_ event handlers. Presence of such handlers might impact performance on handheld devices." when building for Android/IOS

* Fix positionDepthOperator ref images

* Add one pixel to height in non wide mode so that margin is equal to wide mode. (#145)

* Update CHANGELOG.md

* Fix API validation

* Harmonize Composition in Position / Velocity Blocks (#44)

* Base refactor + Attempt to get position from AABox (not working for thickness ATM)

* Fixed cone syntax issues + correct computation of AABox direction

* Added Variant providers + Composition in Sequential

* Updated Variants for Shape Sequential Blocks

* Harmonized Namings + added composition to Position Depth

* Updated Changelog

* Fixes for PR

* Fixed Blend Composition in Sequential

* Added Direction to PositionSequential

* Fixes in Position Circle / Set Blend factor in shapes to 1.0 by default

* Used Absolute Box size as expression

* Propal for https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44/files/e029bb9ec37555e70af21a97399774667030c031#r61533

Use case by case approach for direction of AABox

* *Temp add test data for graphicTest

* Fix ApplyAddressingMode : clamp & mirror was overflowing, mirror has also a wrong pattern

* Edit graphicTest

* Move 014 to common package

* Add 014_PositionBlock in editor test listing

* Precompute line_direction in PositionLine

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44/files#r67908

* *Add reference images

* Fix editor test (wrong reference data)

* Fix issue introduced at 9c54056a68e9ef90354e969e9baba18aa552f8f4 : Looping correctly the circle

See also : https://unity.slack.com/archives/G1BTWN88Z/p1598508170069200?thread_ts=1598429838.039200&cid=G1BTWN88Z

* Probably uploaded the wrong image reference for standalone

* *Update reference images (I think I mess up twice, I should double check the change in motionVector)

* Fix build (VFXExpressionCondition now supports uint)

* *Temp* Delete motion vector reference image, should regenerate them from yamato.

* Readd reference image using yamato result at b9a04b7424323e0c3801e34c13213c4050f020f1

* *Update changelog

Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44#discussion_r70582

* Fix PositionTorus when used in vertex shader

* Fix multiple definition of UNITY_PI

* Fix changelog

bad automatic merge

* Fix incorrect volume

Base radius while computing volume factor on sphere & circle : use fix approach from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/89 using name instead of index
See : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44#issuecomment-28990 & https://docs.google.com/document/d/1RAVkfmMQA9D_hKkJyt6PKOgRs8JHkjlYRhcfBtIU1Ag/edit?disco=AAAAJ7Z4S18

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>
Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>
Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix 1285603 View and Object mode of Shadergraph position node don't return proper values (#141)

* Update VFXShaderGraphParticleOutput.cs

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix collapse exception and added automated test (#149)

* Misc fixes for vfx shadergraph integrations  (#130)

* Diffusion profile has PropertyType.Float but isn't castable in Vector1ShaderProperty : safeprof code

* Unity serialization produced a beast with object.ReferenceEquals(null) != 0 and instanceID == 0 foolProof code for this

* Update CHANGELOG.md

* Small fix for collapse test

* Some extra security around error feedback (#153)

* Prevent exceptions from making notification stay. Prevent exception in errors to potential break the ui

* Prevent list from being badly deserialized.

* Fix Event connected directly to Output Event (#152)

* Add missing filter in CanLink function

* Add editor test

* *Update changelog.md

* *Update comment

* *Update Comment

* Misc fixes in strips (#136)

* Vfx/feature/strips improvements (#265)

* Add spanwIndexInStrip attribute

* Fix particleCountInStrip in Init

* Add OrientStrip block

* Remove some useless code

* Add From Target Position mode in Orient Strip

* Update changelog

* Fix SpawnOverDistance

* Fix reference images

* Fix changelog

* Merge Orient and OrientStrip blocks

* Remove FaceCameraPlane from strips

* Sanitize quad strip orientation

* Update VFX

* Update changelog

* Add error feedback

* Use IsPerspectiveProjection

* Fix GetStripTangent for lines

* Add subpixel AA to head and trails template system

* Add strip variant for intialize in menu

* Fix for errors not appearing after convert output

* Update graph version

* Fix ribbon VFX

* Fix spawnIndexInStrip (tooltip + init)

* Fix issue with inspector not triggering OnSettingChanged

* Check that a converted output could keep the same flow links.

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Revert adaeba7f20802aa19fe089463e1abfaf2a0488e6

* update vfx

* Update URP assets

* Update URP ref

* Vfx/fix/additional subgraphs 2 (#155)

* Updated Changelog

* Updated Blocks with Fixes and Missing Workflows

* update VFX additions

Co-authored-by: Thomas Iché <peeweek@gmail.com>

* Fix 1255182 Compile errors using Baked GI (default UV settings) / Output Particle Mesh / Connected Attributes (#139)

* Reindex the TEXCOORD[n]

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix serveral minor issues (#103)

Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458987790
Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988272
Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988870

* Update rebuild all script to take subgraph into account

* Update VFX assets

* Fix URP vfx assets

* Allow Set Spawn Count & Set Spawn Time

TODO : List Spawn count in available variant

# Conflicts:
#	com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs

* Add comment

* Add explicit attribute SpawnCount

Remove also some dead code, remove hack since we have now a reachable spawnCount attribute

* Fix potential issue : spawnCount supposed to be first in all eventAttribute

* Fix incorrect spawner ordering *WIP*

* Missing *important* change

* Add spawner test to cover behavior of CollectSpawnersHierarchy

* *Commit temp data, I wil remove them before starting the PR

I would like to test/check the sanitize manually

* Move Get Spawn Count to deprecated

* *Move old attribute to "deprecated" folder

* Sanitize GetSpawnCount using VFXAttributeParameter & VFXInlineOperator

* Remove test data

* Add set spawn test

* Fix unexpected exception since globalAttribute can be empty if there isn't any spawner linked

* Minor : update comment

* *Update changelog

* Minor update in changelog.md

* Remove unexpected expcept with leads to incorrect depth count

* *Update expected reference image changes

* Remove TODOPAUL

* Fix Event connected directly to Output Event (revival) (#154)

* Add missing filter in CanLink function

* Add editor test

* *Update changelog.md

* *Update comment

* *Update Comment

* Fix regression with subgraph

* Add Subgraph_Event_Link_To_Spawn editor test

* spawnCount & spawnTime can be stored per attribute

Use specific exception for set spawn event attribute.

* Fix changelog

Add entry in the right place from 0009e5373ddd6927977fc8054e2ab16c14b5e81b

* Restore disabled 26_NonUnifomScale due to a wrong merge (need backport to 10.x.x)

* [HDRP] Fix debug view material (albedo/normal/...) (#163)

* Fix debug view material

TODO : Add GraphicTest

* Fix tab/space mix

* Add HDRP debug scene

* *Add reference image for HDRD_Debug(Property)

* *Update changelog.md

* Force ui update when shader might be reimported in StaticMeshOutput (#158)

* Don't create VFXGraph during import callbacks (#148)

* do not Create VFXGraph in import callbacks

* error when graph missing. Better test code for asset creation

* Add the necessary openasset callback for the system to know if we open the asset inside the editor. (#118)

* Added OnOpenAssetAttributeMode.Validate

* added UNITY_2021_1

* remove the shaders has they are not edited in the editor.

* Fix macro

* Select node on create (#166)

* Select node on create

* Fix for right click in block and add doesn't deselect clicked block

* fix for subgraph not being selected on drag and drop

* Select converted node/block after convert subgraph

* Fix for selection undo separate in some cases. Fixed flow anchor drag context selection.

* Fix for undo of add subgraph operator

* “Refactor”

* "Refactor" bis (some file has been missed)

* Dont flag dirty in vfxgraph is the model modified is a copy (#165)

* *Apply formatting on branch

* Workflow improvement : Change VisualEffect inspector "Edit" button to "New" when no asset is set. (#173)

* Base Commit
* Documentation
* Updated Changelog
* Fixed Typo

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Added excludeFromTAA setting to VFX outputs (#170)

* Added excludeFromTAA setting to VFX outputs

Added excludeFromTAA setting to VFX outputs.
Currently it is only supported in HDRP suboutputs.
Required adding ${VFXStencilForward} variable to forward pass templates

* Update VFXHDRPSubOutput.cs

suport exclude from TAA in transparent only

* Added documentation to exclude from TAA property

* Graphic test

Added graphic test: 32_ExcludeFromTAA

* Update graphic test background for better contrast

* Update CHANGELOG.md

Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>

* Missing Reference image for test 32_ExcludeFromTAA

* Add test to cover case exposed by 1258022 (#54)

* Fix Custom Spawn serialization (#132)

* Allow Set Spawn Count & Set Spawn Time

TODO : List Spawn count in available variant

* Fix reference lost in m_SerializableType

No idea of implication of this :-/

* Squashed commit of the following: (retrieve fix from @tristan)

commit c24981d7dad15100eb40a92a6a9370e9ba800acd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Oct 9 17:27:57 2020 +0200

    Update message from @vlad suggestion

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757

commit a87ba182b30da7683e31a29048c9f2f3a0312927
Merge: 13b501e15863 296ffd333bcf
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Oct 9 09:25:02 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/error-at-creation

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 13b501e158634dfc98b96058723d248cd5d1f34d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Oct 9 09:24:27 2020 +0200

    *Add warning for CollisionDepthBuffer

    Update & Fix Changelog.md

commit 4bfb1e7c9874d8a9403ca5267d1e10735e52a87b
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Thu Oct 8 18:10:42 2020 +0200

    Fix for displaying error from the creation of a node.

* Add error feedback on failing custom spawner reference

* Revert "Allow Set Spawn Count & Set Spawn Time"

This reverts commit 0a6c75cc54072b831dcc56bffc3bbe04734d3324.

# Conflicts:
#	com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs

* Remove unexpected change

* *Revert change in changelog

* *WIP* add ResolveCustomCallbackInstance

Some refactor mark as "TODOPAUL"

* Clean implementation : customBehavior & comment

* *Add test to cover sanitize before modify references

* Change namespace for builtin custom spawner & sanitize

* Extend test to verify connexion

* *Update changelog.md

* Add specific error if customBehavior returns null

* Fix corner case when ScriptableObject reference has been lost

* Work but not idea with copy/past + potential leak

* Better implementation : use directly "MonoScript"

* Fix spawnerTest

* Rename "Can't found" => "Can't find"

* Fix case 1294180 : Error feedback throwing an error while changing capacity (#174)

Issue introduced with https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136
And more precisely https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136/commits/27c041da92ec89407ae775fe4c4f24681f156cb8

* [Test] Add test to cover "Thread Group Size" error (#104)

* Add test

* Add test to cover behavior from case 1271839

* Fix Preset (with exclusion) (#177)

* Trick ExcludeFromPreset

Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject.
Extend the VFXInfo is valid to filter out preset.

* Fix missing ExcludeFromPreset for subgraph

* *Update changelog

* Fix 1276602 incorrect uchar pcache import (#129)

* Base Commit

* Updated Documentation with explicit limitations.

* Fixed incorrect Merge

* Add regression Test

* Removed Test as It can't handle Exceptions thrown in Custom Importers

* Fixed value divider

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Update gradient test (#151)

* Update gradient test

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Sample Point Cache Operator (#92)

* Initial commit

* Overflow handling options for the user

* Addressing mode for overflow to the choice of the user

* Foldable to Constant value

* Update 09_PointCache.vfx

* Added reference images

* Remove float-to-integer conversion

* Put the choice of the output type in the Inspector only

* Simplify output type handling

* Sample Point cache != Attribute map => two operators

* Update Branch (error .yamato/docs/editor_pinning.png)

* Update SamplePointCache.cs

* Update 09_PointCache.vfx

* Output type set in a cogwheel

* Update 09_PointCache.vfx

* Revert "Update Branch (error .yamato/docs/editor_pinning.png)"

This reverts commit 02f6b6c993c2382bb10669edd16f7d06876a0cbc.

* Restore vfx asset

* Revert back to using generics for type handling

* Update SampleAttributeMap.cs

* Reformating + changelog

* Update 09_PointCache.vfx

* Update SamplePointCache.cs

* Refactor of AttributeFromMap using VFXExpressionSampleAttributeMap

* Merge branch 'vfx/staging' into vfx/feature/sample-point-cache

* Revert "Merge branch 'vfx/staging' into vfx/feature/sample-point-cache"

This reverts commit b4a03e182a3e106c2fabc262777615f9c3b94a7e.

* Fix point cache vfx + update HDRP vfx

* Update URP assets

* Fix changelog

* Fix Case 1223747 - NaN caused by normal bending (#181)

* Update Pass.template

* Update CHANGELOG.md

* 1293608 - Fix LPPV not working in deferred (#180)

* Enable LPPV in HDRP test project

* Fix LPPV for gbuffer pass

* Add graphics test

* Update changelog

* Fix 1290493 - Spaceship specific warnings (#176)

* Avoid implicit trucation in template + safe normalize setting

* Update CHANGELOG.md

* Added variants

* Delete conditioning on GPU evaluation + conservative safe normalize

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix incorrect compilation condition for linux build (#184)

* Fix formatting

* Update 26_NonUniformScale kind of sky : gradient instead of procedural

* Fix regression from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/176

Issue introduced at 44f497b438b46a54072721d335910bfab3e392ef : Incorrect VFXExpressionCondition
See also : https://unity.slack.com/archives/G1BTWN88Z/p1607963794139900?thread_ts=1607955907.136600&cid=G1BTWN88Z

* Disable Gradient Sky in 26_NonUniformScale & 33_LightProbe

* *Update VFX (newly introduced safeNormalize, default 0)

* Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA

* Revert "Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA"

This reverts commit ddee2e356dc7e529cad2904836fef8a688e546a8.

* 32_ExcludeFromTAA : Disable XR

* 33_LightProbe : Slighlty increase treshold from 0.0005 to 0.0006

* *Update Image Reference for D312 (mainly missing file)

* *Disable 32_ExcludeFromTAA

Instability detected.

* *Add missing D3D12 image references

* Fix GPUEvent & SubGraph (#178)

* Fix SelectionHasCompleteSystems

Detect correctly if there are dependencies due to GPUEvent (or stripAttribute)

* Add allDependenciesIncludingNotCompilable in VFXData

This helper is usefull for UI + use it in SelectionHasCompleteSystems

* Add note without change the beahvior

* Remove debug ToArray()

* [Subgraph] Prevent Pasting Context invalid subgraph (#191)

* Prevent pasting context within operator/block subgraph

* Fix case https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/191#discussion_r102007

Fix Approximate english log warning

* Update VFXPaste log message

Missing "the"

* Fix Mouse Event Binder in player (#175)

* Fix missing call to CreateVFXEventAttribute

OnValidate is only called in editor, in runtime, we should init cache data with OnEnable

* *Update changelog.md

* Remove the direct link to initialize constraint

* Add initSystems collection from event link

* Add editor test to cover Safe Normalize behavior (#189)

* Draft of specific code to handle dynamic source spawn event

* - Change default SpawnCount value to 1.0f (it will be more consistent & ease debug)

* Fix incorrect systemIndex computation

* Vfx/docs/bugfixes (#188)

* Resolved 1272101

* Resolved 1264943

* Removed uncertainty around 'should'

* Resolved 1298031

* Added snippets file

* Resolved 1292127

* Fixed typos

* Resolved 1295296

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix incorrect indexOfData (sill *wip*)

* *Commit test data (to remove)

* Texture2D Array Layout for Flipbooks (#97)

* Initial commit, working for planar primitives only

* Increased support to Cube, Decals, Meshes, Lit Planar Primitives, Lit Meshes

* Correct handling of depth pass

* Added Reference images for test

* Added graphic test / restore defaut HD Material

This reverts commit 1d8c36af255f41e515cbe3c87ea691125cd43077.

* Update Test References

* Added Tooltips, simplify input type selection

* Fix handling of Lit Mesh output

* Automatic Flipbook size for Array Layout

* Delete the flipBookSize slot when Texture2DArray is set

* More explicative Tooltip + end of flipbook blend fixed

* Update CHANGELOG.md

* Distortion Quad and Mesh output support

* Update VFXAbstractParticleHDRPLitOutput.cs

* Retrieve changelog from staging

* Added entry

* Motion Vector generation improvements (#194)

* Added VFX_FEATURE_MOTION_VECTORS_VERTS mode to store motion vector info per vertex

Optimized default motion vectors mode to store 4x3 matrix instead of 4x4.
Added mode to store each previous vertex position for quads, triangles, lines and points.
Refactor of motion vector defines.

* Motion vectors support in lines and points

* Resize buffer according to the element size

* fix points and lines when not using the optimization

* Fix motion vectors for lines

* Changes suggested in review

- Removed misplaced comment in VFXLineStripOutput
- Access VFXLineOutput useTargetOffset through GetSettingValue in VFXOutputUpdate
- Moved previous frame position calculation to the end of OutputUpdate compute
- Added 4 bytes per particle for last frame index in elementToVFXBufferMotionVector buffer
- Added noperspective when using VFX_FEATURE_MOTION_VECTORS_VERTS, through VFX_FEATURE_MOTION_VECTORS_INTERPOLATION define.
- Fixed order of verts in lineSW particles.

* Missing define rename in ParticleMeshes/PassForward.template

* Improved condition for discarding due to not enough indirect buffers

* Missing renaming of WRITE_MOTION_VECTOR_IN_FORWARD for particle lit meshes

* Spawn State documentation  (#195)

* Added Spawn State doc

* Fixed formatting

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Added what's new page and moved blocks out one level in the table of contents  (#199)

* Added what's new documentation for version 10

* Updated image and minor rewording

* Added link from what's new to node library

* Updated changelog link

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* HDRP - Fix Debug View Material (#182)

* Fix fallback (?) depth state in debug view material

Not sure about this : should double check with HDRP team

* *Update changelog

* *Updare reference image

It corresponds to the result in 7.x.x & 8.x.x

* *Apply reformat

* *Apply reformat (bis)

* Fix CameraFade for shadows (#179)

* Fix CameraFade for shadows

+CameraFade was taking the distance to the light when rendering the shadow map.
+Added setting to optionally affect shadow, with warning for multiple cameras
+Implemented functions to get camera position and direction

* Update CHANGELOG.md

* Update CameraFade.cs

-Change fade default value to false.
-Fix behaviour when affect shadows is false

* Update documentation

Added Affect shadows setting

* Update documentation

Modified AffectShadows setting description following @lewisjordan suggestions

* Move camera functions to VFXCommonOutput

* Remove ${VFXFragmentCommonFunctions}

${VFXFragmentCommonFunctions} was used only for the VFXCommonOutput.hlsl include, which is now generated by VFXCodeGenerator as part of ${VFXPerPassInclude}

* Correct Sign operator node output for float when input is 0.0f (#190)

* Changed specialization for floats to be consistent with others.

* Update CHANGELOG.md

* Update test

* changed sky, emission scale, and updated references (#203)

* Fix ProcessOperatorSign test

Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/190 & this change 1d6e19db547ca6a79f75c839825e15943fde6288

* Allow remaking an existing link. (#146)

* Allow remaking an existing link.

* Update CHANGELOG.md

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

* ShaderGraph loosing reference while updating (sync with 7.x.x) (#185)

* Use explicit GetOrRefreshShaderGraphObject & always lazy init the shadeGraph access.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/VFXGraph/Outputs/VFXAbstractParticleHDRPLitOutput.cs
#	com.unity.visualeffectgraph/Editor/Models/Contexts/Implementations/VFXMeshOutput.cs
#	com.unity.visualeffectgraph/Editor/Models/VFXGraph.cs
#	com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphParticleOutput.cs
#	com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphPostProcessor.cs

* Fix shaderGraph not listed in VFXModel

This is actually an issue in VFXModel.GetSettings, we don't have any cases like this where the parent value is private.

* Update changelog.md

Same entry than https://github.com/Unity-Technologies/Graphics/pull/2873/

* Removing changelog entry

The actual fix was already there, this code is only a synchronisation with 7.x.x & prior version.

* *Minimal test to check actual content of modified property after an override (#171)

* Add test to cover behavior from https://fogbugz.unity3d.com/f/cases/1122404/ (#196)

* *Updating reference image for D3D12

Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/182

* *Extend test

* More consistent behavior : always list spawnCount first (before any other attributes)

* More consistent behavior : always list spawnCount first (before any other attributes)

* Fix source of attribute : event should also be considered

* Force re-apply formatting

* Fix ordering for "+" button in blackboard (#197)

* Add test to cover behavior of https://fogbugz.unity3d.com/f/cases/1300115/ (#192)

* Fix changelog.md (new entries should be in 12.0.)

* *Update changelog.md (unexpected diff in 11.x.x)

* [Fix Case 1221557] Checkbox Age Particles consistency (#202)

* Provides consistent behavior with Add Age and Set Age

* Update Changelog

* update changelog

* Add _CameraViewMatrix shader variable (#208)

Add _CameraViewMatrix shader variable in HDRP, instead of using legacy unity_CameraToWorld.
Remove functions using unity_CameraToWorld from VFXCommonOutput.hlsl and move to SRP specific VFXCommon.hlsl files

* Fix compute culling compilation in URP (case 1309174) (#210)

* Add GeometricTools.hlsl include

Missing include containing DistanceFromPlane function used by IsSphereOutsideFrustum

* Update changelog

* *Proper test (ready to be shared with HDRP project)

* *Reduce m_SourceCount to minimal value

* HotFix for source code generator

* Remove the 0 size buffer constraint for sourceAttributeBuffer of initialize

* [pCache] Fix minor UX issues (#207)

* Disable mesh statistic field

* Fix cancel while save texture

* Fix create pCache from unreadable texture

* *Update changelog.md

* Fix missing disable for Texture Statistics

* Disable motion vector per vertex optimization (#214)

Temporarily disable motion vector per vertex optimization.
Small refactor for vertex count calculation

* Fallback for camera buffers from Main camera (#200)

* Add setting for main camera buffer fallback

* Move enum to C++

* Update changelog

* Rename setting to Main Camera fallback and the option "None" to "No fallback"

* Added an entry for Main Camera feedback in the preferences doc.

* Updated tooltip

* Reworded tooltip and doc entry

* Added doc entry for User Systems.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* [VCS] Handle correctly locked asset (#193)

* Prelimary refactor : gather IsAssetEditable in common test to ease testing

* Move always m_LockedElement in front

* Fix inspector of slot container when asset is locked

* Fix inspector for VFXManager when asset is locked

* *Update changelog.md

* Fix incorrect cast in VFXSlotContainerEditor

* Use m_LockedElement in blackboard & redirect it when needed

Simplify integration from m_ComponentBoard

* Fix case 1243947 : Debug View artefact

Correctly clear the VFXDebugView while reassigning

* *Update changelog.md

* Let selection passing through locked label : it allows inspection

* Fix locked label in blackboard when empty

* Fix "Shader Value is not saved when switching between VFX Manager and Version Control"

* Prevent Drag&Drop when asset is locked

* Prevent tricky way to instantiate BuildContextualMenu

There was an issue while clicking on left & right at the same time

* Fix two issue with target

- Attach a stopped visualEffect component
- Stop & Reset behavior

* Fix UpdateDebugMode which could be called too soon

In the case of an not yet loaded VisualEffect component (because the VFXGraph has been just recompiled)

* Fix ordering

We want the "asset locked" just after contentViewContainer and not just before m_ComponentBoard

* Update maxAlive state checking the actual IsAssetEditable during update

* Fix locked issue with the VFXParameterEditor

Should disable everything if IsAssetEditable returns false

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/193#discussion_r109552

blackboard => componentBoard

* Mesh Index & Skinned (#30)

* Squashed commit of the following:

commit f51b7d616b77487339b2ec3db1e2e8bee35b3ae1
Merge: 2589034c08 229945b992
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Apr 6 17:32:10 2020 +0200

    Merge branch 'vfx/feature/mesh-sampling-support-texcoord-dimension' into vfx/feature/mesh-sampling-index-buffer

commit 229945b99247402006916c9c73a640d2b5662486
Merge: d26b342644 4cd4cb244d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Apr 6 17:31:23 2020 +0200

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 2589034c088795ba63bf61f22e8ba84a7ffe7607
Merge: 47e04162e6 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:24:43 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling-index-buffer

commit 47e04162e60683e331c930a02e77f6d5eeae568e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:18:43 2020 +0200

    Minor : add a TODO

commit a7bd11748549e25789e7515c50b1c3d96499301b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:17:32 2020 +0200

    Actually, keep minimal scope for VFX_GENERIC_BUFFER, it's useful for platform testing purpose.

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 0f9fc14afb9e6e8666b39860bd84922eba4a64e5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 16:49:52 2020 +0200

    Remove temporary code

commit bc8121349789de632d1115a7804a17b882559e1b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 16:02:23 2020 +0200

    Choose StructuredBuffer<float> over ByteAddressBuffer

commit 21b9d002b29b9887da8661f32505973e75d0420f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 30 17:16:37 2020 +0200

    Change Buffer<uint> to Buffer<float> to avoid dx warning issue.

commit be691cd625a18194c5662de17c952613b4f591e3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sun Mar 29 19:06:25 2020 +0200

    Fix alignement for ByteAddressBuffer

commit 3ec05dfadefc483507d3de12caf4a2e216af6e66
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sun Mar 29 17:58:05 2020 +0200

    WIP : Trying to move to ByteAddressBuffer

commit 2cf1db8679851ff55afcd5f17afa8a52b4d9e179
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 18:06:49 2020 +0100

    add note for later

commit e6fd7c1931919c657b7c65f8197be03e387e56dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 17:44:24 2020 +0100

    *Draft test data (will be removed)

commit c84f0e927ebe00f655d3fb92bbe98d6c03fdcf34
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 17:16:12 2020 +0100

    Fix expressionMesh format

commit 6f48ffbdb55f38da5750f63fc1a38d79a5d19800
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 15:01:01 2020 +0100

    Update draft test

commit edec8e1e997188e0dbc82ad9bb38e0ac178476d2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 15:00:41 2020 +0100

    Sample Index *WIP*

commit 2853d8b25eabd0dcf3f5af4718d71f17685d5a7b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 15:54:29 2020 +0100

    *Remove End expression for mesh evaluation (invalid because we can't guess context for this case)

commit d4f09e0cc4c058d07a2c40366e4e0bd45476d7fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 12:00:30 2020 +0100

    Add minimal integration for newly added VFXExpressionVertexBufferFromMesh

commit baf39dcdf6fc340269fb5442c763e4932ead57f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 11:59:25 2020 +0100

    Add test data (to revert)

commit 7a2fd0337ecc965dcea105dfd34973499f736bb8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 11:58:53 2020 +0100

    Revert "Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh"

    This reverts commit 6d507a684f14dc09641877d6d691fd96adb63be4.

commit 6d507a684f14dc09641877d6d691fd96adb63be4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 11:56:51 2020 +0100

    Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh

commit d26b342644bc08c2ab4118a71899bb78a2c303a7
Merge: b1512335cb 40749ce2ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 09:27:26 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit b1512335cb09b7b3e1ee783f991347704c4952be
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 18:24:05 2020 +0100

    Fix after merge

commit 43e25995ca9a15aa0ee5c88297616ccbd3fc5c2d
Merge: e357f4871b 7abaf9bbf2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 17:47:34 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionMesh.cs

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit e357f4871b8c39257c62daf1fe63f85241325712
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 25 08:56:53 2020 +0100

    Fix build in 2020.1 to resolve comment https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/258#pullrequestreview-52608

commit bfc0d9f7aeaa8b34407bfa8279d30bf59cf55099
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 18:44:28 2020 +0100

    *Fix compilation

commit 6cfd2d90292796c5b21e63d01c4b4bf8563c0184
Merge: 41a1a8e212 128101bc63
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 14:56:22 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 41a1a8e212c82b48832ab88f68348c145c0960c6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 15:19:24 2020 +0100

    *Update expression name

commit 27794064fd01207a35e7d967ff322e9d552a2054
Merge: ad597a0388 28f0ca20a0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 10:21:38 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit ad597a03881e11743e68555f985c304ee2d7557d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:18:40 2020 +0100

    Support float or uint read in sample mesh color

commit 8ca98dd9a375431ddc04c7a0cb625c35a2c99f57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 10:05:40 2020 +0100

    Add compatibility code & use new available expression from https://ono.unity3d.com/unity/unity/changeset/6afd1f99b768984023366f3aba746390c763432f

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Sample mesh, add placement mode : Surface & Edge *WIP*

* Some experiment with low distorsion mapping

* *WIP* debug data (will be removed anyway)

* Clean BarycentricCoordinatesBis

* Fix to graft : support for flag enum in inspector

* Add animation test data from @vlad

* Test scene *WIP*

* Use GetVertexStride depending of channelIndex & VFXExpressionVertexBufferFromMesh depending of channelFormatAndDimensionAndStream

* *WIP* pushing test data

* *Push Some test data (will be removed)

* Fix test adding a *WIP* note

* Minor fixes after merge

* Add SkinnedMeshRenderer exposable

* Add SkinnedMeshRenderer in IsTypeConstantFoldable

* Add VFXExpressionSampleSkinnedMeshRendererFloat & co support (it should be factorizable)

* Move hexahredron to common data, it will be convinient for graphicTest

* Fix PositionMesh (bad merge)

* Implement Graphic Test for skinned mesh (not yet tested in standalone yet)

* *Add reference images

* Clean some code, remove intermediate compatibility code

* Add variant provider for sample mesh

* Factorize sampling function to share them with PositionMesh

* Start factorization of SamplePositionMesh

* Add simple TODOPAUL

* Add another TODOPAUL

* Change VertexAttributeFlag to VertexAttribute, use proper mesh type in MeshPosition

* Implement surface coordinate & sample vertex for position mesh

* Remove test data & Update actual graphicTest

* Use nameof instead of verbatim (this code will not be backported)

* Fix sample edge

* Add skinned & mesh index/vertex count

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* *Update reference image for mesh sampling

* *Add sampleMesh index for skinned & mesh

* Fix after merge (wasn't so obvious but now works \o/ Can be factorized)

* Simpler update to use now available ByteAddressBuffer

# Conflicts:
#	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
#	com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionAbstract.cs
#	com.unity.visualeffectgraph/Shaders/VFXCommon.hlsl

* Revert "Simpler update to use now available ByteAddressBuffer" (onluy VFXCommon.hlsl)

This reverts commit 65b5ce1c588b969b95726a83d06a34a386a8c16d.

* Fix compilation

* Fix wrong return type of FetchBuffer

* *Restore lost test for triangle sampling

* Proper sample OOB fix

* Use explicit branch in SampleMeshReadFloat : we aren't supposed fetch in invalid buffer

* Enable GPUSkinng, default mode

* Remove float cast for condition since we are able to compare uint

* Factorize insertGPUTransformation using the common switch

* Clean multiple place where "ByteAddressBuffer" is declared

* Simply generated code verifying at http://shader-playground.timjones.io/d7df4e7dbec05529d6943aacca2812b9

* Remove unexpected restored file (as been renamed)

* *Update changelog

* *Fix build

* *Update image reference

* Remove useless case in GetFunctionParameterType (ByteAddressBuffer is in TypeToCode anyway)

* Fix after merge

* First draft of documentation for sample mesh

* *Update documentation

* *up doc

* *documentation

* Add documentation for Mesh Index Count & Vertex Count

* *documentation

* *Remove unexpected change & deprecated code

* *documentation

* Remove unexpected change in changelog.mp

* *Apply formatting

* *Update documentation

* Minor documentation update

* Documentation : add "inspector" flag when relevant

* Rename confusing "x" in "edge"

See https://docs.google.com/document/d/1VbIc5pMkgFX2Ui4-LWrZ7uQ4EKlXlFxWWW4ufcex70I/edit

* *Remove deprecated MeshSampling & Update TOC

* Reviewed the Set Position(Mesh) doc

* Reviewed mesh index count doc

* reviewed the rest of the sample mesh operators.

* Fix ToC & rename some "Skinned Mesh Renderer" in "Skinned Mesh"

* Missing minor change

* *Reupdate VFX after merge

* Fix several tooltip issues

- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89530
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89531
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89532
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89533
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89534
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89535
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89536
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89538
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89539
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89540
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89541
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89542
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89544
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89545
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89546
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89547
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89548
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89549
- https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89550

* Forgot to stage files from previous commit d8c1bef513605c8c7b40ec855cfe2be4de2e7d5e

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109724

Remove not needed UNITY_2020_2_OR_NEWER condition

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109727

Isolate helper function to VFXMeshSampling.hlsl

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109725

- Rename sourceExpression to targetExpression
- Add InvalidOperationException if we are detecting an unexpected graph

* Add missing compile of channelFormatAndDimensionAndStream

- Check branch behavior
- Trying to find infinite recursion due to dependent sampling
- TODO : Add an editor test to inspect the actual generated graph (already checked in debug)

Co-authored-by: Tristan Genevet <tristan@unity3d.com>
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* *Update all VisualEffectAsset

"flipbookLayout: 0" everywhere
+ Some missing meta in test project (minor)

* *Apply formatting

* *Update missing reference images

* Other missing update screenshot & missing meta

* Fix formatting : this change can be grafted directly on master

* Three minor fixes from https://github.com/Unity-Technologies/Graphics/pull/3414

- Wrong Image reference : Fix D3D11 standalone
- Unconsistent debug assert (the recreate can be called on subslot) : Fix Space_Slot_Sanitize_Still_Possible_ArcSphere
- CreateComponentWithAllBasicTypeExposed : remove VFXValueType.CameraBuffer from list of tested exposed type (it can'td irectly be exposed)
These change can independantly land in `master`

* Fix incorrect changelog.md in com.unity.visualeffectgraph

* Remove unexpected duplicated entry in changelog.md

* Fix changelog : unexpected removed entries in 11.x

* *Update changelog.md

* Fix build

* Rename vfx file

* [BRP] Fix Shader Compilation (#216)

* Fix incorrect direct access to GetWorldToObjectMatrix

* *Update changelog.md

* Proper virtual in VFXData to handle hasDynamicSourceCount in VFXCodeGenerator without cast

* Refactor GenerateComputeSourceIndex

* Store system index in VFXContextCompiledData

Avoid this "Anticipate what will be index of this particle system, not ideal and arbitrary."

* Minor : rename define

* Simplify FillEvent implementation using directly EventStructure

* *Add mixing test

* Update VFXSettings for 016

* Move 016 to common test package

* *Update using HDRP

* *Add 016_DirectLink to EditorBuildSettings

* Sphere and cube outputs as experimental

* *Update test to have a clearer and more stable behavior & Add editor reference images

* Minor : fix compilation warning

Check locally :
016_DirectLink (1.714s)
---
The referenced script (Unknown) on this Behaviour is missing!
The referenced script on this Behaviour (Game Object 'Main Camera') is missing!

* *Missing editor build settings update

* Add castShadows as additionalMappings in VFXStaticMeshOutput (#217)

* [Orient] 'Look At Position' particle disappearance (#101)

* Expensive fix

Computes two cross products to avoid the case when one of them is zero. Is it faster than branching to check ?
Is this edge case worth the additional cost ?

* More explicit approach/similar instruction cost + LookAtLine

* Update Orient.cs

* Handles edge case when cross(axis1, axis2) = (0,0,0) for all Orient variants

* Small mistake in the exception message

* Factorize SafeNormalizedCross

* Update changelog

* Added information about compute shaders and ssbos (#222)

* Added information about compute shaders and ssbos

* Added recommendation to use Vulkan over OpenGL ES

* Removed 'two'

* Added entry about vfx graph not being out of preview for mobile platforms

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* [Fix] PropertyBinder : Reset & Undo (#212)

* Fix missing record object for proper undo/redo & reset

* *Update changelog.md

* Fix issue https://favro.com/organization/c564ede4ed3337f7b17986b6/1973edb4634ba00a90689144?card=Uni-160638

* Avoid VFXPropertyBinder to be added twice

* Fix incorrect reference after copy past

* Fix RemoveComponent clearing property binder first

* Handle Copy/Past \o/

* Let the LateUpdate without any editor code & use Update (avoid the one frame of latency for inspector)

* Remove useless recompute of GetComponents every frame, and use Reload (safer)

* Remove dead code

* *Add new entry in changelog (side improvement/fix)

* *Update comment

* [Fix] Null Ref Exception due to IsAssetEditable (#221)

* Resource can be null on a block inspector while we are removing it

Use safe check of resource before IsAssetEditable

* *Update changelog

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/221#discussion_r113060

* [Fix] Component Board UX issue (#220)

* Fix missing call to OnSelectionChanged on first display (before selection changed called)

* Fix change from component notifying the VFXView

* Fix toggle component board state

* Minor fixes

* *Update changelog.md

* Add custom namespace for test script

* Minor code update

* Remove reflection about compileInitialVariants : it's available since 19.3

* Remove unexpected entry in changelog.md

* *Update (some) reference images

* Restore the constraint on OutputEvent & Event

It can't work because we aren't generating any data in that case

* *Update reference image URP

* *Update reference images

* *Update changelog.md

* Fix build of VFXSpawnerTest.cs

* [Fix] System name 'Model is not registered' (#224)

* *Add editor test to catch corner case issue with system name

* Move Create_Simple_Graph_Then_Remove_Edget_Between_Init_And_Update_TestCaseto VFXGUITest

* Actual fix of 1315593

The flow edge change is only triggering kConnectionChanged so, if you are trying to access m_SystemNames before compilation

* Remove unexpected change

* [Test] Revert after change  (#213)

* Local test (I'm using git diff to check actual file change)

* test adding a lit mesh output

* *Testing with shaderGraph

* *test bis

* *Add unit test to cover unexpected increasing size

* Properly implement the test

* Remove test data

* *Temp lot of log & save it to independant file

* HotFix : UpdateSubAsset in OnPreprocessAsset

Shouldn't be necessary, the actual problem is maybe in C++ implementation

* Clean test & add comment

* *WIP* Serialization test which seems (tm) to reproduce the same issue

* To revert : experiment adding log while loading VFXSerializableObject

*Without Import Asset after write*
Saving : 100
Loading : 100
Loading : 100
OnBeforeSerialize : 100
Saving : 101
Loading : 101
Loading : 101
OnAfterDeserialize : 100
Loading : 100
=> Test fail !

*With Import Asset after write*
Saving : 100
Loading : 100
Loading : 100
OnBeforeSerialize : 100
OnAfterDeserialize : 100
Saving : 101
Loading : 101
Loading : 101
Loading : 101
OnBeforeSerialize : 101
OnAfterDeserialize : 101
Saving : 102
Loading : 102
Loading : 102
Loading : 102
OnBeforeSerialize : 102
OnAfterDeserialize : 102
Saving : 103
Loading : 103
Loading : 103

* *Revert unwanted change

* Clean & Unify test behavior

* Safety check in newly integrated test (if asset is empty, it isn't expected neither)

* Remove OnCompile : Avoid recompile twice, the WriteAsset is already trigerring an import

* [Test] Add test to cover CopyValuesFrom (#225)

* *Add test to cover CopyValuesFrom issue

* *Extend the newly added test

Check every value in copied values

* Just added a perf marker

* Changed `mobile` to `…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Assignees
No one assigned
Labels
backported-7.x backported-8.x Docs HDRP Shader Graph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanL8 @sebastienlagarde