Skip to content

Change a multi compile to multi compile local to reduce number of keyword #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2020
Merged

Change a multi compile to multi compile local to reduce number of keyword #1444

merged 2 commits into from
Jul 29, 2020

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Jul 29, 2020 •
edited
Loading

Purpose of this PR

follow up of slack discussion: https://unity.slack.com/archives/C6Y79CZM0/p1596011296003800
reduce number of keyword in global namespace.

Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?

Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions github-actions bot added the HDRP label Jul 29, 2020
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde merged commit 824d993 into HDRP/staging Jul 29, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/change-to-local-multicompile branch July 29, 2020 11:56
sebastienlagarde added a commit that referenced this pull request Nov 16, 2020
@sebastienlagarde
Change a multi compile to multi compile local to reduce number of key…
a8a5b91 
…word #1444
sebastienlagarde added a commit that referenced this pull request Nov 16, 2020
@sebastienlagarde @pmavridis
@fabien-unity @JordanL8 @robinb-u3d @adrien-de-tocqueville @FrancescoC-unity @JulienIgnace-Unity @i9neus @jpg-unity
Merge 8.x.x/hd/staging (#2647)
0315ea4 
* Fix warning in HDAdditionalLightData OnValidate #885

* Fix XR multipass #1133

* Update Override-Micro-Shadows.md (#1236)

* Added disclaimer to volumes (#1247)

* Added missing volumes API toc entry (#1259)

* Fix XR Display providers not getting zNear and zFar updated on them. #1269

* Remove MSAA debug mode when renderpipeline asset has no MSAA #1289

* Added menu items doc

* Moved requirements in toc to make it consistent with URP/VFX #1352

* Fix compilation issue when XR is not available #1391

* Fix an issue with dynamic resolution handler in case no OnResolutionChange callback is defined #1403

* Change a multi compile to multi compile local to reduce number of keyword #1444

* Docs quality fixes #1445

* Added enable Volume snippet

* Update Volume-Override-Enable-Override.md

* Update HDCamera.cs

* Fix layer-related error caused by disabling emissive area light mesh #1506

* Make sure sun icon is not clipped in lookdev window #1515

* Fix for LookDev displaying probes as pink spheres #1521

* Fix issue with disc area light editor not updating #1526

* Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. #1529

* Hdrp/update decal atlas when texture changes #1532

* Fix Screen position out of view frustum issues when planar reflection probe is at same camera location #1537

* Make sure diffusion profile is correct upon its editor reset #1538

* Added propagating nans doc (#1562)

* Added propagating nans doc

* Added information about HDRP's NanTracker

* GFXGI-237: Force update for static skies when camera type is set to S… #1570

* Hdrp/docs/shader additions #1580

* Added information about HDRP not upgrading particle shaders (#1601)

* Added information about HDRP not upgrading particle shaders

* Update Upgrading-To-HDRP.md

* Update Upgrading-To-HDRP.md

* Changed cog to gear to adhere to style guide rules #1611

* Added build settings setup (#1631)

* Fixing the remapping of Min/Max parametrizations values to Amplitude parametrizations values

* Updating UI to match documentation of LayeredLit

* Hdrp/fix/terrain layer parametrization #1678

Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: robinb-u3d <robinb-u3d@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Ben Spencer <github@raytracing.co.uk>
Co-authored-by: Jean-Philippe Grenier <jeanphilippe@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescoC-unity FrancescoC-unity FrancescoC-unity approved these changes

Assignees
No one assigned
Labels
backported-8.x HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastienlagarde @FrancescoC-unity