-
Notifications
You must be signed in to change notification settings - Fork 840
[Yamato] replace ScriptableRenderPipeline with Graphics in yml [skip ci] #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the Unity SRP repo!
Please make sure to fill out the PR template as best you can to give reviewers as much information as possible.
If you have any questions (and you are a Unity employee) go to "#devs-renderpipe"
{% endif %} | ||
UTR_RESULT=$? | ||
mkdir -p TestProjects/{{ project.folder }}/test-results/ | ||
scp -i ~/.ssh/id_rsa_macmini -o "StrictHostKeyChecking=no" -r bokken@$BOKKEN_DEVICE_IP:/Users/bokken/ScriptableRenderPipeline/TestProjects/{{ project.folder }}/test-results/ TestProjects/{{ project.folder }}/test-results/ | ||
scp -i ~/.ssh/id_rsa_macmini -o "StrictHostKeyChecking=no" -r bokken@$BOKKEN_DEVICE_IP:/Users/bokken/Graphics/TestProjects/{{ project.folder }}/test-results/ TestProjects/{{ project.folder }}/test-results/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion define a variable {{ project.name }} and define it to Graphics. If you get into a similar situation in the future you will only have to change the variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this is stuff that @kivistikliis has been working on, but it's not ready to land yet. soon we will only have to change things in one place 👍
Fix exception when creating new category on new visual effect asset.
…eflectionProbeNormalizationDirection'. Fix a bunch of shader warnings in DynamicGI shaders. (#11) Co-authored-by: pastasfuture <nickb@bonfirestudios.com>
…eflectionProbeNormalizationDirection'. Fix a bunch of shader warnings in DynamicGI shaders. (#11) Co-authored-by: pastasfuture <nickb@bonfirestudios.com>
…eflectionProbeNormalizationDirection'. Fix a bunch of shader warnings in DynamicGI shaders. (#11) Co-authored-by: pastasfuture <nickb@bonfirestudios.com>
… material (Unity-Technologies#11)" This reverts commit a87a54c.
Purpose of this PR
Testing status
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/ci%252Fchange-repo-name/.yamato%252Fupm-ci-abv.yml%2523all_project_ci_fast-2020.1/1822329/job/pipeline