Fix issue with light layers > 7 in the deferred path #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienlagarde
approved these changes
Jun 30, 2020
This was referenced Jul 2, 2020
TomasKiniulis
approved these changes
Jul 2, 2020
sebastienlagarde
deleted the
HDRP/fix-issue-with-light-layers-and-deferred
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we store light layers in a UNORM we can only safely represent values [0...255], however we don't enforce that so any value above 255 will be incorrectly mapped to a mask with all bits set.
This fixes the issue in here https://fogbugz.unity3d.com/f/cases/1256220/
For QA: I tested the repro project and played around a bit with layers and all seems working now.