Fix Light overlap #444

Author: alelievr

com.unity.render-pipelines.core/Runtime/Utilities/CoreUtils.cs

@@ -1106,6 +1106,32 @@ public static bool IsSceneLightingDisabled(Camera camera)
             return disabled;
         }
 
+        /// <summary>
+        /// Returns true if the "Light Overlap" scene view draw mode is enabled.
+        /// </summary>
+        /// <param name="camera">Input camera.</param>
+        /// <returns>True if "Light Overlap" is enabled in the scene view associated with the input camera.</returns>
+        public static bool IsLightOverlapDebugEnabled(Camera camera)
+        {
+            bool enabled = false;
+#if UNITY_EDITOR
+            if (camera.cameraType == CameraType.SceneView)
+            {
+                // Determine whether the "LightOverlap" mode is enabled for the current view.
+                for (int i = 0; i < UnityEditor.SceneView.sceneViews.Count; i++)
+                {
+                    var sv = UnityEditor.SceneView.sceneViews[i] as UnityEditor.SceneView;
+                    if (sv.camera == camera && sv.cameraMode.drawMode == UnityEditor.DrawCameraMode.LightOverlap)
+                    {
+                        enabled = true;
+                        break;
+                    }
+                }
+            }
+#endif
+            return enabled;
+        }
+
 #if UNITY_EDITOR
         static Func<List<UnityEditor.MaterialEditor>> materialEditors;
 

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -124,6 +124,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fix spelling and grammatical errors in material samples
 - Fixed issue with sceneview camera settings not being saved after Editor restart.
 - Fixed issue that caused not all baked reflection to be deleted upon clicking "Clear Baked Data" in the lighting menu (case 1136080)
+- Fixed the light overlap scene view draw mode (wasn't working at all).
 
 ### Changed
 - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history.

com.unity.render-pipelines.high-definition/Runtime/Debug/DebugLightVolumes.compute

@@ -7,16 +7,15 @@
 // Tile size of this compute
 #define DEBUG_LIGHT_VOLUME_TILE_SIZE 8
 
-// The pixel radius to switch on the edge color
-#define RADIUS_PIXEL_BORDER 1
-
 // Input Runtime textures
 TEXTURE2D_X_FLOAT(_DebugLightCountBuffer);
 TEXTURE2D_X(_DebugColorAccumulationBuffer);
 
 // Data used for the computation
 Texture2D<float4> _ColorGradientTexture;
 int _MaxDebugLightCount;
+// The pixel radius to switch on the edge color
+float _BorderRadius;
 
 // output texture
 RW_TEXTURE2D_X(float4, _DebugLightVolumesTexture);
@@ -58,9 +57,9 @@ void LightVolumeColors(uint3 dispatchThreadId : SV_DispatchThreadID, uint2 group
     // Look around this pixel to check if this should be displayed as a border
     float maxLightCount = lightCount;
     bool isBorder = false;
-    for (int radiusX = -RADIUS_PIXEL_BORDER; radiusX <= RADIUS_PIXEL_BORDER; ++radiusX)
+    for (float radiusX = -_BorderRadius; radiusX <= _BorderRadius; ++radiusX)
     {
-    	for (int radiusY = -RADIUS_PIXEL_BORDER; radiusY <= RADIUS_PIXEL_BORDER; ++radiusY)
+    	for (float radiusY = -_BorderRadius; radiusY <= _BorderRadius; ++radiusY)
     	{
     		// Compute the target pixel
     		int2 targetpixel = int2((uint)currentPixelCoordinate.x + radiusX, (uint)currentPixelCoordinate.y + radiusY);