Skip to content

Commit bca80ab

Browse files
eturquinsebastienlagarde
authored andcommitted
[HDRP] Improves robustness of detail normal mapping when scale = 0 (and not using surface gradients) #6980
1 parent 7307706 commit bca80ab

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

com.unity.render-pipelines.high-definition/CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
66

77
## [12.1.6] - 2022-02-09
88

9-
Version Updated
10-
The version number for this package has increased due to a version update of a related graphics package.
9+
### Fixed
10+
- Fixed issue with detail normals when scale is null (case 1399548).
1111

1212
## [12.1.5] - 2022-01-14
1313

@@ -48,6 +48,7 @@ The version number for this package has increased due to a version update of a r
4848
- Fixed various issues with render graph viewer when entering playmode.
4949
- Fixed issue with Final Image Histogram displaying a flat histogram on certain GPUs and APIs.
5050
- Fixed HDRP camera debug panel rendering foldout.
51+
- Fixed issue with detail normals when scale is null (case 1399548).
5152

5253
## [12.1.4] - 2021-12-07
5354

com.unity.render-pipelines.high-definition/Runtime/Material/Lit/LitDataIndividualLayer.hlsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ float3 ADD_IDX(GetNormalTS)(FragInputs input, LayerTexCoord layerTexCoord, float
123123
#ifdef SURFACE_GRADIENT
124124
normalTS += detailNormalTS * detailMask;
125125
#else
126-
normalTS = lerp(normalTS, BlendNormalRNM(normalTS, detailNormalTS), detailMask); // todo: detailMask should lerp the angle of the quaternion rotation, not the normals
126+
normalTS = lerp(normalTS, BlendNormalRNM(normalTS, normalize(detailNormalTS)), detailMask); // todo: detailMask should lerp the angle of the quaternion rotation, not the normals
127127
#endif
128128
#endif
129129
#else

0 commit comments

Comments
 (0)