Skip to content

Commit aa07c1f

Browse files
[VFX] Fix compilation error when shaderGraph is modified (#5475)
* Add Editor Test to cover issue 1361601 + Cleaner exception than a null ref exception * Actual fix from https://fogbugz.unity3d.com/f/cases/1361601/ The regression has been probably introduced by #4971 What happens, 1st VFX import: - Not Sanitized - Skip first compilation - PostProcess => Sanitize & CheckGraphBeforeImport - Reimport Later, the ShaderGraph changes - Because the VFX is sanitized - Doesn't skip the first compilation => Fail - Post Process => CheckGraphBeforeImport is applied - ... Later VFX import will be ok until the SG isn't modified. * *Update changelog.md * More readable exception when failing to find expression Equivalent change from e6d34d3 The following ContainsKey would have thrown an exception anyway * Move changelog entry to 13.x.x # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
1 parent d04e829 commit aa07c1f

File tree

10 files changed

+2647
-0
lines changed

10 files changed

+2647
-0
lines changed

TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/Modify_SG_Property.vfx

Lines changed: 1277 additions & 0 deletions
Large diffs are not rendered by default.

TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/Modify_SG_Property.vfx.meta

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)