Disable subblocks space conversion (#2567)

* space fixes in subblocks (no more conversion happens)

* Nicify subgraph names

* update changelog

Author: julienf-unity

com.unity.visualeffectgraph/CHANGELOG.md

@@ -58,6 +58,7 @@ The version number for this package has increased due to a version update of a r
 - Fixed Set Strip Progress Attribute utility block in Additional Samples
 - Fix [Case 1255182](https://fogbugz.unity3d.com/f/cases/1255182/)
 - Remove temporarily "Exact Fixed Time Step" option on VisualEffectAsset to avoid unexpected behavior
+- Disable implicit space transformations in sublock graphs as they led to unexpected behaviors
 
 ## [10.1.0] - 2020-10-12
 ### Added

com.unity.visualeffectgraph/Editor/Models/Blocks/VFXSubgraphBlock.cs

@@ -46,7 +46,7 @@ public override void CheckGraphBeforeImport()
             ResyncSlots(true);
         }
 
-        public sealed override string name { get { return m_Subgraph != null ? m_Subgraph.name : "Empty Subgraph Block"; } }
+        public sealed override string name { get { return m_Subgraph != null ? ObjectNames.NicifyVariableName(m_Subgraph.name) : "Empty Subgraph Block"; } }
 
         protected override IEnumerable<VFXPropertyWithValue> inputProperties
         {

com.unity.visualeffectgraph/Editor/Models/Contexts/Implementations/VFXStaticMeshOutput.cs

@@ -49,6 +49,11 @@ public override void OnEnable()
             shader = ((VFXDataMesh)GetData()).shader;
         }
 
+        public override VFXCoordinateSpace GetOutputSpaceFromSlot(VFXSlot slot)
+        {
+            return VFXCoordinateSpace.Local;
+        }
+
         public override bool SetupCompilation()
         {
             shader = ((VFXDataMesh)GetData()).shader;

com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

@@ -561,7 +561,7 @@ public VFXCoordinateSpace space
                 {
                     return (m_Data as ISpaceable).space;
                 }
-                return VFXCoordinateSpace.Local;
+                return (VFXCoordinateSpace)int.MaxValue;
             }
 
             set

com.unity.visualeffectgraph/Editor/Models/Operators/VFXSubgraphOperator.cs

@@ -132,7 +132,7 @@ private void ClearCopy()
             }
         }
 
-        public sealed override string name { get { return m_Subgraph != null ? m_Subgraph.name : "Empty Subgraph Operator"; } }
+        public sealed override string name { get { return m_Subgraph != null ? ObjectNames.NicifyVariableName(m_Subgraph.name) : "Empty Subgraph Operator"; } }
 
         protected override IEnumerable<VFXPropertyWithValue> inputProperties
         {