DGI fallback radiance baking for low end settings (#92)

* Added the way to copy prepared radiance into baked data of a Probe Volume and use it at runtime as a fallback for when DGI is disabled.
* Changed the way of updating and tracking data version for Probe Volume assets to not reupload it on every asset reimport and validation (needed to maintain propagated radiance while baking reflections and saving assets).

Author: AndrewSaraevUnity

com.unity.render-pipelines.high-definition/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Drawer.cs

@@ -16,12 +16,21 @@ enum Expandable
         {
             Volume = 1 << 0,
             Probes = 1 << 1,
-            Baking = 1 << 2
+            Baking = 1 << 2,
+            DynamicBaking = 1 << 3
+        }
+
+        enum DynamicGIBakingStage
+        {
+            Neighborhood,
+            MixedLights,
+            FallbackRadiance,
         }
 
         readonly static ExpandedState<Expandable, ProbeVolume> k_ExpandedStateVolume = new ExpandedState<Expandable, ProbeVolume>(Expandable.Volume, "HDRP");
         readonly static ExpandedState<Expandable, ProbeVolume> k_ExpandedStateProbes = new ExpandedState<Expandable, ProbeVolume>(Expandable.Probes, "HDRP");
         readonly static ExpandedState<Expandable, ProbeVolume> k_ExpandedStateBaking = new ExpandedState<Expandable, ProbeVolume>(Expandable.Baking, "HDRP");
+        readonly static ExpandedState<Expandable, ProbeVolume> k_ExpandedStateDynamicBaking = new ExpandedState<Expandable, ProbeVolume>(Expandable.DynamicBaking, "HDRP");
 
         internal static readonly CED.IDrawer Inspector = CED.Group(
             CED.Group(
@@ -55,6 +64,13 @@ enum Expandable
                         Expandable.Baking,
                         k_ExpandedStateBaking,
                         Drawer_BakeToolBar
+                        ),
+                    CED.space,
+                    CED.FoldoutGroup(
+                        Styles.k_DynamicBakingHeader,
+                        Expandable.DynamicBaking,
+                        k_ExpandedStateDynamicBaking,
+                        Drawer_DynamicBakeToolBar
                         )
                     )
                 )
@@ -101,38 +117,108 @@ static void Drawer_BakeToolBar(SerializedProbeVolume serialized, Editor owner)
             EditorGUILayout.Slider(serialized.backfaceTolerance, 0.0f, 1.0f, Styles.s_BackfaceToleranceLabel);
             EditorGUILayout.PropertyField(serialized.dilationIterations, Styles.s_DilationIterationLabel);
 
-            GUILayout.BeginHorizontal();
-            if (GUILayout.Button(Styles.k_BakeSelectedText))
+            var bakeButtonRect = EditorGUI.IndentedRect(EditorGUILayout.GetControlRect(false));
+            if (GUI.Button(bakeButtonRect, Styles.k_BakeSelectedText))
             {
                 ProbeVolumeManager.BakeSelected();
             }
-            if (GUILayout.Button(Styles.k_BakeDynamicGIOnlyText))
+        }
+
+        static void Drawer_DynamicBakeToolBar(SerializedProbeVolume serialized, Editor owner)
+        {
+            DynamicGIBakingStage dynamicGIBakingStage;
+            if (ProbeVolume.preparingMixedLights)
+                dynamicGIBakingStage = DynamicGIBakingStage.MixedLights;
+            else if (ProbeVolume.preparingForBake)
+                dynamicGIBakingStage = DynamicGIBakingStage.FallbackRadiance;
+            else
+                dynamicGIBakingStage = DynamicGIBakingStage.Neighborhood;
+
+            EditorGUI.BeginChangeCheck();
+            dynamicGIBakingStage = (DynamicGIBakingStage)EditorGUILayout.EnumPopup(Styles.k_DynamicBakingStageLabel, dynamicGIBakingStage);
+            if (EditorGUI.EndChangeCheck())
+            {
+                ProbeVolume.preparingMixedLights = dynamicGIBakingStage == DynamicGIBakingStage.MixedLights;
+                ProbeVolume.preparingForBake = dynamicGIBakingStage == DynamicGIBakingStage.FallbackRadiance;
+            }
+
+            EditorGUILayout.Space();
+
+            var targets = serialized.GetTargetObjects();
+
+            if (dynamicGIBakingStage == DynamicGIBakingStage.Neighborhood)
             {
-                var targets = serialized.GetTargetObjects();
-                for (int i = 0; i < targets.Length; i++)
+                var dynamicBakeButtonRect = EditorGUI.IndentedRect(EditorGUILayout.GetControlRect(false));
+                if (GUI.Button(dynamicBakeButtonRect, Styles.k_DynamicBakeNeighborhoodLabel))
                 {
-                    var probeVolume = (ProbeVolume)targets[i];
-                    EditorUtility.DisplayProgressBar("Baking Dynamic GI", $"{i + 1}/{targets.Length} {probeVolume.name}", (i + 0.5f) / targets.Length);
-                    probeVolume.BakeDynamicGIOnly();
+                    for (int i = 0; i < targets.Length; i++)
+                    {
+                        var probeVolume = (ProbeVolume)targets[i];
+                        EditorUtility.DisplayProgressBar("Baking Dynamic GI", $"{i + 1}/{targets.Length} {probeVolume.name}", (i + 0.5f) / targets.Length);
+                        probeVolume.BakeDynamicGIOnly();
+                    }
+                    EditorUtility.ClearProgressBar();
                 }
-                EditorUtility.ClearProgressBar();
             }
-            GUILayout.EndHorizontal();
-            
-            EditorGUILayout.Space();
-            
-            ProbeVolume.preparingMixedLights = EditorGUILayout.Toggle(Styles.k_PrepareMixedLightsText, ProbeVolume.preparingMixedLights);
-            GUI.enabled = ProbeVolume.preparingMixedLights;
+            else
+            {
+                GUI.enabled = !CheckAndWarnNoNeighborhoodBaked(targets);
+
+                var dynamicBakeButtonRect = EditorGUI.IndentedRect(EditorGUILayout.GetControlRect(false));
+                if (dynamicGIBakingStage == DynamicGIBakingStage.MixedLights)
+                {
+                    if (GUI.Button(dynamicBakeButtonRect, Styles.k_DynamicBakeMixedLightsLabel))
+                    {
+                        foreach (var target in targets)
+                        {
+                            var probeVolume = (ProbeVolume)target;
+                            probeVolume.CopyDirectLightingToMixed();
+                        }
+                    }
+                }
+                else if (dynamicGIBakingStage == DynamicGIBakingStage.FallbackRadiance)
+                {
+                    if (GUI.Button(dynamicBakeButtonRect, Styles.k_DynamicBakeFallbackRadianceLabel))
+                    {
+                        foreach (var target in targets)
+                        {
+                            var probeVolume = (ProbeVolume)target;
+                            probeVolume.CopyDynamicSHToAsset();
+                        }
+                    }
+                }
 
-            if (GUILayout.Button(Styles.k_BakeMixedLightsText))
+                GUI.enabled = true;
+
+                EditorGUILayout.Space();
+                
+                EditorGUILayout.HelpBox(Styles.k_DynamicPipelineOverridesWarning, MessageType.Warning);
+                var resetButtonRect = EditorGUI.IndentedRect(EditorGUILayout.GetControlRect(false));
+                if (GUI.Button(resetButtonRect, Styles.k_DynamicResetPipelineOverridesLabel))
+                {
+                    ProbeVolume.preparingMixedLights = false;
+                    ProbeVolume.preparingForBake = false;
+                }
+            }
+        }
+
+        static bool CheckAndWarnNoNeighborhoodBaked(Object[] targets)
+        {
+            var noNeighborhoodBaked = false;
+            foreach (var target in targets)
             {
-                var targets = serialized.GetTargetObjects();
-                for (int i = 0; i < targets.Length; i++)
+                var probeVolume = (ProbeVolume)target;
+                if (probeVolume.probeVolumeAsset == null)
                 {
-                    var probeVolume = (ProbeVolume)targets[i];
-                    probeVolume.CopyDirectLightingToMixed();
+                    noNeighborhoodBaked = true;
+                    break;
                 }
             }
+
+            if (noNeighborhoodBaked)
+                EditorGUILayout.HelpBox(Styles.k_DynamicNoNeighborhoodWarning, MessageType.Error);
+
+            return noNeighborhoodBaked;
         }
 
         static void Drawer_ToolBar(SerializedProbeVolume serialized, Editor owner)

com.unity.render-pipelines.high-definition/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs

@@ -15,9 +15,14 @@ internal static class Styles
             internal const string k_ProbesHeader = "Probes";
             internal const string k_BakingHeader = "Baking";
             internal const string k_BakeSelectedText = "Bake Selected";
-            internal const string k_BakeDynamicGIOnlyText = "Bake Dynamic GI Only";
-            internal const string k_PrepareMixedLightsText = "Prepare Mixed Lights";
-            internal const string k_BakeMixedLightsText = "Bake Mixed Lights";
+            internal const string k_DynamicBakingHeader = "Dynamic GI Baking";
+            internal const string k_DynamicBakingStageLabel = "Baking Stage";
+            internal const string k_DynamicBakeNeighborhoodLabel = "Bake Neighborhood";
+            internal const string k_DynamicBakeMixedLightsLabel = "Bake Mixed Lights";
+            internal const string k_DynamicNoNeighborhoodWarning = "Please bake the neighborhood before any other stage.";
+            internal const string k_DynamicBakeFallbackRadianceLabel = "Bake Fallback Radiance";
+            internal const string k_DynamicPipelineOverridesWarning = "Some render pipeline settings are globally overriden for baking purposes. Please reset them after you finish baking.";
+            internal const string k_DynamicResetPipelineOverridesLabel = "Reset Pipeline Overrides";
 
             internal static readonly GUIContent[] s_Toolbar_Contents = new GUIContent[]
             {

com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDProcessedVisibleLightsBuilder.Jobs.cs

@@ -263,7 +263,7 @@ public void Execute(int index)
                     lightRenderData.affectDynamicGI;
 
 #if UNITY_EDITOR
-                if (dynamicGIPreparingMixedLights)
+                if (dynamicGIPreparingMixedLights || dynamicGIPreparingForBake)
                     affectsDynamicGI &= lightRenderData.mixedDynamicGI;
 #endif
 

com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs

@@ -2112,11 +2112,13 @@ bool PrepareLightsForGPU(CommandBuffer cmd, HDCamera hdCamera, CullingResults cu
                 bool processVisibleLights = cullResults.visibleLights.Length != 0;
 
                 bool dynamicGIEnabled = hdCamera.frameSettings.IsEnabled(FrameSettingsField.ProbeVolumeDynamicGI);
+                bool dynamicGIMixedOnly = hdCamera.frameSettings.probeVolumeDynamicGIMixedLightMode == ProbeVolumeDynamicGIMixedLightMode.MixedOnly;
                 bool dynamicGINeedsLights =
 #if UNITY_EDITOR
-                    ProbeVolume.preparingMixedLights ||
+                    ProbeVolume.preparingMixedLights || ProbeVolume.preparingForBake ||
 #endif
-                    hdCamera.frameSettings.probeVolumeDynamicGIMixedLightMode != ProbeVolumeDynamicGIMixedLightMode.MixedOnly;
+                    !dynamicGIMixedOnly;
+                
                 bool processDynamicGI = dynamicGIEnabled && dynamicGINeedsLights;
 
                 PreprocessLights(cmd, hdCamera, cullResults, debugDisplaySettings, aovRequest, processDynamicGI);

com.unity.render-pipelines.high-definition/Runtime/Lighting/ProbeVolume/DynamicGI/ProbeDynamicGI.cs

@@ -42,7 +42,7 @@ public class ProbeDynamicGI : VolumeComponent
         public DynamicGINeighboringVolumePropagationModeParameter neighborVolumePropagationMode = new DynamicGINeighboringVolumePropagationModeParameter(DynamicGINeighboringVolumePropagationMode.SampleNeighborsDirectionOnly);
 
         [Tooltip("Debug Contribution control for mixing in baked indirect lighting")]
-        public ClampedFloatParameter bakeAmount = new ClampedFloatParameter(1.0f, 0.0f, 1.0f);
+        public ClampedFloatParameter fallbackAmount = new ClampedFloatParameter(0.0f, 0.0f, 1.0f);
         [Tooltip("Debug Contribution control for mixing in dynamic indirect lighting")]
         public ClampedFloatParameter dynamicAmount = new ClampedFloatParameter(1.0f, 0.0f, 1.0f);