Xp vfx hdrp decal (#52)

* Initial PR merge

Has errors still, dont merge into Custom-10.7.0-custom.1

* Resolved code Compatibility Errors: Testing Functionality

* missing decal template

* Emissive Pass test

proved the assets are grabbed by the renderer, and set to the passes, via the triangle lists and IA, and renders emission in scene view.
however DBufferVFX pass seems to be empty/broken, so PBR values are not working

* Cleanup and looking for null ref that prevents it from serializng to resourceasset

* Latest push, code cleanup, and removed duplicate that was wrong

Been chasing deserialization issue of the asset, I suspect Its a Assembly/asmdef issue at this point, as m_Script is missing for the HDRP Decal, and walked all other code branchs

* Fixing typo in filename, to resolve serialization issue

* Code cleanup before rendergraph merge

* Initial PR merge

Has errors still, dont merge into Custom-10.7.0-custom.1

* Resolved code Compatibility Errors: Testing Functionality

* missing decal template

* Emissive Pass test

proved the assets are grabbed by the renderer, and set to the passes, via the triangle lists and IA, and renders emission in scene view.
however DBufferVFX pass seems to be empty/broken, so PBR values are not working

* Cleanup and looking for null ref that prevents it from serializng to resourceasset

* Latest push, code cleanup, and removed duplicate that was wrong

Been chasing deserialization issue of the asset, I suspect Its a Assembly/asmdef issue at this point, as m_Script is missing for the HDRP Decal, and walked all other code branchs

* Fixing typo in filename, to resolve serialization issue

* Code cleanup before rendergraph merge

* Update Pass.template

Trying to isolate changes that Affect the stencil, by comparing PR to head

* Squashed commit of the following:

commit d4bc772
Author: Szymon Swistun <szymon@bonfirestudios.com>
Date:   Thu Dec 16 23:13:15 2021 -0800

    Fix exception bug in render graph

commit 0c1e75b
Author: Szymon Swistun <szymon@bonfirestudios.com>
Date:   Thu Dec 16 22:03:34 2021 -0800

    rollback of define changes and setting a white texture for dynamic GI that we saw a 1 frame error for

commit 41e94e6
Author: pastasfuture <pastasfuture@gmail.com>
Date:   Thu Dec 16 23:04:58 2021 -0800

    Bugfix to DepthBufferMipChainInfo - previously the calculated offset, and more importantly, size and limit values would be incorrect if render target scaling was occuring - it would use the unscaled size.

commit 0fde80a
Author: Kleber Garcia <kleber.garcia@unity3d.com>
Date:   Tue Dec 14 08:43:32 2021 -0500

    [Fogbugz # 1383093] Fixing leaky state of hardware resolution when turned off from camera (#6492)

    * * Fixing leaky state of hardware resolution dx12 when we disable DRS on a camera object through inspector or script

    * Fixing dirty state of depth mip pyramid

    * Changelog update for case 1383093, bad hw drs for ao

    Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

commit f8b2b5c
Author: pastasfuture <pastasfuture@gmail.com>
Date:   Thu Dec 2 18:13:09 2021 -0800

    Hierarchical Variance Screen Space Shadows. Backing up current state. Cascade logic is almost done being setup now - so quality isnt there quite yet, but the full algorithm is implemented.

    HVSSS Cascades all setup and working. Added high quality filter modes. Need to expose these as toggleable keywords. Need to expose sample count as tuneable parameter. Need to cleanup some code.

    More iteration

    Backing up latest work. Includes general code cleanup, as well as more robust handling of depth buffer thickness heuristic

    Added support for mip bias while raymarching depth lods. Set our sample count back to 10

    Only apply HVSSS in Deferred or Forward passes (skips things like DynamicGI and Volumetrics - for now). Forward is a little bit of a hack, it assumes that the depth of the forward renderered geometry is the same or very similar to the depth buffer depth. For opaque surfaces, this is true because depth prepass is enabled. For transparent objects this is not necessarily true. Lets see how this goes.

    Remove HVSSS keywords. Not using a variant for HVSSS.

    Stop using uint[4] for compute parameters, use a Vector4 instead. While the data is technically uint, its not worth the hassle of managing heap allocated arrays to pass the data through. RenderGraph does have an API to allow temporary allocations of arrays for this purpose, but it still feels like overkill. We dont need the precision of full uint. a float gives us 2^24 exact integers, which is enough for our use case.

    Fix up bilateral filtering. Added optional screen space vignette. Added fullscreen debug view. Fixed cpu uint[] -> Vector4 conversion logic

    HVSSS F16 Support

    HVSSS: Cleanup to raymarch loop. Evaluating 4x samples per loop iteration to help hide TEX unit latency.

    Implemented R16G16B16A16_UNorm discretized version of moments shadow mapping for HVSSS - seems to out perform even R32G32_SFloat VSM (more robust shadows / far less edge artifacts). Still havent gotten a nicely working implementation of the thickness heuristic for Moments, but maybe thats not important for our look afterall.

    Bugfix to view space depth calculation during light range limit cpu side. Tuned output of moments shadow data to avoid light gray areas dominating the screen in certain self intersection cases (by clipping off the top of the distribution)

    Got a tuned thickness that feels pretty good with moments, and makes intuitive sense

    Move HVSSS related rendergraph data and functions into its own partial HDRenderPipeline class.

    spacing

    Minor include cleanup

    Break HVSSSModes into different kernels so they can be toggled at runtime.

    HVSSS: More work exposing parameters

    HVSSS: Cleanup to raymarch setup code

    Fix bug in VSM32 linear initialization

    HVSSS: More stabilizing of depth thickness heuristic across all parameter settings

    HVSSS: More cleanup to dither

    HVSSS Dither Bugfix

    HVSSS: Cleanup to Transmission Accumulator. Additionally, early out if center pixel is outside of light range. Additionally, do not self shadow during raymarching (cleaned up a bunch of 1 pixel artifacts).

    HVSSS: More fixes to the transmissive accumulator

    HVSSS: Different base thickness scales for VSM32, VSM16, and Moments

    HVSSS: Retune defaults

    HVSSS: Bugfixes to VSM16 brings its quality to almost visually identical to VSM32

    HVSSS: Disable debug symbols

    Add #if defined(SHADERPASS) guards to HVSSS sampling - previously if SHADERPASS wasnt defined at all HVSSS could also be enabled

    HVSSS another define guard

    tweaked hvsss defaults

commit d87a45a
Author: Szymon Swistun <szymon@bonfirestudios.com>
Date:   Thu Dec 16 11:08:32 2021 -0800

    adding safety cleanup to help trigger the sorted axis set after cleanup call

commit 0c5f9e8
Merge: 6342691 316de93
Author: Barbara De Luca <93554417+barbara-bonfire@users.noreply.github.com>
Date:   Tue Dec 14 11:37:00 2021 -0800

    Merge pull request #54 from bonfirestudios/partner/crazyhunter-10.7.0-custom.1-dgiopt

    dgi optimization - setup new compute buffer

commit 316de93
Author: Barbara De Luca <barbara@bonfirestudios.com>
Date:   Tue Dec 14 09:30:42 2021 -0800

    Order members in NeighborAxisLookup by type size.

commit 507d8b6
Author: Barbara De Luca <barbara@bonfirestudios.com>
Date:   Mon Dec 13 12:08:55 2021 -0800

    Remove old neighbour axis lookup array.

commit 5e89f2e
Author: Barbara De Luca <barbara@bonfirestudios.com>
Date:   Fri Dec 10 15:18:16 2021 -0800

    Populate new neighbor axis lookups buffer and switch to reading from it.

commit 6342691
Author: Andrew Saraev <67020478+AndrewSaraevUnity@users.noreply.github.com>
Date:   Thu Dec 9 03:19:08 2021 +0000

    Dynamic GI baked emission (#51)

    * Bake emission into dynamic GI neighbors and use it in the propagation.

    * Use 2x2 pixel blocks per baking request to control texture lods with uv and position gradients within these blocks.

    * Added the logic to control the material sampling lod for neighbor baking.

    * Added support of any Probe Volume rotation while baking dynamic GI neighbors and combining dynamic and baked SH.

    * Respect the Baked Emission material toggle when baking the dynamic GI neighbors.

    * Added a volume component setting to scale baked emission for dynamic GI.

    * Provide ddx and ddy for position and UV of a hit when baking neighbor materials.

    * Set the camera position shader property to zero before baking neighbors to support position-based effects in materials.

    * Clean-up.

commit c7d2009
Author: Barbara De Luca <barbara@bonfirestudios.com>
Date:   Tue Dec 7 13:13:23 2021 -0800

    Work in progress.

commit 540fba5
Author: Barbara De Luca <barbara@bonfirestudios.com>
Date:   Tue Dec 7 10:45:53 2021 -0800

    Work in progress for dgi optimization - setup new compute buffer

* Update HDRenderPipeline.Prepass.cs

Solved Decal issue

* Code Cleanup from PR Comments

Co-authored-by: Karl Kent <karl.kent@gmail.com>

Author: KarlBKent

com.unity.render-pipelines.high-definition/Editor/RenderPipeline/HDRenderPipelineEditor.cs

@@ -1,3 +1,5 @@
+using UnityEditor.VFX.HDRP;
+using UnityEditor.VFX.UI;
 using UnityEngine.Rendering.HighDefinition;
 
 namespace UnityEditor.Rendering.HighDefinition
@@ -9,6 +11,7 @@ sealed class HDRenderPipelineEditor : Editor
         SerializedHDRenderPipelineAsset m_SerializedHDRenderPipeline;
 
         internal bool largeLabelWidth = true;
+        internal bool needRefreshVfxWarnings = false;
 
         void OnEnable()
         {
@@ -32,6 +35,7 @@ public override void OnInspectorGUI()
                 EditorGUIUtility.labelWidth *= 0.5f;
 
             serialized.Apply();
+            VFXHDRPSettingsUtility.RefreshVfxErrorsIfNeeded(ref needRefreshVfxWarnings);
         }
     }
 }

com.unity.render-pipelines.high-definition/Editor/RenderPipeline/HDRenderPipelineUI.cs

@@ -1,8 +1,10 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
 using UnityEngine;
+using UnityEngine.Experimental.Rendering;
 using UnityEngine.Rendering;
 using UnityEngine.Rendering.HighDefinition;
-using System.Text;
-using UnityEngine.Experimental.Rendering;
 using static UnityEngine.Rendering.HighDefinition.RenderPipelineSettings;
 
 namespace UnityEditor.Rendering.HighDefinition
@@ -198,8 +200,6 @@ static void Drawer_SectionGeneral(SerializedHDRenderPipelineAsset serialized, Ed
             EditorGUILayout.PropertyField(serialized.lensAttenuation, Styles.GeneralSection.lensAttenuationModeContent);
             EditorGUILayout.PropertyField(serialized.useRenderGraph, Styles.GeneralSection.useRenderGraphContent);
 
-            EditorGUILayout.PropertyField(serialized.highDefinitionExtensionsEnabled, Styles.highDefinitionExtensionsEnabled);
-
             m_ShowLightLayerNames = EditorGUILayout.Foldout(m_ShowLightLayerNames, Styles.lightLayerNamesText, true);
             if (m_ShowLightLayerNames)
             {
@@ -320,7 +320,7 @@ static void Drawer_SectionReflection(SerializedHDRenderPipelineAsset serialized,
                 if (EditorGUI.EndChangeCheck())
                     serialized.renderPipelineSettings.lightLoopSettings.maxPlanarReflectionOnScreen.intValue = Mathf.Clamp(serialized.renderPipelineSettings.lightLoopSettings.maxPlanarReflectionOnScreen.intValue, 1, ShaderVariablesGlobal.s_MaxEnv2DLight);
             }
-            
+
             EditorGUILayout.Space();
 
             EditorGUI.BeginChangeCheck();
@@ -409,7 +409,7 @@ static void Drawer_SectionShadows(SerializedHDRenderPipelineAsset serialized, Ed
                 --EditorGUI.indentLevel;
 
                 ++EditorGUI.indentLevel;
-                // Because we don't know if the asset is old and had the cached shadow map resolution field, if it was set as default float (0) we force a default. 
+                // Because we don't know if the asset is old and had the cached shadow map resolution field, if it was set as default float (0) we force a default.
                 if (serialized.renderPipelineSettings.hdShadowInitParams.cachedPunctualShadowAtlasResolution.intValue == 0)
                 {
                     serialized.renderPipelineSettings.hdShadowInitParams.cachedPunctualShadowAtlasResolution.intValue = 2048;
@@ -472,14 +472,26 @@ static void Drawer_SectionDecalSettings(SerializedHDRenderPipelineAsset serializ
                 if (EditorGUI.EndChangeCheck())
                     serialized.renderPipelineSettings.decalSettings.atlasHeight.intValue = Mathf.Max(serialized.renderPipelineSettings.decalSettings.atlasHeight.intValue, 0);
 
+                EditorGUI.BeginChangeCheck();
                 EditorGUILayout.PropertyField(serialized.renderPipelineSettings.decalSettings.perChannelMask, Styles.metalAndAOContent);
+                if (EditorGUI.EndChangeCheck())
+                {
+                    // Tell VFX
+                    ((HDRenderPipelineEditor)owner).needRefreshVfxWarnings = true;
+                }
 
                 EditorGUI.BeginChangeCheck();
                 EditorGUILayout.DelayedIntField(serialized.renderPipelineSettings.lightLoopSettings.maxDecalsOnScreen, Styles.maxDecalContent);
                 if (EditorGUI.EndChangeCheck())
                     serialized.renderPipelineSettings.lightLoopSettings.maxDecalsOnScreen.intValue = Mathf.Clamp(serialized.renderPipelineSettings.lightLoopSettings.maxDecalsOnScreen.intValue, 1, HDRenderPipeline.k_MaxDecalsOnScreen);
 
+                EditorGUI.BeginChangeCheck();
                 EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportDecalLayers, Styles.supportDecalLayersContent);
+                if (EditorGUI.EndChangeCheck())
+                {
+                    // Tell VFX
+                    ((HDRenderPipelineEditor)owner).needRefreshVfxWarnings = true;
+                }
             }
             --EditorGUI.indentLevel;
         }
@@ -925,26 +937,17 @@ static void Drawer_SectionRenderingUnsorted(SerializedHDRenderPipelineAsset seri
             // MSAA is an option that is only available in full forward but Camera can be set in Full Forward only. Thus MSAA have no dependency currently
             //Note: do not use SerializedProperty.enumValueIndex here as this enum not start at 0 as it is used as flags.
             bool msaaAllowed = true;
-            bool hasRayTracing = false;
             for (int index = 0; index < serialized.serializedObject.targetObjects.Length && msaaAllowed; ++index)
             {
-                var settings = (serialized.serializedObject.targetObjects[index] as HDRenderPipelineAsset).currentPlatformRenderPipelineSettings;
-                var litShaderMode = settings.supportedLitShaderMode;
-                bool rayTracedSupported = settings.supportRayTracing;
-                hasRayTracing |= rayTracedSupported;
-                msaaAllowed &= (litShaderMode == SupportedLitShaderMode.ForwardOnly || litShaderMode == SupportedLitShaderMode.Both) && !rayTracedSupported;
+                var litShaderMode = (serialized.serializedObject.targetObjects[index] as HDRenderPipelineAsset).currentPlatformRenderPipelineSettings.supportedLitShaderMode;
+                msaaAllowed &= litShaderMode == SupportedLitShaderMode.ForwardOnly || litShaderMode == SupportedLitShaderMode.Both;
             }
-
             using (new EditorGUI.DisabledScope(!msaaAllowed))
             {
                 ++EditorGUI.indentLevel;
                 EditorGUILayout.PropertyField(serialized.renderPipelineSettings.MSAASampleCount, Styles.MSAASampleCountContent);
                 --EditorGUI.indentLevel;
             }
-            if (hasRayTracing && serialized.renderPipelineSettings.MSAASampleCount.intValue != (int)MSAASamples.None)
-            {
-                EditorGUILayout.HelpBox(Styles.rayTracingMSAAUnsupported.text, MessageType.Info, wide: true);
-            }
 
             EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportMotionVectors, Styles.supportMotionVectorContent);
             EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportRuntimeDebugDisplay, Styles.supportRuntimeDebugDisplayContent);
@@ -1116,7 +1119,7 @@ static void Drawer_SectionMaterialUnsorted(SerializedHDRenderPipelineAsset seria
             }
 
             EditorGUILayout.PropertyField(serialized.renderPipelineSettings.lightLoopSettings.supportFabricConvolution, Styles.supportFabricBSDFConvolutionContent);
-            
+
             EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportMaskVolume, Styles.supportMaskVolumeContent);
             using (new EditorGUI.DisabledScope(!serialized.renderPipelineSettings.supportMaskVolume.boolValue))
             {