Fixed null reference exception in LookDev when setting the SRP to None #447

Author: pmavridis

com.unity.render-pipelines.core/CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed copy/pasting of Volume Components when loading a new scene
 - Fix LookDev's camera button layout.
 - Fix LookDev's layout vanishing on domain reload.
+- Fixed null reference exception in LookDev when setting the SRP to one not implementing LookDev (case 1245086)
 
 ## [7.3.0] - 2020-03-11
 

com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs

@@ -3,6 +3,8 @@
 using UnityEngine;
 using UnityEngine.UIElements;
 
+using RenderPipelineManager = UnityEngine.Rendering.RenderPipelineManager;
+
 namespace UnityEditor.Rendering.LookDev
 {
     /// <summary>Interface that must implement the viewer to communicate with the compositor and data management</summary>
@@ -680,6 +682,17 @@ void OnGUI()
                     rootVisualElement.styleSheets.Add(styleSheetLight);
             }
 
+            // [case 1245086] Guard in case the SRP asset is set to null (or to a not supported SRP) when the lookdev window is already open
+            // Note: After an editor reload, we might get a null OnUpdateRequestedInternal and null SRP for a couple of frames, hence the check. 
+            if (!LookDev.supported && OnUpdateRequestedInternal !=null)
+            {
+                // Print an error and close the Lookdev window (to avoid spamming the console)
+                Debug.LogError($"LookDev is not supported by this Scriptable Render Pipeline: "
+                    + (RenderPipelineManager.currentPipeline == null ? "No SRP in use" : RenderPipelineManager.currentPipeline.ToString()));
+                LookDev.Close();
+                return;
+            }
+
             OnUpdateRequestedInternal?.Invoke();
         }
     }