Fix minor issue with PreviousPropertyBinder (bis) #31

PaulDemeulenaere · julienf-unity · commit 3f567a863b21 · 2020-07-21T10:31:41.000+02:00
diff --git a/com.unity.visualeffectgraph/CHANGELOG.md b/com.unity.visualeffectgraph/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fix issue with strips outputs that could cause too many vertices to be renderered
 - SpawnIndex attribute returns correct value in update and outputs contexts
 - Disable Reset option in context menu for all VFXObject [Case 1251519](https://issuetracker.unity3d.com/product/unity/issues/guid/1251519/) & [Case 1251533](https://issuetracker.unity3d.com/product/unity/issues/guid/1251533/)
+- Avoid other NullReferenceException using property binders
 
 ## [7.5.0] - 2020-06-08
 
diff --git a/com.unity.visualeffectgraph/Runtime/Utilities/PropertyBinding/Implementation/VFXPreviousPositionBinder.cs b/com.unity.visualeffectgraph/Runtime/Utilities/PropertyBinding/Implementation/VFXPreviousPositionBinder.cs
@@ -14,7 +14,7 @@ class VFXPreviousPositionBinder : VFXBinderBase
         protected override void OnEnable()
         {
             base.OnEnable();
-            oldPosition = Target.position;
+            oldPosition = Target != null ? Target.position : Vector3.zero;
         }
 
         public override bool IsValid(VisualEffect component)

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class VFXPreviousPositionBinder : VFXBinderBase`
`14`	`14`	`protected override void OnEnable()`
`15`	`15`	`{`
`16`	`16`	`base.OnEnable();`
`17`		`- oldPosition = Target.position;`
	`17`	`+ oldPosition = Target != null ? Target.position : Vector3.zero;`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`public override bool IsValid(VisualEffect component)`