[PropertyBinder] Move Update to LateUpdate (#38)

PaulDemeulenaere · julienf-unity · commit 2e7166cebd7d · 2020-07-21T10:35:36.000+02:00
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/23_ParameterBinders.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/23_ParameterBinders.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:1cedef7c50997dd8d1325cfd340928cb779c9a97966f0c05b0809567e2ff15ed
-size 275967
+oid sha256:5934e988105d97eb0ba2552f80acf543b79eada3486688322a2c9adece5435ac
+size 272662
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/23_ParameterBinders.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/23_ParameterBinders.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:1cedef7c50997dd8d1325cfd340928cb779c9a97966f0c05b0809567e2ff15ed
-size 275967
+oid sha256:6da8a0ff172ec7c929e0f4f39183b1fbeb0f5b4a2cbcdbf22d5d6db44bc609fc
+size 272764
diff --git a/com.unity.visualeffectgraph/CHANGELOG.md b/com.unity.visualeffectgraph/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Disable Reset option in context menu for all VFXObject [Case 1251519](https://issuetracker.unity3d.com/product/unity/issues/guid/1251519/) & [Case 1251533](https://issuetracker.unity3d.com/product/unity/issues/guid/1251533/)
 - Avoid other NullReferenceException using property binders
 - Fix culture issues when generating attributes defines in shaders [Case 1222819](https://issuetracker.unity3d.com/product/unity/issues/guid/1222819/)
+- Move the VFXPropertyBinder from Update to LateUpdate [Case 1254340](https://issuetracker.unity3d.com/product/unity/issues/guid/1254340/)
 
 ## [7.5.0] - 2020-06-08
 
diff --git a/com.unity.visualeffectgraph/Runtime/Utilities/PropertyBinding/VFXPropertyBinder.cs b/com.unity.visualeffectgraph/Runtime/Utilities/PropertyBinding/VFXPropertyBinder.cs
@@ -44,7 +44,7 @@ private void Reset()
             ClearPropertyBinders();
         }
 
-        void Update()
+        void LateUpdate()
         {
             if (!m_ExecuteInEditor && Application.isEditor && !Application.isPlaying) return;
 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ private void Reset()`
`44`	`44`	`ClearPropertyBinders();`
`45`	`45`	`}`
`46`	`46`
`47`		`- void Update()`
	`47`	`+ void LateUpdate()`
`48`	`48`	`{`
`49`	`49`	`if (!m_ExecuteInEditor && Application.isEditor && !Application.isPlaying) return;`
`50`	`50`