Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

Author: iTris666

com.unity.visualeffectgraph/CHANGELOG.md

@@ -136,6 +136,7 @@ The version number for this package has increased due to a version update of a r
 - Make VisualEffect created from the GameObject menu have unique names [Case 1262989](https://issuetracker.unity3d.com/product/unity/issues/guid/1262989/)
 - Missing System Seed in new dynamic built-in operator.
 - Prefab highlight missing for initial event name toggle [Case 1263012](https://issuetracker.unity3d.com/product/unity/issues/guid/1263012/)
+- Optimize display of inspector when there is a lot of exposed VFX properties.
 - fixes the user created vfx default resources that were ignored unless loaded
 - fix crash when creating a loop in subgraph operators [Case 1251523](https://issuetracker.unity3d.com/product/unity/issues/guid/1251523/)
 - Normals with non uniform scales are correctly computed [Case 1246989](https://issuetracker.unity3d.com/product/unity/issues/guid/1246989/)

com.unity.visualeffectgraph/Editor/Inspector/VisualEffectEditor.cs

@@ -783,6 +783,9 @@ public override void OnInspectorGUI()
             GUI.enabled = true;
         }
 
+
+        Dictionary<string, Dictionary<string, SerializedProperty>> m_PropertyToProp = new Dictionary<string, Dictionary<string, SerializedProperty>>();
+
         protected virtual void DrawParameters(VisualEffectResource resource)
         {
             var component = (VisualEffect)target;
@@ -804,6 +807,25 @@ protected virtual void DrawParameters(VisualEffectResource resource)
                     graph.BuildParameterInfo();
                 }
 
+
+                m_PropertyToProp.Clear();
+
+                foreach (var sheetType in graph.m_ParameterInfo.Select(t => t.sheetType).Where(t=>!string.IsNullOrEmpty(t)).Distinct())
+                {
+                    var nameToIndices = new Dictionary<string, SerializedProperty>();
+
+                    var sourceVfxField = m_VFXPropertySheet.FindPropertyRelative(sheetType + ".m_Array");
+                    for (int i = 0; i < sourceVfxField.arraySize; ++i)
+                    {
+                        SerializedProperty sourceProperty = sourceVfxField.GetArrayElementAtIndex(i);
+                        var nameProperty = sourceProperty.FindPropertyRelative("m_Name").stringValue;
+
+                        nameToIndices[nameProperty] = sourceProperty;
+                    }
+                    m_PropertyToProp[sheetType] = nameToIndices;
+                }
+
+
                 if (graph.m_ParameterInfo != null)
                 {
                     bool newShowParameterCategory = ShowHeader(Contents.headerProperties, true, showPropertyCategory);
@@ -876,20 +898,10 @@ protected virtual void DrawParameters(VisualEffectResource resource)
                                 }
                             }
                             else if (!ignoreUntilNextCat)
-                            {
-                                //< Try find source property
-                                var sourceVfxField = m_VFXPropertySheet.FindPropertyRelative(parameter.sheetType + ".m_Array");
+                            {   
                                 SerializedProperty sourceProperty = null;
-                                for (int i = 0; i < sourceVfxField.arraySize; ++i)
-                                {
-                                    sourceProperty = sourceVfxField.GetArrayElementAtIndex(i);
-                                    var nameProperty = sourceProperty.FindPropertyRelative("m_Name").stringValue;
-                                    if (nameProperty == parameter.path)
-                                    {
-                                        break;
-                                    }
-                                    sourceProperty = null;
-                                }
+
+                                m_PropertyToProp[parameter.sheetType].TryGetValue(parameter.path, out sourceProperty);
 
                                 //< Prepare potential indirection
                                 bool wasNewProperty = false;
@@ -1032,6 +1044,7 @@ protected virtual void DrawParameters(VisualEffectResource resource)
                                     }
                                     if (wasNewProperty)
                                     {
+                                        var sourceVfxField = m_VFXPropertySheet.FindPropertyRelative(parameter.sheetType + ".m_Array");
                                         //We start editing a new exposed value which wasn't stored in this Visual Effect Component
                                         sourceVfxField.InsertArrayElementAtIndex(sourceVfxField.arraySize);
                                         var newEntry = sourceVfxField.GetArrayElementAtIndex(sourceVfxField.arraySize - 1);