Clone in the Asset folder when the original volume profile is in a re… #508

Author: fredericv-unity3d

com.unity.render-pipelines.core/Editor/Volume/VolumeEditor.cs

@@ -1,4 +1,7 @@
+using System.IO;
+using UnityEditor.PackageManager;
 using UnityEngine;
+using UnityEngine.Assertions;
 using UnityEngine.Rendering;
 
 namespace UnityEditor.Rendering
@@ -153,7 +156,13 @@ public override void OnInspectorGUI()
                     // Duplicate the currently assigned profile and save it as a new profile
                     var origin = profileRef;
                     var path = AssetDatabase.GetAssetPath(m_Profile.objectReferenceValue);
-                    path = AssetDatabase.GenerateUniqueAssetPath(path);
+
+                    path = IsAssetInReadOnlyPackage(path)
+                        // We may be in a read only package, in that case we need to clone the volume profile in an
+                        // editable area, such as the root of the project.
+                        ? AssetDatabase.GenerateUniqueAssetPath(Path.Combine("Assets", Path.GetFileName(path)))
+                        // Otherwise, duplicate next to original asset.
+                        : AssetDatabase.GenerateUniqueAssetPath(path);
 
                     var asset = Instantiate(origin);
                     asset.components.Clear();
@@ -202,5 +211,12 @@ public override void OnInspectorGUI()
 
             serializedObject.ApplyModifiedProperties();
         }
+
+        static bool IsAssetInReadOnlyPackage(string path)
+        {
+            Assert.IsNotNull(path);
+            var info = PackageManager.PackageInfo.FindForAssetPath(path);
+            return info != null && (info.source != PackageSource.Local && info.source != PackageSource.Embedded);
+        }
     }
 }

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -91,6 +91,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed Microshadow not working correctly in deferred with LightLayers
 - Tentative fix for missing include in depth of field shaders.
 - Fix an issue in reading the gbuffer for ray traced subsurface scattering (case 1248358).
+- Cloned volume profile from read only assets are created in the root of the project. (case 1154961)
 
 ### Changed
 - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history.