catch thrown errors in PPv2 Render (case 1221972) (#5218)

* catch thrown errors in PPv2 Render (case 1221972)

* Correction, we use 3.1.2 version currently

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Author: fredericv-unity3d

com.unity.postprocessing/CHANGELOG.md

@@ -6,8 +6,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [3.1.2] - 2021-02-06
 
-Version Updated
-The version number for this package has increased due to a version update of a related graphics package.
+### Fixed
+- Catch thrown errors in `PostProcessEffectRenderer`, preventing resources allocation leaks and crash (case 1221972)
 
 ## [3.1.1] - 2021-03-08
 

com.unity.postprocessing/PostProcessing/Runtime/PostProcessLayer.cs

@@ -607,7 +607,7 @@ void BuildCommandBuffers()
 
                 if (isScreenSpaceReflectionsActive)
                 {
-                    ssrRenderer.Render(context);
+                    ssrRenderer.RenderOrLog(context);
                     opaqueOnlyEffects--;
                     UpdateSrcDstForOpaqueOnly(ref srcTarget, ref dstTarget, context, cameraTarget, opaqueOnlyEffects);
                 }
@@ -1125,7 +1125,7 @@ void RenderList(List<SerializedBundleRef> list, PostProcessRenderContext context
             // If there's only one active effect, we can simply execute it and skip the rest
             if (count == 1)
             {
-                m_ActiveEffects[0].Render(context);
+                m_ActiveEffects[0].RenderOrLog(context);
             }
             else
             {
@@ -1150,7 +1150,7 @@ void RenderList(List<SerializedBundleRef> list, PostProcessRenderContext context
                 {
                     context.source = m_Targets[i];
                     context.destination = m_Targets[i + 1];
-                    m_ActiveEffects[i].Render(context);
+                    m_ActiveEffects[i].RenderOrLog(context);
                 }
 
                 cmd.ReleaseTemporaryRT(tempTarget1);
@@ -1373,15 +1373,15 @@ int RenderEffect<T>(PostProcessRenderContext context, bool useTempTarget = false
 
             if (!useTempTarget)
             {
-                effect.renderer.Render(context);
+                effect.renderer.RenderOrLog(context);
                 return -1;
             }
 
             var finalDestination = context.destination;
             var tempTarget = m_TargetPool.Get();
             context.GetScreenSpaceTemporaryRT(context.command, tempTarget, 0, context.sourceFormat);
             context.destination = tempTarget;
-            effect.renderer.Render(context);
+            effect.renderer.RenderOrLog(context);
             context.source = tempTarget;
             context.destination = finalDestination;
             return tempTarget;

com.unity.postprocessing/PostProcessing/Runtime/Utils/PostProcessEffectRendererExtensions.cs

@@ -0,0 +1,34 @@
+using System;
+
+namespace UnityEngine.Rendering.PostProcessing
+{
+    static class PostProcessEffectRendererExtensions
+    {
+        /// <summary>
+        /// Render with a try catch for all exception.
+        ///
+        /// If an exception occurs during the <see cref="PostProcessEffectRenderer.Render"/> call, it will be logged
+        /// and returned.
+        ///
+        /// Use this method instead of <see cref="PostProcessEffectRenderer.Render"/> in critical contexts
+        /// to avoid entering the exception flow.
+        /// </summary>
+        /// <param name="self">The renderer to render.</param>
+        /// <param name="context">A context object</param>
+        /// <returns></returns>
+        public static Exception RenderOrLog(this PostProcessEffectRenderer self, PostProcessRenderContext context)
+        {
+            try
+            {
+                self.Render(context);
+            }
+            catch (Exception e)
+            {
+                Debug.LogException(e);
+                return e;
+            }
+
+            return null;
+        }
+    }
+}