Skip to content

Commit 0392162

Browse files
PaulDemeulenaerejulienf-unity
authored andcommitted
[Fix] Deleted properties still visible in inspector (#231)
1 parent 5538291 commit 0392162

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

com.unity.visualeffectgraph/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
99
- Target GameObject attach button does not allow attaching a valid VFX if the last selection was invalid. [Case 1312178](https://issuetracker.unity3d.com/product/unity/issues/guid/1312178/)
1010
- Deleting flow edge between Init and Update throw an invalid opeation exception [Case 1315593](https://issuetracker.unity3d.com/product/unity/issues/guid/1315593/)
1111
- Having more than five GPU Event output leads to "unexpected token 'if" at compilation [Case 1323434](https://issuetracker.unity3d.com/product/unity/issues/guid/1323434/)
12+
- Deleted properties still show up in the inspector [Case 1320952](https://issuetracker.unity3d.com/product/unity/issues/guid/1320952/)
1213

1314
## [10.4.0] - 2020-01-26
1415
### Changed

com.unity.visualeffectgraph/Editor/Models/VFXGraph.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,10 @@ protected override void OnInvalidate(VFXModel model, VFXModel.InvalidationCause
480480

481481
base.OnInvalidate(model, cause);
482482

483-
if (model is VFXParameter || model is VFXSlot && (model as VFXSlot).owner is VFXParameter)
483+
if (model is VFXParameter //Something changed directly on VFXParameter (e.g. exposed state boolean)
484+
|| model is VFXSlot && (model as VFXSlot).owner is VFXParameter //Something changed on a slot owned by a VFXParameter (e.g. the default value)
485+
|| cause == VFXModel.InvalidationCause.kStructureChanged //A VFXParameter could have been removed
486+
)
484487
{
485488
BuildParameterInfo();
486489
}

0 commit comments

Comments
 (0)