Skip to content

Better test source root suggestion: remove standard "src/main/" suffix #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2022
Merged

Better test source root suggestion: remove standard "src/main/" suffix #1439

merged 4 commits into from
Dec 2, 2022

Conversation

@Vassiliy-Kudryashov
Copy link
Member

@Vassiliy-Kudryashov Vassiliy-Kudryashov commented Nov 29, 2022 •
edited
Loading

Description

Standard suffix src/main/ may spoil source root matching when we're tryining to chose the best one.

Fixes #1439

Type of Change

Please delete options that are not relevant.

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Manual Scenario

  1. Open UtBotJava project
  2. Try to generate tests for org.utbot.instrumentation.warmup.Warmup
  3. Expected test root utbot-framework/src/test is not the first in the list.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • New documentation is provided or existed one is altered
  • No new warnings

@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) November 30, 2022 09:10
@alisevych alisevych added this to the 2022.12 Release milestone Nov 30, 2022
@denis-fokin
Copy link
Collaborator

Please, extract testable API for source roots and provide unit tests for it to fixate the solution.

@alisevych alisevych added ctg-bug Issue is a bug comp-ui Improvements of plugin UI appearence and functionality labels Dec 1, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov requested review from EgorkaKulikov and removed request for Markoutte December 2, 2022 12:28
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit bae23c7 into main Dec 2, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/better_test_source_root_suggestion branch December 2, 2022 13:40
tamarinvs19 pushed a commit that referenced this pull request Dec 6, 2022
@Vassiliy-Kudryashov @tamarinvs19
Better test source root suggestion: remove standard "src/main/" suffix (
c32a6e6 
#1439)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes

Assignees

@Vassiliy-Kudryashov Vassiliy-Kudryashov

Labels

comp-ui Improvements of plugin UI appearence and functionality ctg-bug Issue is a bug

Projects

None yet

Milestone

2022.12 Release

Development

Successfully merging this pull request may close these issues.

5 participants

@Vassiliy-Kudryashov @denis-fokin @EgorkaKulikov @alisevych