Concrete executor reflection fix (#1332)

[child-process]
Setting Field.modifiers accessible fix.
Moving child process debug switch to UtSettings.

Author: Domonion

utbot-core/src/main/kotlin/org/utbot/common/Logging.kt

@@ -68,11 +68,20 @@ inline fun <T> LoggerWithLogMethod.bracket(
     }
 }
 
-inline fun <T> KLogger.catch(block: () -> T): T? {
+inline fun <T> KLogger.catchException(block: () -> T): T? {
     return try {
         block()
     } catch (e: Throwable) {
         this.error(e) { "Isolated" }
         null
     }
 }
+
+inline fun <T> KLogger.logException(block: () -> T): T {
+    return try {
+        block()
+    } catch (e: Throwable) {
+        this.error("Exception occurred", e)
+        throw e
+    }
+}

utbot-core/src/main/kotlin/org/utbot/common/ReflectionUtil.kt

@@ -37,6 +37,10 @@ object Reflection {
     fun setModifiers(field: Field, modifiers: Int) {
         modifiersField.set(field, modifiers)
     }
+
+    fun isModifiersAccessible(): Boolean {
+        return modifiersField.isAccessible
+    }
 }
 
 inline fun <R> AccessibleObject.withAccessibility(block: () -> R): R {

utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt

@@ -291,6 +291,21 @@ object UtSettings : AbstractSettings(
      */
     var runIdeaProcessWithDebug by getBooleanProperty(false)
 
+    /**
+     * If true, runs the child process with the ability to attach a debugger.
+     *
+     * To debug the child process, set the breakpoint in the childProcessRunner.start() line
+     * and in the child process's main function and run the main process.
+     * Then run the remote JVM debug configuration in IDEA.
+     * If you see the message in console about successful connection, then
+     * the debugger is attached successfully.
+     * Now you can put the breakpoints in the child process and debug
+     * both processes simultaneously.
+     *
+     * @see [org.utbot.instrumentation.process.ChildProcessRunner.cmds]
+     */
+    var runChildProcessWithDebug by getBooleanProperty(false)
+
     /**
      * Number of branch instructions using for clustering executions in the test minimization phase.
      */

utbot-framework/src/main/kotlin/org/utbot/engine/ValueConstructor.kt

@@ -1,5 +1,6 @@
 package org.utbot.engine
 
+import org.utbot.common.Reflection
 import org.utbot.common.invokeCatching
 import org.utbot.framework.plugin.api.ClassId
 import org.utbot.engine.util.lambda.CapturedArgument
@@ -239,8 +240,7 @@ class ValueConstructor {
             try {
                 declaredField.isAccessible = true
 
-                val modifiersField = Field::class.java.getDeclaredField("modifiers")
-                modifiersField.isAccessible = true
+                check(Reflection.isModifiersAccessible())
 
                 val target = mockTarget(fieldModel) {
                     FieldMockTarget(

utbot-framework/src/main/kotlin/org/utbot/framework/concrete/MockValueConstructor.kt

@@ -44,6 +44,7 @@ import kotlin.reflect.KClass
 import org.mockito.Mockito
 import org.mockito.stubbing.Answer
 import org.objectweb.asm.Type
+import org.utbot.common.Reflection
 import org.utbot.engine.util.lambda.CapturedArgument
 import org.utbot.engine.util.lambda.constructLambda
 import org.utbot.engine.util.lambda.constructStaticLambda
@@ -189,8 +190,7 @@ class MockValueConstructor(
             val accessible = declaredField.isAccessible
             declaredField.isAccessible = true
 
-            val modifiersField = Field::class.java.getDeclaredField("modifiers")
-            modifiersField.isAccessible = true
+            check(Reflection.isModifiersAccessible())
 
             val target = mockTarget(fieldModel) {
                 FieldMockTarget(fieldModel.classId.name, model.classId.name, UtConcreteValue(classInstance), fieldId.name)

utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/Settings.kt

@@ -14,21 +14,5 @@ object Settings {
 
     const val TRACE_ARRAY_SIZE: Int = 1 shl 20
 
-    // TODO: maybe add this guide to confluence?
-    /**
-     * If true, runs the child process with the ability to attach a debugger.
-     *
-     * To debug the child process, set the breakpoint in the childProcessRunner.start() line
-     * and in the child process's main function and run the main process.
-     * Then run the remote JVM debug configuration in IDEA.
-     * If you see the message in console about successful connection, then
-     * the debugger is attached successfully.
-     * Now you can put the breakpoints in the child process and debug
-     * both processes simultaneously.
-     *
-     * @see [org.utbot.instrumentation.process.ChildProcessRunner.cmds]
-     */
-    const val runChildProcessWithDebug = false
-
     var defaultConcreteExecutorPoolSize = 10
 }

utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/process/ChildProcessRunner.kt

@@ -20,7 +20,7 @@ class ChildProcessRunner {
     private val id = Random.nextLong()
     private var processSeqN = 0
     private val cmds: List<String> by lazy {
-        val debugCmd = listOfNotNull(DEBUG_RUN_CMD.takeIf { Settings.runChildProcessWithDebug })
+        val debugCmd = listOfNotNull(DEBUG_RUN_CMD.takeIf { UtSettings.runChildProcessWithDebug })
         val javaVersionSpecificArguments = OpenModulesContainer.javaVersionSpecificArguments
         val pathToJava = JdkInfoService.provide().path