Fix review comments

Author: EgorkaKulikov

utbot-core/src/main/kotlin/org/utbot/common/ClassLoaderUtil.kt

@@ -5,7 +5,7 @@ import java.net.URLClassLoader
 /**
  * Checks that the class given by its binary name can be loaded with given classLoader.
  */
-fun URLClassLoader.canLoad(classBinaryName: String): Boolean {
+fun URLClassLoader.hasOnClasspath(classBinaryName: String): Boolean {
     val classFqn = classBinaryName.replace('.', '/').plus(".class")
     return this.findResource(classFqn) != null
 }

utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/CoverageApi.kt

@@ -3,15 +3,15 @@ package org.utbot.framework.plugin.api
 /**
  * Represents a covered bytecode instruction.
  *
- * @param classFqn the fqn in internal form, i.e. com/rest/order/services/OrderService$InnerClass.
+ * @param internalName the fqn in internal form, i.e. com/rest/order/services/OrderService$InnerClass.
  * @param methodSignature the signature of the method.
  * @param lineNumber a number of the line in the source file.
  * @param id a unique identifier among all instructions in all classes.
  *
  * @see <a href="CONFLUENCE:Test+Minimization">Test minimization</a>
  */
 data class Instruction(
-    val classFqn: String,
+    val internalName: String,
     val methodSignature: String,
     val lineNumber: Int,
     val id: Long

utbot-framework-test/src/test/kotlin/org/utbot/sarif/SarifReportTest.kt

@@ -383,7 +383,7 @@ class SarifReportTest {
 
     private fun mockCoverage(mockExecution: UtExecution, lineNumber: Int, className: String) {
         Mockito.`when`(mockExecution.coverage?.coveredInstructions?.lastOrNull()?.lineNumber).thenReturn(1)
-        Mockito.`when`(mockExecution.coverage?.coveredInstructions?.lastOrNull()?.classFqn).thenReturn("Main")
+        Mockito.`when`(mockExecution.coverage?.coveredInstructions?.lastOrNull()?.internalName).thenReturn("Main")
         (mockExecution as? UtSymbolicExecution)?.let { mockSymbolicSteps(it, lineNumber, className) }
     }
 

utbot-framework/src/main/kotlin/org/utbot/framework/plugin/api/TestCaseGenerator.kt

@@ -387,7 +387,7 @@ open class TestCaseGenerator(
                 coverage.coveredInstructions
                     .filter { instruction ->
                         val instrClassName =
-                            instruction.classFqn
+                            instruction.internalName
                                 .also {
                                     val isInstrClassOnClassPath =
                                         isClassOnUserClasspathCache.getOrPut(it) {

utbot-framework/src/main/kotlin/org/utbot/sarif/SarifReport.kt

@@ -360,14 +360,14 @@ class SarifReport(
             ?: return listOf()
 
         val executionTrace = coveredInstructions.groupBy { instruction ->
-            instruction.classFqn to instruction.methodSignature // group by method
+            instruction.internalName to instruction.methodSignature // group by method
         }.map { (_, instructionsForOneMethod) ->
             instructionsForOneMethod.last() // we need only last to construct the stack trace
         }
 
         val sarifExecutionTrace = executionTrace.map { instruction ->
             resolveStackTraceElementByNames(
-                classFqn = instruction.classFqn.replace('/', '.'),
+                classFqn = instruction.internalName.replace('/', '.'),
                 methodName = instruction.methodSignature.substringBefore('('),
                 lineNumber = instruction.lineNumber
             )
@@ -508,7 +508,7 @@ class SarifReport(
         if (lastCoveredInstruction != null) {
             return Pair(
                 lastCoveredInstruction.lineNumber, // .lineNumber is one-based
-                lastCoveredInstruction.classFqn.replace('/', '.')
+                lastCoveredInstruction.internalName.replace('/', '.')
             )
         }
 

utbot-junit-contest/src/main/kotlin/org/utbot/contest/Statistics.kt

@@ -237,7 +237,7 @@ data class CoverageStatistic(val covered: Int, val total: Int)
 private fun CoverageInstructionsSet?.getCoverageInfo(classNames: Set<String>): CoverageStatistic = this?.run {
     CoverageStatistic(
         coveredInstructions.filter {
-            instr -> classNames.contains(instr.classFqn)
+            instr -> classNames.contains(instr.internalName)
         }.map { it.id }.distinct().size,
         totalInstructions.toInt()
     )

utbot-spring-commons/src/main/kotlin/org/utbot/spring/context/SpringContextWrapper.kt

@@ -5,7 +5,7 @@ import com.jetbrains.rd.util.warn
 import org.springframework.beans.factory.support.BeanDefinitionRegistry
 import org.springframework.context.ConfigurableApplicationContext
 import org.springframework.data.repository.CrudRepository
-import org.utbot.common.canLoad
+import org.utbot.common.hasOnClasspath
 import org.utbot.spring.api.context.ContextWrapper
 import org.utbot.spring.api.context.RepositoryDescription
 import java.net.URLClassLoader
@@ -47,7 +47,7 @@ class SpringContextWrapper(override val context: ConfigurableApplicationContext)
                 val clazz = getBean(name)::class.java
                 // here immediate hierarchy is enough because proxies are inherited directly
                 val immediateClazzHierarchy = clazz.interfaces + clazz.superclass + clazz
-                immediateClazzHierarchy.any { clazz -> userSourcesClassLoader.canLoad(clazz.name) }
+                immediateClazzHierarchy.any { clazz -> userSourcesClassLoader.hasOnClasspath(clazz.name) }
             }
             .toSet()
 
@@ -75,7 +75,7 @@ class SpringContextWrapper(override val context: ConfigurableApplicationContext)
             val repositoryClass = repositoryBean.bean::class.java
             val repositoryClassName = repositoryClass
                 .interfaces
-                .filter { clazz -> userSourcesClassLoader.canLoad(clazz.name) }
+                .filter { clazz -> userSourcesClassLoader.hasOnClasspath(clazz.name) }
                 .filter { CrudRepository::class.java.isAssignableFrom(it) }
                 .map { it.name }
                 .firstOrNull() ?: CrudRepository::class.java.name