Skip to content

Conversation

@Lana243
Copy link
Collaborator

@Lana243 Lana243 commented Oct 31, 2022

Closes #514

To fix the problem extern variable declaration was added to KLEE wrapper and gtest file.

@alexey-utkin
Copy link
Collaborator

Seems currenly we get a problem with tests

[  FAILED  ] 36 tests, listed below:
[  FAILED  ] Regression_Test.Incomplete_Array_Type
[  FAILED  ] Regression_Test.Global_Char_Array
[  FAILED  ] Regression_Test.Global_Array_Of_Pointers
[  FAILED  ] Server_Test.Globals
[  FAILED  ] Syntax_Test.Pointer_Return_Test_1
[  FAILED  ] Syntax_Test.Pointer_Return_Test_2
[  FAILED  ] Syntax_Test.Pointer_Return_Test_3
[  FAILED  ] Syntax_Test.Return_Long_Long_Array
[  FAILED  ] Syntax_Test.Structs_With_Arrays_Parameter_Test_1
[  FAILED  ] Syntax_Test.Structs_With_Arrays_Return_Test_1
[  FAILED  ] Syntax_Test.Struct_With_Double_Pointer
[  FAILED  ] Syntax_Test.Return_Const_Char_Pointer_1
[  FAILED  ] Syntax_Test.Return_Const_Char_Pointer_2
[  FAILED  ] Syntax_Test.Return_Const_Struct_Pointer_1
[  FAILED  ] Syntax_Test.Return_Int_Array
[  FAILED  ] Syntax_Test.Return_Void2D
[  FAILED  ] Syntax_Test.Return_Null_Pointer
[  FAILED  ] Syntax_Test.Return_Null_Struct
[  FAILED  ] Syntax_Test.Multi_Array_1
[  FAILED  ] Syntax_Test.Multi_Pointer_1
[  FAILED  ] Syntax_Test.Struct_With_Multi_Array
[  FAILED  ] Syntax_Test.Multi_Pointer_Struct
[  FAILED  ] Syntax_Test.Return_Struct_With_Array
[  FAILED  ] Syntax_Test.Sum_Matrix
[  FAILED  ] Syntax_Test.Count_Dashes
[  FAILED  ] Syntax_Test.Accept_Const_Int_Pointer_Pointer
[  FAILED  ] Syntax_Test.UnnamedTypeUnionField
[  FAILED  ] Syntax_Test.UnnamedTypeStructField
[  FAILED  ] Syntax_Test.AnonymousUnionField
[  FAILED  ] Syntax_Test.AnonymousStructField
[  FAILED  ] Syntax_Test.Pass_Forward_Decl
[  FAILED  ] Syntax_Test.Duplicate_Struct
[  FAILED  ] Syntax_Test.Global_Unnamed_Variable
[  FAILED  ] Syntax_Test.bitfields_check_simple_signed_str
[  FAILED  ] Syntax_Test.bitfields_check_fields_bounds
[  FAILED  ] Syntax_Test.bitfields_check_unnamed

@Lana243 Lana243 force-pushed the Lana243/extern-vars branch from 50d9e17 to 467a2c6 Compare November 21, 2022 14:46
@Lana243 Lana243 requested review from sava-cska and removed request for alexey-utkin November 23, 2022 11:07

writeAccessPrivateMacros(typesHandler, tests, false);

CollectionUtils::apply(tests.externVariables, [this](const Tests::TypeAndVarName &var) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as server/src/printers/TestsPrinter.cpp:66


writeAccessPrivateMacros(typesHandler, tests, false);

CollectionUtils::apply(tests.externVariables, [this](const Tests::TypeAndVarName &var) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless apply

@Lana243 Lana243 requested a review from ladisgin November 28, 2022 10:44
@Lana243 Lana243 merged commit 54ca965 into main Nov 28, 2022
@sava-cska sava-cska deleted the Lana243/extern-vars branch November 28, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not generate tests with extern variable [BUG]

5 participants