start refactoring after review

Author: Vladislav Kalugin

server/src/Server.cpp

@@ -187,151 +187,6 @@ Status Server::TestsGenServiceImpl::CreateTestsCoverageAndResult(
     return status;
 }
 
-// TODO: move to testgen base classes
-Status Server::TestsGenServiceImpl::ProcessBaseTestRequest(BaseTestGen &testGen,
-                                                           TestsWriter *testsWriter) {
-    try {
-        MEASURE_FUNCTION_EXECUTION_TIME
-        auto preprocessingStartTime = std::chrono::steady_clock::now();
-        types::TypesHandler::SizeContext sizeContext;
-
-        static std::string logMessage = "Traversing sources AST tree and fetching declarations.";
-        LOG_S(DEBUG) << logMessage;
-        Fetcher fetcher(Fetcher::Options::Value::ALL,
-                        testGen.buildDatabase->compilationDatabase, testGen.tests, &testGen.types,
-                        &sizeContext.pointerSize, &sizeContext.maximumAlignment,
-                        testGen.compileCommandsJsonPath, false);
-        fetcher.fetchWithProgress(testGen.progressWriter, logMessage);
-        SourceToHeaderRewriter(testGen.projectContext, testGen.buildDatabase->compilationDatabase,
-                               fetcher.getStructsToDeclare(), testGen.serverBuildDir)
-            .generateTestHeaders(testGen.tests, testGen.progressWriter);
-        types::TypesHandler typesHandler{ testGen.types, sizeContext };
-        testGen.progressWriter->writeProgress("Generating stub files", 0.0);
-        StubGen stubGen(testGen);
-
-        Synchronizer synchronizer(&testGen, &stubGen, &sizeContext);
-        synchronizer.synchronize(typesHandler);
-
-        std::shared_ptr<LineInfo> lineInfo = nullptr;
-        auto lineTestGen = dynamic_cast<LineTestGen *>(&testGen);
-
-        if (lineTestGen != nullptr) {
-            if (isSameType<ClassTestGen>(testGen) && Paths::isHeaderFile(lineTestGen->filePath)) {
-                BordersFinder classFinder(lineTestGen->filePath, lineTestGen->line,
-                                          lineTestGen->buildDatabase->compilationDatabase,
-                                          lineTestGen->compileCommandsJsonPath);
-                classFinder.findClass();
-                lineInfo = std::make_shared<LineInfo>(classFinder.getLineInfo());
-                lineInfo->filePath = lineTestGen->getSourcePath();
-                CollectionUtils::erase_if(testGen.tests.at(lineInfo->filePath).methods,
-                                          [&lineInfo](const tests::Tests::MethodDescription &methodDescription) {
-                                              return methodDescription.isClassMethod() &&
-                                                     methodDescription.classObj->type.typeName() != lineInfo->scopeName;
-                                          });
-            } else {
-                lineInfo = getLineInfo(*lineTestGen);
-                CollectionUtils::erase_if(testGen.tests.at(lineInfo->filePath).methods,
-                                          [&lineInfo](const auto &methodDescription) {
-                                              return methodDescription.name != lineInfo->methodName;
-                                          });
-            }
-        }
-
-        FeaturesFilter::filter(testGen.settingsContext, typesHandler, testGen.tests);
-        StubsCollector(typesHandler).collect(testGen.tests);
-
-        PathSubstitution pathSubstitution = {};
-        if (lineTestGen != nullptr) {
-            lineInfo->forMethod = isSameType<FunctionTestGen>(testGen);
-            lineInfo->forClass = isSameType<ClassTestGen>(testGen);
-            lineInfo->forAssert = isSameType<AssertionTestGen>(testGen);
-            if (lineTestGen->needToAddPathFlag()) {
-                LOG_S(DEBUG) << "Added test line flag for file " << lineInfo->filePath;
-                fs::path flagFilePath =
-                    printer::KleePrinter(&typesHandler, nullptr, Paths::getSourceLanguage(lineInfo->filePath))
-                        .addTestLineFlag(lineInfo, lineInfo->forAssert, testGen.projectContext);
-                pathSubstitution = { lineTestGen->filePath, flagFilePath };
-            }
-        }
-        auto generator = std::make_shared<KleeGenerator>(testGen, typesHandler, pathSubstitution);
-
-        ReturnTypesFetcher returnTypesFetcher{ &testGen };
-        returnTypesFetcher.fetch(testGen.progressWriter, synchronizer.getAllFiles());
-        LOG_S(DEBUG) << "Temporary build directory path: " << testGen.serverBuildDir;
-        generator->buildKleeFiles(testGen.tests, lineInfo);
-        generator->handleFailedFunctions(testGen.tests);
-        testGen.progressWriter->writeProgress("Building files", 0.0);
-        Linker linker{ testGen, stubGen, lineInfo, generator };
-        linker.prepareArtifacts();
-        auto testMethods = linker.getTestMethods();
-        KleeRunner kleeRunner{ testGen.projectContext, testGen.settingsContext,
-                               testGen.serverBuildDir };
-        bool interactiveMode = (dynamic_cast<ProjectTestGen *>(&testGen) != nullptr);
-        auto generationStartTime = std::chrono::steady_clock::now();
-        StatsUtils::TestsGenerationStatsFileMap generationStatsMap(testGen.projectContext,
-                std::chrono::duration_cast<std::chrono::milliseconds>(generationStartTime - preprocessingStartTime));
-        kleeRunner.runKlee(testMethods, testGen.tests, generator, testGen.methodNameToReturnTypeMap,
-                           lineInfo, testsWriter, testGen.isBatched(), interactiveMode, generationStatsMap);
-        LOG_S(INFO) << "KLEE time: " << std::chrono::duration_cast<std::chrono::milliseconds>
-                        (generationStatsMap.getTotal().kleeStats.getKleeTime()).count() << " ms\n";
-        printer::CSVPrinter printer = generationStatsMap.toCSV();
-        FileSystemUtils::writeToFile(Paths::getGenerationStatsCSVPath(testGen.projectContext),
-                                     printer.getStream().str());
-        LOG_S(INFO) << StringUtils::stringFormat("See generation stats here: %s",
-                                                 Paths::getGenerationStatsCSVPath(testGen.projectContext));
-    } catch (const ExecutionProcessException &e) {
-        std::string command = e.what();
-        return Status(StatusCode::FAILED_PRECONDITION,
-                      "Executing command\n" + command.substr(0, 100) +
-                          "...\nfailed. See more info in console logs.");
-    } catch (const NoTestGeneratedException &e) {
-        return Status(StatusCode::FAILED_PRECONDITION, e.what());
-    } catch (const CancellationException &e) {
-        return Status::CANCELLED;
-    } catch (const NoSuchTypeException &e) {
-        return Status(StatusCode::UNIMPLEMENTED, e.what());
-    } catch (const EnvironmentException &e) {
-        return Status(StatusCode::FAILED_PRECONDITION, e.what());
-    } catch (const CompilationDatabaseException &e) {
-        return Status(StatusCode::FAILED_PRECONDITION, e.what());
-    } catch (const FileNotPresentedInCommandsException &e) {
-        return Status(StatusCode::FAILED_PRECONDITION,
-                      FileNotPresentedInCommandsException::MESSAGE, e.getFilePath());
-    } catch (const FileNotPresentedInArtifactException &e) {
-        return Status(StatusCode::FAILED_PRECONDITION,
-                      FileNotPresentedInArtifactException::MESSAGE, e.getFilePath());
-    } catch (const BaseException &e) {
-        return Status(StatusCode::INTERNAL, e.what());
-    }
-    return Status::OK;
-}
-
-std::shared_ptr<LineInfo> Server::TestsGenServiceImpl::getLineInfo(LineTestGen &lineTestGen) {
-    BordersFinder stmtFinder(lineTestGen.filePath, lineTestGen.line,
-                             lineTestGen.buildDatabase->compilationDatabase,
-                             lineTestGen.compileCommandsJsonPath);
-    stmtFinder.findFunction();
-    if (!stmtFinder.getLineInfo().initialized) {
-        throw NoTestGeneratedException(
-            "Maybe you tried to generate tests placing cursor on invalid line.");
-    }
-    if (isSameType<AssertionTestGen>(lineTestGen) &&
-        !StringUtils::contains(stmtFinder.getLineInfo().stmtString, "assert")) {
-        throw NoTestGeneratedException("No assert found on this line.");
-    }
-    auto lineInfo = std::make_shared<LineInfo>(stmtFinder.getLineInfo());
-    if (auto predicateInfo = dynamic_cast<PredicateTestGen *>(&lineTestGen)) {
-        lineInfo->predicateInfo = LineInfo::PredicateInfo(
-            { predicateInfo->type, predicateInfo->predicate, predicateInfo->returnValue });
-    }
-    auto &methods = lineTestGen.tests.at(lineInfo->filePath).methods;
-    CollectionUtils::erase_if(methods, [&lineInfo](auto const &method) {
-        return (lineInfo->forMethod && method.name != lineInfo->methodName) ||
-               (lineInfo->forClass && method.isClassMethod() && method.classObj->type.typeName() != lineInfo->scopeName);
-    });
-    return lineInfo;
-}
-
 std::string extractMessage(const loguru::Message &message) {
     return std::string(message.preamble) + std::string(message.prefix) + message.message + "\n";
 }
@@ -498,7 +353,7 @@ Status Server::TestsGenServiceImpl::GetFunctionReturnType(ServerContext *context
     MEASURE_FUNCTION_EXECUTION_TIME
 
     LineTestGen testGen(request->linerequest(), nullptr, testMode);
-    auto lineInfo = getLineInfo(testGen);
+    auto lineInfo = testGen.getLineInfo();
     const auto &type = lineInfo->functionReturnType;
     testsgen::ValidationType typeResponse = testsgen::UNSUPPORTED;
     if (types::TypesHandler::isIntegerType(type)) {