Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tag and npm version out of sync #336

Open
QYuQianchen opened this issue Feb 24, 2023 · 3 comments
Open

Release tag and npm version out of sync #336

QYuQianchen opened this issue Feb 24, 2023 · 3 comments

Comments

@QYuQianchen
Copy link

Description

NPM package is release at version v1.4.3 https://www.npmjs.com/package/@uniswap/v3-periphery, while the release tag on Github is only v1.3.0.

Keeping them in sync ensures that the same code gets imported in hardhat (via npm) and in foundry (via Github)

Possible solution

Add a github action that releases to npm automatically on tag push (props to @delaaxe for the idea)

@drLis
Copy link

drLis commented Apr 28, 2023

Agree. Please update tags for solidity 0.8 branchs, because all we need it for correct working of brownie pm manager (can works only with tag)

@startswithaj
Copy link

Is there a plan to release 1.4.2-solc-0.8 version to NPM?

@startswithaj
Copy link

v3-core has a solc 8 version released:
Screenshot 2023-07-02 at 12 39 05 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants