feat: Add support for Sepolia #6610

cbachmeier · 2023-05-19T22:52:05Z

Description

Adds Sepolia tesnet w/ chain id: 11155111, important resources, and relevant contract addresses
Updates token-list, SOR, and UR
Search, Token Discover page, and Token Details pages all show mainnet values, same as we do for goerli

Slack thread:

Relevant docs:

Screen capture

Successful Pool

Successful swap

Test plan

QA (ie manual testing)

vercel · 2023-05-19T22:52:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
interface	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 1, 2023 9:55pm
interface-node18	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 1, 2023 9:55pm

cypress · 2023-05-19T23:02:48Z

Passing run #11581 ↗︎

0	69	8	0	0

Details:

feat: Add support for Sepolia
Project: Uniswap Interface	Commit: `de7b2252dc`
Status: Passed	Duration: 03:39 💡
Started: Jun 1, 2023 9:59 PM	Ended: Jun 1, 2023 10:02 PM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

codecov · 2023-05-19T23:07:24Z

Codecov Report

Patch coverage: 90.90% and project coverage change: -0.92 ⚠️

Comparison is base (8954aa7) 60.40% compared to head (715f213) 59.48%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6610      +/-   ##
==========================================
- Coverage   60.40%   59.48%   -0.92%     
==========================================
  Files         732      732              
  Lines       21463    21473      +10     
  Branches     7091     7092       +1     
==========================================
- Hits        12964    12773     -191     
- Misses       8425     8624     +199     
- Partials       74       76       +2

Flag	Coverage Δ
e2e-tests	`59.47% <90.90%> (-1.09%)`	⬇️
unit-tests	`22.74% <66.66%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/constants/chainInfo.ts	`88.88% <ø> (ø)`
src/constants/chains.ts	`100.00% <ø> (ø)`
src/constants/networks.ts	`75.00% <ø> (ø)`
src/constants/providers.ts	`100.00% <ø> (ø)`
src/constants/routing.ts	`100.00% <ø> (ø)`
src/graphql/data/util.tsx	`18.51% <ø> (ø)`
src/hooks/useERC20Permit.ts	`33.33% <ø> (ø)`
src/utils/anonymizeLink.ts	`90.00% <ø> (ø)`
src/utils/getExplorerLink.ts	`50.00% <ø> (ø)`
src/utils/switchChain.ts	`5.00% <0.00%> (-0.27%)`	⬇️
... and 3 more

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

socket-security · 2023-05-23T17:40:52Z

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package	Version Diff	Added Capability Access	`+/-` Transitive Count	Publisher
@uniswap/universal-router-sdk@1.5.1	1.3.9...1.5.1	None	`+1/-4`	alicehenshaw
@uniswap/default-token-list@9.6.0	9.4.0...9.6.0	None	`+0/-0`	matteen
@uniswap/smart-order-router@3.12.1	3.6.1...3.12.1	environment	`+2/-6`	mikeki

🚮 Removed packages: @uniswap/sdk-core@3.2.2

JFrankfurt · 2023-06-01T16:01:23Z

After adding liquidity to the ETH:UNI 0.3% pool I got this message when my transaction confirmed. I don't thiiiink it's related? Prior to the transaction the .3 pool indicated it had already been created.

cbachmeier · 2023-06-01T16:37:05Z

I'm going through #6036 to evaluate parity, it looks like you may want to add: sepolia.etherscan.io to src/utils/anonymizeLink.ts and src/utils/getExplorerLink.ts

Sepolia is already added to BLOCK_EXPLORER_PREFIXES in getExplorerLink and thanks for the callout for anonymizeLink, I've Sepolia to it

cbachmeier · 2023-06-01T16:40:18Z

After adding liquidity to the ETH:UNI 0.3% pool I got this message when my transaction confirmed. I don't thiiiink it's related? Prior to the transaction the .3 pool indicated it had already been created.

@JFrankfurt Are you able to replicate? I can't seem to get the same behaviour for the same pool.

cmcewen

wooooot!

cmcewen · 2023-06-02T00:03:53Z

src/constants/addresses.ts

 const ARBITRUM_GOERLI_TICK_LENS_ADDRESSES = '0xb52429333da969a0C79a60930a4Bf0020E5D1DE8'

+// sepolia v3 addresses
+const SEPOLIA_V3_CORE_FACTORY_ADDRESSES = '0x0227628f3F023bb0B980b67D528571c95c6DaC1c'


not relevant to PR - but kinda surprised these don't live in the SDK

This does feel like a process that could be part of the protocol deployment scripts to save a lot of manual entry.

cmcewen · 2023-06-02T00:04:50Z

src/constants/tokens.ts

-  [SupportedChainId.GOERLI]: new Token(SupportedChainId.GOERLI, UNI_ADDRESS[5], 18, 'UNI', 'Uniswap'),
+  [SupportedChainId.MAINNET]: new Token(
+    SupportedChainId.MAINNET,
+    UNI_ADDRESS[SupportedChainId.MAINNET],


Charles Bachmeier added 4 commits May 19, 2023 11:22

initial sepolia const setup

dd6c282

uni sepolia

569c7d7

add more consts for sepolia

6fc6d39

better comment

8d08970

cbachmeier had a problem deploying to false May 19, 2023 22:52 — with GitHub Actions Failure

cbachmeier temporarily deployed to false May 19, 2023 22:52 — with GitHub Actions Inactive

cbachmeier had a problem deploying to false May 19, 2023 22:52 — with GitHub Actions Failure

cbachmeier temporarily deployed to false May 19, 2023 22:56 — with GitHub Actions Inactive

vercel bot deployed to Preview May 19, 2023 22:56 View deployment

Charles Bachmeier added 2 commits May 23, 2023 10:32

Merge branch 'main' into cab/sepolia

e517d84

upgrade ur sdk

fa8e9e1

cbachmeier had a problem deploying to false May 23, 2023 17:35 — with GitHub Actions Failure

cbachmeier temporarily deployed to false May 23, 2023 17:35 — with GitHub Actions Inactive

cbachmeier had a problem deploying to false May 23, 2023 17:35 — with GitHub Actions Failure

need to request BE add Ethereum sepolia to supported chains

116a106

vercel bot deployed to Preview – interface May 23, 2023 17:40 View deployment

vercel bot deployed to Preview – interface-node18 May 23, 2023 17:41 View deployment

cbachmeier temporarily deployed to false May 23, 2023 17:45 — with GitHub Actions Inactive

cbachmeier had a problem deploying to false May 23, 2023 17:45 — with GitHub Actions Failure

cbachmeier temporarily deployed to false May 23, 2023 17:45 — with GitHub Actions Inactive

add to anonymizeLink

1295085

vercel bot deployed to Preview – interface June 1, 2023 16:37 View deployment

vercel bot deployed to Preview – interface-node18 June 1, 2023 16:38 View deployment

bump core-sdk

723f931

vercel bot deployed to Preview – interface-node18 June 1, 2023 17:28 View deployment

vercel bot deployed to Preview – interface June 1, 2023 17:28 View deployment

deduplicate

01bdf12

just-toby approved these changes Jun 1, 2023

View reviewed changes

vercel bot deployed to Preview – interface-node18 June 1, 2023 17:34 View deployment

vercel bot deployed to Preview – interface June 1, 2023 17:35 View deployment

Charles Bachmeier added 2 commits June 1, 2023 10:59

Merge branch 'main' into cab/sepolia

88065b5

Merge branch 'main' into cab/sepolia

2238c08

vercel bot deployed to Preview – interface June 1, 2023 18:25 View deployment

vercel bot deployed to Preview – interface-node18 June 1, 2023 18:25 View deployment

Merge branch 'main' into cab/sepolia

ebf29ab

vercel bot deployed to Preview – interface-node18 June 1, 2023 21:06 View deployment

vercel bot deployed to Preview – interface June 1, 2023 21:07 View deployment

update infura fork block

715f213

vercel bot deployed to Preview – interface-node18 June 1, 2023 21:34 View deployment

vercel bot deployed to Preview – interface June 1, 2023 21:34 View deployment

add comment

de7b225

vercel bot deployed to Preview – interface June 1, 2023 21:55 View deployment

vercel bot deployed to Preview – interface-node18 June 1, 2023 21:55 View deployment

cmcewen approved these changes Jun 2, 2023

View reviewed changes

cbachmeier merged commit 1bc6eb9 into main Jun 2, 2023

cbachmeier deleted the cab/sepolia branch June 2, 2023 00:57

tinaszheng mentioned this pull request Jun 2, 2023

feat: Upgrade @uniswap/universal-router-sdk for UniversalRouter version 1.2 #6658

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add support for Sepolia #6610

feat: Add support for Sepolia #6610

Uh oh!

cbachmeier commented May 19, 2023 •

edited

Loading

Uh oh!

vercel bot commented May 19, 2023 •

edited

Loading

Uh oh!

cypress bot commented May 19, 2023 •

edited

Loading

Uh oh!

codecov bot commented May 19, 2023 •

edited

Loading

Uh oh!

socket-security bot commented May 23, 2023 •

edited

Loading

Uh oh!

JFrankfurt commented Jun 1, 2023

Uh oh!

cbachmeier commented Jun 1, 2023

Uh oh!

cbachmeier commented Jun 1, 2023

Uh oh!

cmcewen left a comment

Uh oh!

cmcewen Jun 2, 2023

Uh oh!

cbachmeier Jun 2, 2023

Uh oh!

cmcewen Jun 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: Add support for Sepolia #6610

feat: Add support for Sepolia #6610

Uh oh!

Conversation

cbachmeier commented May 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screen capture

Test plan

QA (ie manual testing)

Uh oh!

vercel bot commented May 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cypress bot commented May 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Passing run #11581 ↗︎

Uh oh!

codecov bot commented May 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

socket-security bot commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JFrankfurt commented Jun 1, 2023

Uh oh!

cbachmeier commented Jun 1, 2023

Uh oh!

cbachmeier commented Jun 1, 2023

Uh oh!

cmcewen left a comment

Choose a reason for hiding this comment

Uh oh!

cmcewen Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

cbachmeier Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

cmcewen Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cbachmeier commented May 19, 2023 •

edited

Loading

vercel bot commented May 19, 2023 •

edited

Loading

cypress bot commented May 19, 2023 •

edited

Loading

codecov bot commented May 19, 2023 •

edited

Loading

socket-security bot commented May 23, 2023 •

edited

Loading