Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balance is rounded to 4 significant figures in swap #1442

Open
BOR4 opened this issue May 6, 2021 · 3 comments
Open

balance is rounded to 4 significant figures in swap #1442

BOR4 opened this issue May 6, 2021 · 3 comments
Assignees
Labels
bug Something isn't working p1 Great to have, implement first thing after p0s

Comments

@BOR4
Copy link

BOR4 commented May 6, 2021

Bug Description
Community member contacted us about his 11377 USDT balance showing as 11370 in app.

Steps to Reproduce

image

Unfortunately don't have more info on it.

Expected Behavior
Correct balance is shown

@BOR4 BOR4 added the bug Something isn't working label May 6, 2021
@moodysalem
Copy link
Contributor

indeed this is just rounding, we should just do better to format large amounts (e.g. show 11.38k instead of 11377)

@moodysalem moodysalem changed the title Possible rounding issue in "Swap" balance is rounded to 4 significant figures in swap May 7, 2021
@moodysalem moodysalem added the p1 Great to have, implement first thing after p0s label May 7, 2021
@asood123
Copy link

asood123 commented May 7, 2021

+1 for larger number format with a tooltip to show the actual amount

@ianlapham
Copy link
Member

indeed this is just rounding, we should just do better to format large amounts (e.g. show 11.38k instead of 11377)

@moodysalem Is there some lightweight library thats good for this? In info use numeral but not sure if we wanna go that far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 Great to have, implement first thing after p0s
Projects
None yet
Development

No branches or pull requests

4 participants