Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usd values after swap price quote #1413

Open
callil opened this issue May 1, 2021 · 3 comments
Open

Add usd values after swap price quote #1413

callil opened this issue May 1, 2021 · 3 comments
Assignees
@ianlapham
Labels
design Needs design work improvement Improves the ux p1 Great to have, implement first thing after p0s

Comments

@callil
Copy link
Collaborator

callil commented May 1, 2021

Should read 1 ETH = N DAI ($USD)
@moodysalem
Copy link
Contributor

space is pretty tight here
image

@NoahZinsmeister NoahZinsmeister transferred this issue from another repository May 5, 2021
@callil callil added improvement Improves the ux p1 Great to have, implement first thing after p0s labels May 6, 2021
@callil
Copy link
Collaborator Author

callil commented May 6, 2021

We might consider truncating the values to something like <0.00001 in this case? Another option is to add a tooltip state to the price.

@callil callil added the design Needs design work label May 6, 2021
@asood123 asood123 assigned ianlapham and unassigned moodysalem May 7, 2021
@asood123
Copy link

asood123 commented May 7, 2021

Another number formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianlapham ianlapham

Labels
design Needs design work improvement Improves the ux p1 Great to have, implement first thing after p0s
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@callil @asood123 @moodysalem @ianlapham