Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Doesn't work when served from localhost IPFS. #1297

Open
MicahZoltu opened this issue Jan 30, 2021 · 3 comments
Open

UI Doesn't work when served from localhost IPFS. #1297

MicahZoltu opened this issue Jan 30, 2021 · 3 comments
Labels
bug Something isn't working p0 Very important to fix

Comments

@MicahZoltu
Copy link
Contributor

Bug Description
When accessing the page via localhost IPFS (e.g., IPFS Desktop), nothing works. The issue is that infura appears to be blocking requests from localhost origins.

Steps to Reproduce

  1. Install IPFS Companion and IPFS Desktop.
  2. Navigate to https://app.uniswap.org
  3. Notice that you are redirected to http://app.uniswap.org.ipns.localhost:8080
  4. Notice that you are unable to get the price of any pairs.

Expected Behavior
The website works properly when accessed via localhost.

Additional Context
Probably related to #1091.

@MicahZoltu MicahZoltu added the bug Something isn't working label Jan 30, 2021
@MicahZoltu
Copy link
Contributor Author

Allowing a custom JSON-RPC provider setting would at least allow one to work around this issue without having to disable IPFS-Companion.

@moodysalem moodysalem added the p1 Great to have, implement first thing after p0s label Jan 30, 2021
@moodysalem
Copy link
Contributor

Simplest solution is to whitelist our Infura key to work for IPFS origin CIDs from the GitHub releases

@moodysalem moodysalem added p0 Very important to fix and removed p1 Great to have, implement first thing after p0s labels Jan 30, 2021
@MicahZoltu
Copy link
Contributor Author

This bug is still present and still incredibly frustrating. I can't use WalletConnect at all when browsing via localhost IPFS because Infura is used for network connection (which cannot be changed) and it doesn't work from localhost.

Tentatively re-opening since it was closed without comment.

@MicahZoltu MicahZoltu reopened this Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0 Very important to fix
Projects
None yet
Development

No branches or pull requests

3 participants