Issue with the code #221
ujjawaltyagii
started this conversation in
General
Replies: 2 comments
-
@J-Harsh could you please clarify this ?!!! |
Beta Was this translation helpful? Give feedback.
0 replies
-
@ujjawaltyagii Thanks for pointing out the important issue. I have checked it out and fixed all the errors due to which deployment on Vercel was failing. It was the main reason you were getting toggle menu different on localhost than main website. We are working on these issues so that it will not occur in the future. We are also working on adding comments for better navigation to the new contributors. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
So for contributing in Vibey, I forked and done all the necessary set up on my local system and on running command
yarn dev
webpage was running on local host but when i tried opening the "events" in side menu bar i saw error and when i looked at code there were two errors in./src/pages/events/index.tsx
(without even touching the code i am getting these errors in fresh cloned repo)1st one was a missing closing div
2nd one was that
sortEventsByDate
was using before declaringand on output I was getting this screen :
I fixed these minor errors and then went on to modify the according to the issue i was assigned with but then without even touching code I am getting this
toggle side-menu
different from the official website on my local host :toggle menu on local host : (i didn't even touch the code)
on official website :
I deleted the folder and re-cloned the repo but still issue remains same
so I want to know why there are so many silly issues in the code and,
there is absolutely no comments in code to navigate a contributor through the code. And mostly important if these issues keep popping up then how are we gonna contribute smoothly
Beta Was this translation helpful? Give feedback.
All reactions