-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OctoDash keeps reconnecting if API key is incorrect #2608
Comments
This would require quite a lot of work and I don't think that this feature will be used by many users. Won't work on this, sorry. |
Forgive me for my ignorance as I am not as familiar with Octodash's inner workings, but is it really that difficult to implement? I mean, shouldn't Octodash return some form of error indicating an authorization failure, like an HTTP 401? This would help with troubleshooting a bad config, say if the user tried to use the global API key, or if (like in my case) the key was accidentally revoked. |
The complexity was mostly related to the one-tap fix. I've added a notification if 403 is returned which should make debugging a lot easier. |
After replacing my old OctoPrint username with a new account (and revoking all the prior API keys), I noticed that OctoDash kept saying that it was attempting to reconnect to OctoPrint. It would be great to instead get an on-screen message indicating that the API key is invalid, with instructions on how to correct it (or a one-tap fix).
The text was updated successfully, but these errors were encountered: