feat: advanced axis sharing refactor + enhancements #256
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Problem was not with cleaning the directory. I am leaving the errors in to indicate in the review what the changes are but we should change them on agreement on how the visuals of the new behavior. If accepted we need to change the docs as well to remain visual fidelity in those images or leave them to signal new behavior. |
|
|
|
When I compare with main locally I am not getting this error: test.mp4 |
|
what I did was delete |
|
Well something is different in the CI which indicates a bug or some environment effect. The code needs to work everywhere, not just locally on your machine. |
|
At least the network error is gone now 🥳 |
|
Figured out the problem see #274 |
|
OK I can proceed on review of this PR. |
|
Think the tests that fail are looking good last I checked (prior to latest merge). The issue addresses in #233 is not completely fixed since the partial reversal that happened. |
|
Will need to look at |
| recoded[axi] = recoded.get(axi, []) + [direction] | ||
|
|
||
| # We turn off the tick labels when the scale and | ||
| # ticks are shared (level >= 3) |
There was a problem hiding this comment.
I don't see the level checked here. Is that checked somewhere else?
| # The axis will be a border if it is either | ||
| # (a) on the edge | ||
| # (b) not next to a subplot | ||
| # (c) not next to a subplot of the same kind |
There was a problem hiding this comment.
This comment seems out of place as none of these items are checked here.
| @@ -904,6 +907,185 @@ def units( | |||
| return result[0] if singleton else result | |||
|
|
|||
|
|
|||
| def _get_subplot_layout( | |||
There was a problem hiding this comment.
This whole function needs many more comments. What is axis_type = 1 and why is it hard coded?
Rename of #244
One of UltraPlot's most powerful features is the ability to do advanced axis sharing. The current implementation works well for bottom and left label sharing, but failed in sharing labels for top right labels. This PR addresses this problem while at the same time allowing for sharing axes with more complex layouts.