This implements #284 #285
Merged
This implements #284 #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `ref struct` restriction on DIBuilder * DIBuilders is now a class with an unowned alias interface `IDIBuilder` * Applied LazyEncodedString in some more places to enable use of utf8 literals to provide pre-encoded literal strings
Test Results280 tests 172 ✅ 10s ⏱️ Results for commit bb2047a. ♻️ This comment has been updated with latest results. |
- VS IDE hides stack overflow errors and make it look like things all passed unless you look very carefully for it.
- A crash in the tests should show up as a total fail of the tests, but it doesn't. It just shows up as a count of errors that is easily overlooked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #284
Removed
ref structrestriction on DIBuilderIDIBuilder