Updated interop testing to support EVERY API extended by LibLLVM #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NOTE: Not all APIs are explicitly tested yet.
- Most are not.
* Added SkipTestMethod attribute to support marking a test as skipped
-This acknowledges the intent to test, but that it isn't yet implemented.
- Basically avoids the "Oh, I forgot..."
* Moved string marshallingTests to the interop helpers UT as that's where the implementation now lives.
* Corrected `LibLLVMGetDataLayoutString` to hide the unsafe import.
* Added Interop wrapper around `LLVMCreateConstantRangeAttribute` so that the length of the input array comes from the parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibLLVMGetDataLayoutStringto hide the unsafe import.LLVMCreateConstantRangeAttributeso that the length of the input array comes from the parameters.