Updated highlighting for ANTLR to support references to rules #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rules as a function invocation.
- It's difficult to map the concepts of ANTLR into the scopes defined by Highlight.JS. Especially when the theme used doesn't provide a lot of support for the non-code elements.
- This tags the references to the rules as function invocations (technically, that's how they are implemented...).
- There is a tagging difference between the declaration and the invocation. Even if the theme doesn't show it.
- The theme that comes with DOCFX "modern" template. Is so limited that the declarations are tagged as a 'type' just so they get something in the way of a visual distinction...
- It is plausible to override/replace the theming that comes with the modern template via "main.css" in the custom template... Which could correct a number of issues with readability in dark theme...
- Something to consider...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated highlighting for ANTLR to support references to lexer/grammar rules as a function invocation.