Constant data string #203
Merged
Constant data string #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# BREAKING CHANGE This is a breaking change. The behavior of Context.CreateConstantString(string) has changed slightly. It now constructs a valid C string WITH a null terminator, which is generally what would be expected of something called "string". (The (string,bool) overload remains, to allow apps to be explicit with intent and get the previous behavior) Additionally, the ConstantDataSequential.IsString property now reflects whether the string is a C string (terminating null but no embedded nulls) and the ConstantDataSequential.IsI8Sequence was added to provide the previous behavior of IsString, which was simply that the underlying sequence element type was i8 (with or without a terminator) --- * Added error handling to parsing of YAML configuration in bindings generator app. * Added RawData property to ConstandDataSequential (and used it for the ExtractAsString implementations * Added ExtractAsString overload that accepts an Encoding * ExtractAsString now automatically discards the terminating null if the underlying data is a C String, while allowing extraction of strings without a terminator and in different encodings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #200
Breaking Change
This is a breaking change. The behavior of Context.CreateConstantString(string) has changed slightly. It now constructs a valid C string WITH a null terminator, which is generally what would be expected of something called "string". (The (string,bool) overload remains, to allow apps to be explicit with intent and get the previous behavior) Additionally, the ConstantDataSequential.IsString property now reflects whether the string is a C string (terminating null but no embedded nulls) and the ConstantDataSequential.IsI8Sequence was added to provide the previous behavior of IsString, which was simply that the underlying sequence element type was i8 (with or without a terminator). While this is a breaking change and may cause some issues on updating to this version, it is intended to help clarify the behavior and clean up some less than intuitive behavior of the previous implementation.