Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if save can support ,safe_serialization=False #2533

Open
NLPJCL opened this issue Mar 10, 2024 · 4 comments
Open

if save can support ,safe_serialization=False #2533

NLPJCL opened this issue Mar 10, 2024 · 4 comments
Labels
good first issue Good for newcomers

Comments

@NLPJCL
Copy link

NLPJCL commented Mar 10, 2024

The current save function cannot be set safe_serialization。but defalut safe_serialization=True。thank!

@tomaarsen tomaarsen added the good first issue Good for newcomers label Mar 10, 2024
@tomaarsen
Copy link
Collaborator

Hello!

You're right, it would be nice if users could set safe_serialization so that they can save a pytorch_model.bin if they prefer.

  • Tom Aarsen

@CKeibel
Copy link
Contributor

CKeibel commented Mar 14, 2024

Hi @tomaarsen !
If no one is working on this issue yet, could I work on this to get started with contributing?

@tomaarsen
Copy link
Collaborator

That would be great!
I think we would need to wrap this line with if isinstance(module, Transformer): and then pass the safe_serialization down to the Transformer, while all other modules still stay as module.save(model_path).

  • Tom Aarsen

@CKeibel
Copy link
Contributor

CKeibel commented Mar 14, 2024

Great, thanks for the tip. I'll have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants