-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Necessity of torchvision dependency #1644
Comments
I think the HF clip model also requires torchvision |
How about moving torchvision to extras dependencies? I have a completely non-CV setup and this only complicates things for me. See e.g.: pytorch/vision#5393 |
Agreed with @iamhatesz that having it as optional would be ideal, as |
@tomaarsen I think this issue can be closed after the merge of #1881 |
I agree, thanks for pointing this out! |
Hi, thanks for your work, we've been using sbert for quite some time.
We noticed that
sentence-transformers
depend ontorchvision
, and while it was necessary for CLIP implementation in previous versions, nowsentence-transformers
use CLIP from HF (commit).Is there any reason to keep this dependency now?
The text was updated successfully, but these errors were encountered: