Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda-forge feedstock to include missing dependencies #1279

Open
sugatoray opened this issue Nov 24, 2021 · 5 comments
Open

Update conda-forge feedstock to include missing dependencies #1279

sugatoray opened this issue Nov 24, 2021 · 5 comments

Comments

@sugatoray
Copy link
Contributor

I have already pushed a PR ⭐ against this issue πŸ“ to https://github.com/conda-forge/sentence-transformers-feedstock. It has been almost a week now, but the maintainers have not responded yet.

All that is necessary is to accept and merge the PR (which passed all the CIs).

cc: @ndmaxar, @oblute, @rluria14

@nreimers
Copy link
Member

Yes, the maintainers were also quite slow with the last PRs updating the version:
conda-forge/sentence-transformers-feedstock#17

Sadly I cannot merge them, or is there I way I can take care of that?

@sugatoray
Copy link
Contributor Author

I guess, it's best to update the maintainers' list. I have asked to add myself to it. And I personally feel that it is always a good strategy to include one of the maintainers of the original package as a maintainer of the corresponding conda-forge feedstock.

@sugatoray
Copy link
Contributor Author

sugatoray commented Dec 1, 2021

@nreimers The PR has been merged and I was added to the list of maintainers for conda-forge/sentence-transformers-feedstock.

Conda (channel only)

@nreimers
Copy link
Member

nreimers commented Dec 3, 2021

Great, thank you so much for this :)

@glemaitre
Copy link

@tomaarsen I think this PR could be closed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants